New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834335 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Delete ADBHost, TestBed, et al.

Reported by jrbarnette@chromium.org, Apr 18 2018

Issue description

The following classes appear to be no longer used:
   server.hosts.adb_host.ADBHost
   server.hosts.emulated_adb_host.EmulatedADBHost
   server.hosts.testbed.TestBed

The code needs to be deleted, once all clients that might depend on
them have been identified and addressed.

 
Cc: harpreet@chromium.org
Labels: OS-Chrome
Cc: abhishekbh@chromium.org rjahagir@chromium.org
Cc: haddowk@chromium.org
+ haddowk: engineers / partners often continue to use autotest features that are no longer used in the lab via moblab.

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c2c6d54951e7581b047df233b9f4edfba7ced630

commit c2c6d54951e7581b047df233b9f4edfba7ced630
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Sat Apr 21 06:01:44 2018

autotest: Send metrics about the various host class' usage.

We have a lot of Host classes that we suspect are dead. Start spewing
some metrics about what classes are actually in use so we can
confidently start pouring gasoline over them all.

BUG= chromium:834335 
TEST=moblab-generic-vm-pre-cq

Change-Id: I8444906ee7c9cdf99f40da87b2c5658752065611
Reviewed-on: https://chromium-review.googlesource.com/1022734
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/hosts/chameleon_host.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/hosts/plankton_host.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/hosts/testbed.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/hosts/base_classes.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/hosts/teststation_host.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/cros/packet_generation/IP_utils.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/site_tests/factory_InstallVM/factory_InstallVM.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/cros/update_engine/omaha_devserver.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/cros/network/wifi_test_context_manager.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/site_utils/lib/infra.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/hosts/__init__.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/hosts/factory.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/hosts/servo_host.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/cros/chaos_lib/chaos_runner.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/site_tests/factory_InstallServo/factory_InstallServo.py
[modify] https://crrev.com/c2c6d54951e7581b047df233b9f4edfba7ced630/server/cros/network/chaos_clique_utils.py

The first step will be to delete just TestBed, and the stuff that uses it.

That's happening here:
    https://chromium-review.googlesource.com/#/c/chromiumos/third_party/autotest/+/1014667/

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/c229b1ed1bb6d6d31b9aa714ddd3f8360f90eca2

commit c229b1ed1bb6d6d31b9aa714ddd3f8360f90eca2
Author: Richard Barnette <jrbarnette@google.com>
Date: Thu Apr 26 17:33:44 2018

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/62e48d68e9a31bc39a6806aa0d718f8d352460d0

commit 62e48d68e9a31bc39a6806aa0d718f8d352460d0
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Apr 27 19:22:53 2018

autotest: Fix metrics whitelist typo.

I'm an idiot.

BUG= chromium:834335 
TEST=None

Change-Id: I4eb7ca41078cd93a501ee35fa098fe9e16118ee4
Reviewed-on: https://chromium-review.googlesource.com/1030810
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/62e48d68e9a31bc39a6806aa0d718f8d352460d0/server/hosts/base_classes.py

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 28 2018

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b12413aba1b9a4ccbe8698333250eed661a5ff03

commit b12413aba1b9a4ccbe8698333250eed661a5ff03
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Sat Apr 28 04:27:24 2018

[autotest] Drop Android testbed support from test_push.

This deletes now-dead support for Android testbeds from the
test_push script.

CQ-DEPEND=CL:*615092
BUG= chromium:834335 
TEST=None

Change-Id: Ifb0e33d32315dbf66586491a34395bd80840472b
Reviewed-on: https://chromium-review.googlesource.com/1029182
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[delete] https://crrev.com/ee9aa9a85490430d1ea5ce0e941cf2b9db34d278/test_suites/control.dummy_testbed
[delete] https://crrev.com/ee9aa9a85490430d1ea5ce0e941cf2b9db34d278/server/site_tests/testbed_DummyTest/control.install_apk
[delete] https://crrev.com/ee9aa9a85490430d1ea5ce0e941cf2b9db34d278/test_suites/control.testbed_push
[delete] https://crrev.com/ee9aa9a85490430d1ea5ce0e941cf2b9db34d278/server/site_tests/testbed_DummyTest/testbed_DummyTest.py
[delete] https://crrev.com/ee9aa9a85490430d1ea5ce0e941cf2b9db34d278/server/site_tests/testbed_DummyTest/control
[modify] https://crrev.com/b12413aba1b9a4ccbe8698333250eed661a5ff03/site_utils/test_push.py
[modify] https://crrev.com/b12413aba1b9a4ccbe8698333250eed661a5ff03/site_utils/test_push_unittest.py

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/17fa7c4e8df7dc1feb355633db22134b5ec53c73

commit 17fa7c4e8df7dc1feb355633db22134b5ec53c73
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Sat Apr 28 04:27:25 2018

[autotest] Delete support for provisioning Android testbeds.

This deletes the support for provisioning testbed.TestBed instances.

BUG= chromium:834335 
TEST=TBD

Change-Id: I493aded897f02b47afe9b58d20d7e97fbe3c23c0
Reviewed-on: https://chromium-review.googlesource.com/1029257
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/17fa7c4e8df7dc1feb355633db22134b5ec53c73/server/hosts/testbed.py
[modify] https://crrev.com/17fa7c4e8df7dc1feb355633db22134b5ec53c73/server/cros/provision_unittest.py
[modify] https://crrev.com/17fa7c4e8df7dc1feb355633db22134b5ec53c73/utils/labellib.py
[modify] https://crrev.com/17fa7c4e8df7dc1feb355633db22134b5ec53c73/server/hosts/host_info_unittest.py
[modify] https://crrev.com/17fa7c4e8df7dc1feb355633db22134b5ec53c73/server/cros/provision.py
[delete] https://crrev.com/b12413aba1b9a4ccbe8698333250eed661a5ff03/server/site_tests/provision_TestbedUpdate/control
[modify] https://crrev.com/17fa7c4e8df7dc1feb355633db22134b5ec53c73/server/hosts/host_info.py
[delete] https://crrev.com/b12413aba1b9a4ccbe8698333250eed661a5ff03/server/site_tests/provision_TestbedUpdate/provision_TestbedUpdate.py

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9db8068c7431ddc8da932015b8d28abd53cf7aa7

commit 9db8068c7431ddc8da932015b8d28abd53cf7aa7
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Sat Apr 28 04:27:25 2018

[autotest] Delete code for creating Android testbeds.

This deletes all factory code creating testbed.TestBed instances,
along with some related external references to the TestBed class.

BUG= chromium:834335 
TEST=TBD

Change-Id: Ie400c0c6a1d13aa01130dd38b71b45b0809a2476
Reviewed-on: https://chromium-review.googlesource.com/1029353
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/9db8068c7431ddc8da932015b8d28abd53cf7aa7/server/control_segments/provision
[delete] https://crrev.com/17fa7c4e8df7dc1feb355633db22134b5ec53c73/server/site_tests/android_EasySetup/control
[modify] https://crrev.com/9db8068c7431ddc8da932015b8d28abd53cf7aa7/server/hosts/factory.py
[modify] https://crrev.com/9db8068c7431ddc8da932015b8d28abd53cf7aa7/server/server_job.py
[delete] https://crrev.com/17fa7c4e8df7dc1feb355633db22134b5ec53c73/server/site_tests/android_EasySetup/android_EasySetup.py
[modify] https://crrev.com/9db8068c7431ddc8da932015b8d28abd53cf7aa7/server/control_segments/crashinfo
[modify] https://crrev.com/9db8068c7431ddc8da932015b8d28abd53cf7aa7/global_config.ini
[modify] https://crrev.com/9db8068c7431ddc8da932015b8d28abd53cf7aa7/server/site_utils.py
[delete] https://crrev.com/17fa7c4e8df7dc1feb355633db22134b5ec53c73/site_utils/acts_lib.py
[modify] https://crrev.com/9db8068c7431ddc8da932015b8d28abd53cf7aa7/server/hosts/__init__.py
[modify] https://crrev.com/9db8068c7431ddc8da932015b8d28abd53cf7aa7/server/control_segments/verify_job_repo_url
[modify] https://crrev.com/9db8068c7431ddc8da932015b8d28abd53cf7aa7/server/hosts/factory_unittest.py
[modify] https://crrev.com/9db8068c7431ddc8da932015b8d28abd53cf7aa7/cli/host.py

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6e991206ad92bbd0785e83471233b55411e26233

commit 6e991206ad92bbd0785e83471233b55411e26233
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Sat Apr 28 04:27:27 2018

[autotest] Delete support for testbed labels

In the AFE database, there was a number of host labeling conventions
peculiar to testbed entries.  Most particularly, testbeds allowed
(expected) more than one board label.  Now that testbeds aren't
supported, remove the code that handled those peculiarities.

BUG= chromium:834335 
TEST=sanit suite

Change-Id: I3f071957441fa75a568ab565d1729a3f81e1ab45
Reviewed-on: https://chromium-review.googlesource.com/1030623
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[delete] https://crrev.com/94db6f676790258593c29dfa4a090e7ea04746c3/server/hosts/testbed_label.py
[modify] https://crrev.com/6e991206ad92bbd0785e83471233b55411e26233/server/hosts/base_label.py
[modify] https://crrev.com/6e991206ad92bbd0785e83471233b55411e26233/server/site_utils_unittest.py
[modify] https://crrev.com/6e991206ad92bbd0785e83471233b55411e26233/server/hosts/base_label_unittest.py
[modify] https://crrev.com/6e991206ad92bbd0785e83471233b55411e26233/frontend/afe/models.py
[modify] https://crrev.com/6e991206ad92bbd0785e83471233b55411e26233/tko/parsers/version_0.py
[modify] https://crrev.com/6e991206ad92bbd0785e83471233b55411e26233/server/site_utils.py
[modify] https://crrev.com/6e991206ad92bbd0785e83471233b55411e26233/frontend/afe/rpc_interface.py

At this point, all support for TestBeds is gone from the
source.  The changes will be pushed to prod in the next day
or two.

Code to delete emulated_adb_host is here:
    http://crrev.com/c/1033014

This code will be committed shortly.

There is now a stack of two CLs to delete support for Android DUT
testing from WiFi tests:
    http://crrev.com/c/1036424
    http://crrev.com/c/1036471

The first CL is expected to functionally neutral; it deletes code
that is already dead.  The second change is substantive, and needs
review from someone familiar with WiFi tests.
Project Member

Comment 15 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2489601eec0832c5b96dce4105d2ae11ad4ea56e

commit 2489601eec0832c5b96dce4105d2ae11ad4ea56e
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Tue May 01 15:31:34 2018

[autotest] Delete emulated_adb_host support.

This deletes the eumlated_adb_host module and code that depends on
it.

BUG= chromium:834335 
TEST=sanity suite

Change-Id: If035dc4c3cf69e5430fcef8b1f39e6051713cb12
Reviewed-on: https://chromium-review.googlesource.com/1033014
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Justin Giorgi <jgiorgi@google.com>

[delete] https://crrev.com/ea3ebadb176bf4ae86617b3bebd04627ceefae7c/server/hosts/emulated_adb_host.py
[modify] https://crrev.com/2489601eec0832c5b96dce4105d2ae11ad4ea56e/server/hosts/__init__.py
[modify] https://crrev.com/2489601eec0832c5b96dce4105d2ae11ad4ea56e/server/hosts/factory.py

Project Member

Comment 16 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/67e9366db4cc705cf69ee554c0c8d7fab9c50a4b

commit 67e9366db4cc705cf69ee554c0c8d7fab9c50a4b
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Tue May 01 15:31:34 2018

[autotest] Delete bogus argument from wifi_interop_wpa2 suite

The wifi_interop_wpa2 suite control file contained a bogus
assignment for an argument named `version_prefix`.  No such
argument exists for `dynamic_suite.reimage_and_run()`.

This deletes the assignment

BUG= chromium:834335 
TEST=None

Change-Id: I4def4915f24fa9a61051ac61a5150d81b10a5f95
Reviewed-on: https://chromium-review.googlesource.com/1036424
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/67e9366db4cc705cf69ee554c0c8d7fab9c50a4b/test_suites/control.wifi_interop_wpa2

This CL will remove the `test_droid` command:
    http://crrev.com/c/1036658

Follow-up changes will delete ADBHost, and associated provisioning
code:
    http://crrev.com/c/1036659
    http://crrev.com/c/1036660

Project Member

Comment 18 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/eadbb659b133842f103e149d130a1217844ed12f

commit eadbb659b133842f103e149d130a1217844ed12f
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Thu May 03 05:21:10 2018

[autotest] Delete the test_droid command.

The test_droid command is no longer needed, as we no longer support
standalone Android DUTs in Autotest.

BUG= chromium:834335 
TEST=None

Change-Id: I4fa79e2cb2746cba6e7e2acbaf4615f06eda273b
Reviewed-on: https://chromium-review.googlesource.com/1036658
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>

[delete] https://crrev.com/ac5ef2e25ac27e203e3f1262dcd19df436900c7d/site_utils/test_droid.py

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6cde484926c485904aefe9f692726cf6ad3574f2

commit 6cde484926c485904aefe9f692726cf6ad3574f2
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Fri Jun 15 17:57:55 2018

[autotest] Delete Android support from WiFi tests

Autotest code is no longer used to test against standalone (non-ARC)
Android DUTs.  This deletes support for such DUTs from WiFi testing.

BUG= chromium:834335 
TEST=TBD

Change-Id: I12f777cdfd0cad4e8c761898c819e34c73ee3797
Reviewed-on: https://chromium-review.googlesource.com/1036471
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/6cde484926c485904aefe9f692726cf6ad3574f2/server/cros/network/wifi_client.py
[delete] https://crrev.com/6e70aa86bc1be81be9de2e0b3e2a4ba9dfc6b25f/client/cros/networking/android_xmlrpc_server.py
[modify] https://crrev.com/6cde484926c485904aefe9f692726cf6ad3574f2/server/cros/chaos_lib/static_runner.py
[modify] https://crrev.com/6cde484926c485904aefe9f692726cf6ad3574f2/server/constants.py
[modify] https://crrev.com/6cde484926c485904aefe9f692726cf6ad3574f2/client/cros/constants.py
[delete] https://crrev.com/6e70aa86bc1be81be9de2e0b3e2a4ba9dfc6b25f/server/adb_utils.py
[modify] https://crrev.com/6cde484926c485904aefe9f692726cf6ad3574f2/server/cros/chaos_lib/chaos_runner.py

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/811754353304ae66d3dac418fc34596bcfbbe83f

commit 811754353304ae66d3dac418fc34596bcfbbe83f
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Jul 11 19:12:57 2018

[autotest] Delete Android from the stable image API.

This removes support for assigning Android-type build build images
in the stable image API, as the feature is unused.

BUG= chromium:834335 
TEST=None

Change-Id: I5d20b779163e2cdebabe87464c6ad633e787862c
Reviewed-on: https://chromium-review.googlesource.com/1128452
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/811754353304ae66d3dac418fc34596bcfbbe83f/site_utils/stable_images/stable_version.py
[modify] https://crrev.com/811754353304ae66d3dac418fc34596bcfbbe83f/server/afe_utils.py
[modify] https://crrev.com/811754353304ae66d3dac418fc34596bcfbbe83f/server/frontend.py

Project Member

Comment 21 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8725202f94b5b0e386d0970d53d527893656fe27

commit 8725202f94b5b0e386d0970d53d527893656fe27
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Jul 11 19:12:58 2018

[autotest] Delete Android from stable version RPC.

This deletes support for getting Android versions via the
get_stable_version() RPC.

BUG= chromium:834335 
TEST=Run the stable_version command on a local instance

Change-Id: I87aadb6330fc631e3e92c21bd39ddd1c0e9b0f60
Reviewed-on: https://chromium-review.googlesource.com/1128453
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/8725202f94b5b0e386d0970d53d527893656fe27/site_utils/stable_version_utils.py
[modify] https://crrev.com/8725202f94b5b0e386d0970d53d527893656fe27/frontend/afe/rpc_interface.py

Project Member

Comment 22 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/92082eae16d3626fca48b0eeba13a26993f91cf8

commit 92082eae16d3626fca48b0eeba13a26993f91cf8
Author: Jacob Kopczynski <jkop@google.com>
Date: Thu Jul 12 01:48:39 2018

autotest: change to simpler regex

Behavior consistency guaranteed by a test shown in my x20:
https://jkop.users.x20web.corp.google.com/regex_change_unittest.py

(Bug loosely related)
BUG= chromium:834335 
TEST=locally-run unittest

CQ-DEPEND=CL:1131931

Change-Id: I01b4b500a7ef6b07742bfb648e13971941bd351a
Reviewed-on: https://chromium-review.googlesource.com/1130011
Commit-Ready: Jacob Kopczynski <jkop@chromium.org>
Tested-by: Jacob Kopczynski <jkop@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/92082eae16d3626fca48b0eeba13a26993f91cf8/server/cros/provision.py

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5fc1314f94de8f3b6e9bdfc724052e6466e97ffe

commit 5fc1314f94de8f3b6e9bdfc724052e6466e97ffe
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Mon Jul 16 21:15:26 2018

Revert "[autotest] Delete Android from stable version RPC."

This reverts commit 8725202f94b5b0e386d0970d53d527893656fe27.

Reason for revert: This made an RPC change that was not backwards
compatible, breaking callers from before CL:1128452

Original change's description:
> [autotest] Delete Android from stable version RPC.
> 
> This deletes support for getting Android versions via the
> get_stable_version() RPC.
> 
> BUG= chromium:834335 
> TEST=Run the stable_version command on a local instance
> 
> Change-Id: I87aadb6330fc631e3e92c21bd39ddd1c0e9b0f60
> Reviewed-on: https://chromium-review.googlesource.com/1128453
> Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
> Tested-by: Richard Barnette <jrbarnette@chromium.org>
> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

BUG= chromium:864165 

Change-Id: I97d093bf548ebf776804c19c15b416e6b311d8e6
Reviewed-on: https://chromium-review.googlesource.com/1138913
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/5fc1314f94de8f3b6e9bdfc724052e6466e97ffe/site_utils/stable_version_utils.py
[modify] https://crrev.com/5fc1314f94de8f3b6e9bdfc724052e6466e97ffe/frontend/afe/rpc_interface.py

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/66eb19dab9ad4b1c740cb5342757729b83359913

commit 66eb19dab9ad4b1c740cb5342757729b83359913
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Jul 18 00:30:33 2018

[autotest] Delete Android provisioning support.

This deletes support for provisioning Android DUTs in the test lab.

BUG= chromium:834335 
TEST=sanity suite in local instance

Change-Id: I7e0404cd0efd3f664514b7f24c81cd02f4f6b2b5
Reviewed-on: https://chromium-review.googlesource.com/1036660
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/66eb19dab9ad4b1c740cb5342757729b83359913/server/cros/dynamic_suite/dynamic_suite.py
[delete] https://crrev.com/187766c40b544c3437feed5f189a33a1a9cfd9b4/server/site_tests/provision_AndroidUpdate/control
[delete] https://crrev.com/187766c40b544c3437feed5f189a33a1a9cfd9b4/server/site_tests/provision_AndroidUpdate/provision_AndroidUpdate.py
[modify] https://crrev.com/66eb19dab9ad4b1c740cb5342757729b83359913/global_config.ini
[modify] https://crrev.com/66eb19dab9ad4b1c740cb5342757729b83359913/server/cros/provision_unittest.py
[modify] https://crrev.com/66eb19dab9ad4b1c740cb5342757729b83359913/utils/labellib.py
[modify] https://crrev.com/66eb19dab9ad4b1c740cb5342757729b83359913/server/hosts/host_info_unittest.py
[modify] https://crrev.com/66eb19dab9ad4b1c740cb5342757729b83359913/server/cros/provision.py
[modify] https://crrev.com/66eb19dab9ad4b1c740cb5342757729b83359913/server/hosts/host_info.py
[modify] https://crrev.com/66eb19dab9ad4b1c740cb5342757729b83359913/server/site_utils.py
[modify] https://crrev.com/66eb19dab9ad4b1c740cb5342757729b83359913/frontend/afe/rpc_interface.py

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/187766c40b544c3437feed5f189a33a1a9cfd9b4

commit 187766c40b544c3437feed5f189a33a1a9cfd9b4
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Jul 18 00:30:32 2018

[autotest] Remove machine_install from ADBHost.

This removes the machine_install() method from adb_host.ADBHost, as
well as all code called directly from the method but no-where else.

BUG= chromium:834335 
TEST=TBD

Change-Id: Idd1bfa57ed0285c2574f70735549c668fb5a1c62
Reviewed-on: https://chromium-review.googlesource.com/1128239
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/187766c40b544c3437feed5f189a33a1a9cfd9b4/client/common_lib/android_utils.py
[modify] https://crrev.com/187766c40b544c3437feed5f189a33a1a9cfd9b4/client/common_lib/cros/dev_server.py
[modify] https://crrev.com/187766c40b544c3437feed5f189a33a1a9cfd9b4/server/hosts/adb_host.py

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/97fa4a5dc5d55566903f368193e62df07694844d

commit 97fa4a5dc5d55566903f368193e62df07694844d
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Jul 18 00:30:32 2018

[autotest] Remove support for Android DUTs.

This removes code from ADBHost that existed solely to support
Android devices used as DUTs.  The feature is no longer used.

BUG= chromium:834335 
TEST=TBD

Change-Id: I1ab60d750bf9b2aae3537f660463717947e86381
Reviewed-on: https://chromium-review.googlesource.com/1128442
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/97fa4a5dc5d55566903f368193e62df07694844d/server/site_utils.py
[modify] https://crrev.com/97fa4a5dc5d55566903f368193e62df07694844d/server/hosts/adb_host.py

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/561c2f5049974f5a2cc0048e8283efb2f1d734a2

commit 561c2f5049974f5a2cc0048e8283efb2f1d734a2
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Fri Jul 27 03:45:04 2018

Reland "[autotest] Delete Android from stable version RPC."

This reverts commit 5fc1314f94de8f3b6e9bdfc724052e6466e97ffe.

Reason for revert:  All clients have now been upgraded to use
the new RPC interface.  No extant client should still be using
the `android` flag.  So, it should now be safe to reland this.

Original change's description:
> Revert "[autotest] Delete Android from stable version RPC."
>
> This reverts commit 8725202f94b5b0e386d0970d53d527893656fe27.
>
> Reason for revert: This made an RPC change that was not backwards
> compatible, breaking callers from before CL:1128452
>
> Original change's description:
> > [autotest] Delete Android from stable version RPC.
> >
> > This deletes support for getting Android versions via the
> > get_stable_version() RPC.
> >
> > BUG= chromium:834335 
> > TEST=Run the stable_version command on a local instance
> >
> > Change-Id: I87aadb6330fc631e3e92c21bd39ddd1c0e9b0f60
> > Reviewed-on: https://chromium-review.googlesource.com/1128453
> > Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
> > Tested-by: Richard Barnette <jrbarnette@chromium.org>
> > Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
>
> BUG= chromium:864165 
>
> Change-Id: I97d093bf548ebf776804c19c15b416e6b311d8e6
> Reviewed-on: https://chromium-review.googlesource.com/1138913
> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>

Bug:  chromium:864165 
Change-Id: Iba41cbad43f2af4e2ccfdae71875b064e5b9f0a0
Reviewed-on: https://chromium-review.googlesource.com/1150460
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/561c2f5049974f5a2cc0048e8283efb2f1d734a2/site_utils/stable_version_utils.py
[modify] https://crrev.com/561c2f5049974f5a2cc0048e8283efb2f1d734a2/frontend/afe/rpc_interface.py

Cc: lgoo...@chromium.org roopeshr@google.com
Status: Fixed (was: Started)
At this point, the big stuff is deleted.  There's maybe a couple
dozen lines that _might_ yet be eligible to be removed, but the
code in question is negligible.

There's also an unconfirmed report that we will want to revert
this CL:
    https://chromium-review.googlesource.com/1036471

So, I'm declaring victory here.  If we discover we need to
revert any of the changes above, there can be a separate bug
detailing the issue and the requirements.
Project Member

Comment 29 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/078a3d00f3d112b8c21abd9136028e5a3ffe0dbb

commit 078a3d00f3d112b8c21abd9136028e5a3ffe0dbb
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Fri Aug 03 14:38:35 2018

Revert "Reland "[autotest] Delete Android from stable version RPC.""

This reverts commit 561c2f5049974f5a2cc0048e8283efb2f1d734a2.

Reason for revert:
Clients in SSP containers built from sources that pre-date the
RPC client changes will still make the old call with the
`android` parameter.

Original change's description:
> Reland "[autotest] Delete Android from stable version RPC."
> 
> This reverts commit 5fc1314f94de8f3b6e9bdfc724052e6466e97ffe.
> 
> Reason for revert:  All clients have now been upgraded to use
> the new RPC interface.  No extant client should still be using
> the `android` flag.  So, it should now be safe to reland this.
> 
> Original change's description:
> > Revert "[autotest] Delete Android from stable version RPC."
> >
> > This reverts commit 8725202f94b5b0e386d0970d53d527893656fe27.
> >
> > Reason for revert: This made an RPC change that was not backwards
> > compatible, breaking callers from before CL:1128452
> >
> > Original change's description:
> > > [autotest] Delete Android from stable version RPC.
> > >
> > > This deletes support for getting Android versions via the
> > > get_stable_version() RPC.
> > >
> > > BUG= chromium:834335 
> > > TEST=Run the stable_version command on a local instance
> > >
> > > Change-Id: I87aadb6330fc631e3e92c21bd39ddd1c0e9b0f60
> > > Reviewed-on: https://chromium-review.googlesource.com/1128453
> > > Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
> > > Tested-by: Richard Barnette <jrbarnette@chromium.org>
> > > Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
> >
> > BUG= chromium:864165 
> >
> > Change-Id: I97d093bf548ebf776804c19c15b416e6b311d8e6
> > Reviewed-on: https://chromium-review.googlesource.com/1138913
> > Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
> > Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
> 
> Bug:  chromium:864165 
> Change-Id: Iba41cbad43f2af4e2ccfdae71875b064e5b9f0a0
> Reviewed-on: https://chromium-review.googlesource.com/1150460
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Richard Barnette <jrbarnette@chromium.org>
> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

Bug:  chromium:864165 
Change-Id: I3e8cc7d1153c72e6db414a3c41742caecfaf5d42
Reviewed-on: https://chromium-review.googlesource.com/1162241
Commit-Queue: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/078a3d00f3d112b8c21abd9136028e5a3ffe0dbb/site_utils/stable_version_utils.py
[modify] https://crrev.com/078a3d00f3d112b8c21abd9136028e5a3ffe0dbb/frontend/afe/rpc_interface.py

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e4f93999a3d544c6448dfd1b31f74bb94b02c16a

commit e4f93999a3d544c6448dfd1b31f74bb94b02c16a
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Tue Aug 07 08:50:47 2018

[autotest] Delete Android from stable version RPC.

This deletes server side support for getting Android versions via
the get_stable_version() RPC.

The `android` parameter remains part of the external RPC interface,
in order to support old clients on branches, but the parameter can
no longer be used.

BUG= chromium:834335 ,  chromium:864165 
TEST=None

Change-Id: I45a19e62245963d2a7b7bbe40ac3aa643b68b963
Reviewed-on: https://chromium-review.googlesource.com/1163063
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/e4f93999a3d544c6448dfd1b31f74bb94b02c16a/site_utils/stable_version_utils.py
[modify] https://crrev.com/e4f93999a3d544c6448dfd1b31f74bb94b02c16a/frontend/afe/rpc_interface.py

Project Member

Comment 31 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fd49f0d9f5521183276527e010ce91a28f753bba

commit fd49f0d9f5521183276527e010ce91a28f753bba
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Sat Sep 22 08:43:16 2018

Revert "autotest: Send metrics about the various host class' usage."

This reverts commit c2c6d54951e7581b047df233b9f4edfba7ced630.

Reason for revert: Said host classes deleted.

Original change's description:
> autotest: Send metrics about the various host class' usage.
>
> We have a lot of Host classes that we suspect are dead. Start spewing
> some metrics about what classes are actually in use so we can
> confidently start pouring gasoline over them all.
>
> BUG= chromium:834335 
> TEST=moblab-generic-vm-pre-cq
>
> Change-Id: I8444906ee7c9cdf99f40da87b2c5658752065611
> Reviewed-on: https://chromium-review.googlesource.com/1022734
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

Bug:  chromium:834335 
Change-Id: I2ddb6f649e4eab054ec551f501587648e4e4611d
Reviewed-on: https://chromium-review.googlesource.com/1237089
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/hosts/chameleon_host.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/hosts/plankton_host.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/hosts/base_classes.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/hosts/teststation_host.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/cros/packet_generation/IP_utils.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/site_tests/factory_InstallVM/factory_InstallVM.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/cros/update_engine/omaha_devserver.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/site_utils/lib/infra.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/cros/network/chaos_clique_utils.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/hosts/factory.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/hosts/servo_host.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/cros/chaos_lib/chaos_runner.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/site_tests/factory_InstallServo/factory_InstallServo.py
[modify] https://crrev.com/fd49f0d9f5521183276527e010ce91a28f753bba/server/hosts/__init__.py

Sign in to add a comment