New issue
Advanced search Search tips

Issue 834333 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SoM "Build Details" link is broken.

Project Member Reported by dgarr...@chromium.org, Apr 18 2018

Issue description

SoM alerts contain a Build Details link that doesn't resolve correctly, at least when out of office. The full set of links is a bit weird, and some of them work.

https://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8948917915198337616


 
Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>Build
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a09f2ac039e085d3ffd2dc4445f6dc833d4420f5

commit a09f2ac039e085d3ffd2dc4445f6dc833d4420f5
Author: Don Garrett <dgarrett@google.com>
Date: Thu May 31 23:22:58 2018

Legoland: Update Legoland build URLs.

We were using partially qualified legoland build URLs which did not
load correctly if used on a non-corp machine. We also had multiple
places in the code generating Legoland URLs.

This unifies where we generates the URLs, and updates them to use a
fully qualified domain name.

BUG= chromium:834333 
TEST=run_tests

Change-Id: I80f13ad0a109d8bb4fa1177feec6ea9bd86a957d
Reviewed-on: https://chromium-review.googlesource.com/1077668
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>

[modify] https://crrev.com/a09f2ac039e085d3ffd2dc4445f6dc833d4420f5/lib/boto_compat_unittest.py
[modify] https://crrev.com/a09f2ac039e085d3ffd2dc4445f6dc833d4420f5/lib/request_build.py
[modify] https://crrev.com/a09f2ac039e085d3ffd2dc4445f6dc833d4420f5/lib/tree_status.py
[modify] https://crrev.com/a09f2ac039e085d3ffd2dc4445f6dc833d4420f5/lib/tree_status_unittest.py

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/423b431b31d73b754f199c09fdb0825a6827d4cd

commit 423b431b31d73b754f199c09fdb0825a6827d4cd
Author: chromite-chromium-autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 01 04:58:16 2018

Roll src/third_party/chromite ffe9e60..a09f2ac (5 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ffe9e60..a09f2ac


git log ffe9e60..a09f2ac --date=short --no-merges --format='%ad %ae %s'
2018-05-29 dgarrett@google.com Legoland: Update Legoland build URLs.
2018-05-29 rrangel@chromium.org cros_gdb: address post-submit comments from http://crrev.com/c/1052367
2018-05-24 xixuan@chromium.org cbuildbot: Add provision & bvt-inline suite for nyan_blaze-paladin.
2018-05-23 xixuan@chromium.org cbuildbot: Add fake SkylabHWTestStage to nyan_blaze-paladin.
2018-05-28 jclinton@chromium.org cbuildbot_launch: Clean up stale git locks

Created with:
  gclient setdep -r src/third_party/chromite@a09f2ac

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:834333 ,chromium:none,chromium:845314,chromium:845314,chromium:842018

TBR=chrome-os-gardeners@chromium.org

Change-Id: I6e6012b8c673d0f4d7debda9ec001c42710fce44
Reviewed-on: https://chromium-review.googlesource.com/1081993
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563539}
[modify] https://crrev.com/423b431b31d73b754f199c09fdb0825a6827d4cd/DEPS

Sign in to add a comment