New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834330 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 834373
issue 818798
issue 840608



Sign in to add a comment

Grimoire onboarding plan requires new Git submodule builder

Project Member Reported by flyboy@chromium.org, Apr 18 2018

Issue description

As one step in the plan to migrate Code Search to Grimoire, we should prepare a new copy of the source repositories to be crawled/indexed for search, in a form suitable for input to Grimoire.  We can then experiment with it, to verify that Grimoire's processing of it meets our needs.


 

Comment 1 by flyboy@chromium.org, Apr 18 2018

Owner: flyboy@chromium.org
Status: Started (was: Untriaged)

Comment 2 by flyboy@chromium.org, Apr 18 2018

Blockedon: 818798

Comment 3 by flyboy@chromium.org, Apr 18 2018

Blockedon: 834373
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d9180451f20c16900234b6e8588e6a5eca57b6c0

commit d9180451f20c16900234b6e8588e6a5eca57b6c0
Author: Alan Bram <flyboy@chromium.org>
Date: Wed Apr 18 18:26:09 2018

New builder for Grimoire Code Search experiments.

A new module "gsubmodd" under infra/services maintains a mirror repo with
DEPS converted to git submodules.  It also moves/clones deps2submodules
from a "resource" of the sync_submodules recipe to a shareable module under
infra/libs.

Bug:  834330 
Change-Id: I31875b082da6360f7be84010a870abae5d388cc5
Reviewed-on: https://chromium-review.googlesource.com/985897
Commit-Queue: Alan Bram <flyboy@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/__init__.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps_utils_test.expected/DepsUtilsTest.testEvalSimple.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps2submodules_test.expected/Deps2SubmodulesTest.testDefaultMasterRef.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/gsubmodd.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/gsubmodd_test.expected/evolving_deps_single.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/__main__.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/gsubmodd_test.expected/spurious_sync.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/gsubmodd_test.expected/hello_world.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps_utils_test.expected/DepsUtilsTest.testExtractUrlNested.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/__init__.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/deps_utils.py
[modify] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/git2/test/testing_support_test.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/gsubmodd_test.expected/primitive_deps_file.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/.coveragerc
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/gsubmodd_test_definitions.py
[modify] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/git2/testing_support.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps2submodules_test.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/gsubmodd_test.expected/idle.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/gsubmodd_test.expected/target_sync_lacks_footer.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps2submodules_test.expected/Deps2SubmodulesTest.testExtraSubmodules.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/deps2submodules.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps_utils_test.expected/DepsUtilsTest.testExtractUrlSimple.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/.coveragerc
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps2submodules_test.expected/Deps2SubmodulesTest.testUpdateSubmodules.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/gsubmodd_test.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/__init__.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/gsubmodd_test.expected/git_suffix.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/__init__.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps2submodules_test.expected/Deps2SubmodulesTest.testGitRefResolver.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps2submodules_test.expected/Deps2SubmodulesTest.testSymbolicRef.json
[modify] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/recipes/recipe_modules/sync_submodules/resources/deps2submodules.py
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/services/gsubmodd/test/gsubmodd_test.expected/evolving_deps.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps2submodules_test.expected/Deps2SubmodulesTest.testPruneConflict.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps2submodules_test.expected/Deps2SubmodulesTest.testElidedDeps.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps2submodules_test.expected/Deps2SubmodulesTest.testExcludeByPathPrefix.json
[add] https://crrev.com/d9180451f20c16900234b6e8588e6a5eca57b6c0/infra/libs/deps2submodules/test/deps_utils_test.py

Comment 5 by flyboy@chromium.org, Apr 23 2018

It occurs to me that we probably want to use the "limit" command-line arg to put a bound on the amount of time each invocation of the gsubmodd service runs, during its initial phase of loading up all of history, for the chromium/src repo.  In that repo, we're processing only about 10 commits per minute(!).  The theory is that it takes a long time to dig up each of the very old commits.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ebfa25a76332bc31bc85795a454e11759236e1d5

commit ebfa25a76332bc31bc85795a454e11759236e1d5
Author: Alan Bram <flyboy@chromium.org>
Date: Tue Apr 24 16:48:01 2018

Log per commit at info severity.

The intent is to prevent BuildBot from shutting us down prematurely.

Also, fix a typo in command-line arg name.

Bug:  834330 
Change-Id: I9ffd8d03cdf98b266b0f359f9d50943507bc51c9
Reviewed-on: https://chromium-review.googlesource.com/1025253
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Alan Bram <flyboy@chromium.org>

[modify] https://crrev.com/ebfa25a76332bc31bc85795a454e11759236e1d5/infra/services/gsubmodd/test/gsubmodd_test.expected/primitive_deps_file.json
[modify] https://crrev.com/ebfa25a76332bc31bc85795a454e11759236e1d5/infra/services/gsubmodd/test/gsubmodd_test.expected/hello_world.json
[modify] https://crrev.com/ebfa25a76332bc31bc85795a454e11759236e1d5/infra/services/gsubmodd/gsubmodd.py
[modify] https://crrev.com/ebfa25a76332bc31bc85795a454e11759236e1d5/infra/services/gsubmodd/test/gsubmodd_test.expected/evolving_deps_single.json
[modify] https://crrev.com/ebfa25a76332bc31bc85795a454e11759236e1d5/infra/services/gsubmodd/__main__.py
[modify] https://crrev.com/ebfa25a76332bc31bc85795a454e11759236e1d5/infra/services/gsubmodd/test/gsubmodd_test.expected/evolving_deps.json
[modify] https://crrev.com/ebfa25a76332bc31bc85795a454e11759236e1d5/infra/services/gsubmodd/test/gsubmodd_test.expected/git_suffix.json
[modify] https://crrev.com/ebfa25a76332bc31bc85795a454e11759236e1d5/infra/services/gsubmodd/test/gsubmodd_test.expected/idle.json

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 24 2018

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/08245f4683c80de3ac57287b6c9afccc3c344f63

commit 08245f4683c80de3ac57287b6c9afccc3c344f63
Author: Alan Bram <flyboy@chromium.org>
Date: Tue Apr 24 17:28:17 2018

Add limit of 2000 commits per run, for chromium/src.

Bug:  834330 
Change-Id: I209d373fcb33157fc0ebf599c4b860df3a7a0601
Reviewed-on: https://chromium-review.googlesource.com/1025252
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Alan Bram <flyboy@chromium.org>

[modify] https://crrev.com/08245f4683c80de3ac57287b6c9afccc3c344f63/masters/master.chromium.infra.cron/master.cfg

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/27cae27b51d318dd876c6328ef0181f3e898131d

commit 27cae27b51d318dd876c6328ef0181f3e898131d
Author: Alan Bram <flyboy@chromium.org>
Date: Mon Apr 30 19:31:47 2018

Add names of new builders to related scheduler.

Bug:  834330 
Change-Id: I9c0f079578e4143ce0e7dd8ad13eb394d504865d
Reviewed-on: https://chromium-review.googlesource.com/1035792
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Alan Bram <flyboy@chromium.org>

[modify] https://crrev.com/27cae27b51d318dd876c6328ef0181f3e898131d/masters/master.chromium.infra.cron/master.cfg

Project Member

Comment 10 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d7724d6ce7a03462a64981e5680ac91fae825e29

commit d7724d6ce7a03462a64981e5680ac91fae825e29
Author: Alan Bram <flyboy@chromium.org>
Date: Mon May 07 20:21:24 2018

Fix typo in repo URL

Bug:  834330 
Change-Id: I76f57db05588768c9e78d0286215ee9b60735067
Reviewed-on: https://chromium-review.googlesource.com/1048050
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Alan Bram <flyboy@chromium.org>

[modify] https://crrev.com/d7724d6ce7a03462a64981e5680ac91fae825e29/masters/master.chromium.infra.cron/master.cfg

Blockedon: 840608
Status: Fixed (was: Started)

Sign in to add a comment