VR omnibox is too small when incognito |
||||||
Issue descriptionAt ToT today, the omnibox input field is too small when incognito. This is because the layout wasn't accounting for the missing mic button. There's a separate bug tracking a longer-term fix for this issue, but this issue tracks a targeted fix for M-67.
,
Apr 18 2018
,
Apr 19 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aef13d1bcbe5572e2d15b4fd86efeef8cce6b897 commit aef13d1bcbe5572e2d15b4fd86efeef8cce6b897 Author: Christopher Grant <cjgrant@chromium.org> Date: Thu Apr 19 19:04:20 2018 VR: Fix omnibox text input sizing while incognito BUG= 834318 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ib1023da9cd09a3291725aa539fdfa044356a7e81 Reviewed-on: https://chromium-review.googlesource.com/1016691 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551717}(cherry picked from commit c14c5bca6ecfa5ede0db05343e83628978985ded) Reviewed-on: https://chromium-review.googlesource.com/1019963 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#139} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/aef13d1bcbe5572e2d15b4fd86efeef8cce6b897/chrome/browser/vr/ui_scene_creator.cc
,
Apr 19 2018
,
Apr 23 2018
Verified on build 67.0.3396.16. Incognito Omnibox Search box is not the full length of the bar. Typing lost of characters in the control show that is goes to the end. Also verified that the overall size of the bar in both modes are the same, but in incognito mode the microphone is removed and the edit box is extend to the end of the control. Looks good. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 18 2018