New issue
Advanced search Search tips

Issue 834313 link

Starred by 2 users
Status: Fixed
Owner:
backer@chromium.org
Closed: Oct 31
Cc:
vmi...@chromium.org
kylec...@chromium.org
enne@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 757605



Sign in to add a comment

Remove duplicate OOP-R code from GLES2

Project Member Reported by backer@chromium.org, Apr 18 2018 
There currently is duplicate code both client side and service side to support OOP-R on GLES2Decoder and RasterDecoder. The PoR is to launch OOP-R on RasterDecoder. We should delete the duplicated code as soon as is practicable to avoid the duplicated code from getting out of sync. It does not make sense to refactor for reuse because the desired end state is just one implementation.

Comment 1 by backer@chromium.org, Apr 18 2018 

I'm hoping to do this once we remove the --enable-raster-decoder and use RasterDecoder by default for --enable-oop-rasterization. We're close to having the code and tests ported to RasterDecoder. I'd prefer to fuzz RasterDecoder before enabling by default, but this isn't strictly necessary.
Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875f97e29f13ebbe3f164c6457c02ae2c89b42c9

commit 875f97e29f13ebbe3f164c6457c02ae2c89b42c9
Author: Jonathan Backer <backer@chromium.org>
Date: Tue May 08 21:58:28 2018

Remove discardable from RasterInterface

Discardables are only used for GPU raster. We do not plan to support GPU
raster in RasterInterface because GPU raster requires a GrContext (which
is roughly a full GL context).

Bug:  834313 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib99c788565c48d9f312c79e2b3a2b5dcd4ce9721
Reviewed-on: https://chromium-review.googlesource.com/1050391
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556975}
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/build_raster_cmd_buffer.py
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/client/raster_cmd_helper_autogen.h
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/client/raster_implementation.cc
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/client/raster_implementation.h
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/client/raster_implementation_autogen.h
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/client/raster_implementation_gles.cc
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/client/raster_implementation_gles.h
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/client/raster_implementation_gles_unittest.cc
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/client/raster_implementation_unittest.cc
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/client/raster_interface_autogen.h
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/common/raster_cmd_format_autogen.h
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/common/raster_cmd_format_test_autogen.h
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/common/raster_cmd_ids_autogen.h
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/raster_cmd_buffer_functions.txt
[modify] https://crrev.com/875f97e29f13ebbe3f164c6457c02ae2c89b42c9/gpu/command_buffer/service/raster_decoder.cc
Project Member

Comment 3 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/862b08d7cb2966694416f57aa17285d84c5b12ed

commit 862b08d7cb2966694416f57aa17285d84c5b12ed
Author: Jonathan Backer <backer@chromium.org>
Date: Thu May 10 15:37:04 2018

Remove OOP-R from RasterImplementationGLES

If you want to use OOP-R you need to use a RasterImplementation backed
by a RasterDecoder service side. This is consistent with how
--enable-oop-rasterization turns on RasterDecoder by default.

TBR: danakj@chromium.org, sadrul@chromium.org
Bug:  834313 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8bb9b86eaaf031502bf0f1504300a629df19cbfb
Reviewed-on: https://chromium-review.googlesource.com/1052814
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557526}
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/cc/paint/transfer_cache_unittest.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/cc/test/pixel_test.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/cc/test/test_in_process_context_provider.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/cc/trees/layer_tree_host_pixeltest_scrollbars.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/components/viz/test/test_context_provider.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_implementation_unittest_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/implementation_base.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/implementation_base.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/raster_implementation.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/raster_implementation.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/raster_implementation_gles.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/raster_implementation_gles.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/client/raster_implementation_gles_unittest.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/gles2_cmd_buffer_functions.txt
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/service/decoder_context.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/service/gles2_cmd_decoder_mock.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/command_buffer/service/raster_decoder.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/ipc/gl_in_process_context.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/ipc/gl_in_process_context.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/ipc/raster_in_process_context.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/ipc/raster_in_process_context.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/skia_bindings/gles2_implementation_with_grcontext_support.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/gpu/skia_bindings/gles2_implementation_with_grcontext_support.h
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/services/ui/public/cpp/gpu/context_provider_command_buffer.cc
[modify] https://crrev.com/862b08d7cb2966694416f57aa17285d84c5b12ed/ui/compositor/test/in_process_context_provider.cc

Comment 4 by rjkroege@chromium.org, Oct 24

Blocking: 757605
Labels: vulkanize

Comment 5 by rjkroege@chromium.org, Oct 29

Labels: -vulkanize Proj-Vulkanize

Comment 6 by backer@chromium.org, Oct 31

Status: Fixed (was: Assigned)
I'm not aware of other duplicate code that I can remove.
►

Sign in to add a comment