New issue
Advanced search Search tips

Issue 834308 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Use fixed-size layouts where applicable for stability and simplicity

Project Member Reported by cjgrant@chromium.org, Apr 18 2018

Issue description

The VR UI has accumulated multiple instances of tricky manual resizing within a layout.

For example, "make the omnibox text field wider if there is no mic button visible".

This binding-based approach is brittle and very easy to break.  LinearLayout has already been augmented with the notion of resizing a sacrifical element to ensure a fixed total width.  A bit more work is required to allow it to resize elements in an arbitrary way (ie. text requires a SetFieldWidth() call), but after that, we should employ the new approach.

This would apply, at least, to:
- URL bar origin layout
- URL bar hint text layout
- Omnibox (text field and mic button) layout
 
Labels: -Pri-1 -M-68 Pri-2
Description: Show this description
Description: Show this description

Comment 4 by ddorwin@chromium.org, Jan 18 (4 days ago)

Labels: OS-Android

Sign in to add a comment