New issue
Advanced search Search tips

Issue 834300 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

`gooftool get_firmware_hash` raises exception

Project Member Reported by chenghan@chromium.org, Apr 18 2018

Issue description

Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) flashrom -p host -i GBB -i RO_SECTION -r /tmp/some_file
(2) gooftool get_firmware_hash --file /tmp/some_file

What is the expected result?
version: some_version
hash: some_hash

What happens instead?
UNCAUGHT RUNTIME EXCEPTION 'str' object has no attribute 'iteritems'


 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/2c668ae3d64f20b9aeb43800d9da378b38627dc8

commit 2c668ae3d64f20b9aeb43800d9da378b38627dc8
Author: Cheng-Han Yang <chenghan@google.com>
Date: Mon Apr 23 20:07:20 2018

gooftool: Fix get_firmware_hash exception

BUG= chromium:834300 
TEST=manually test on DUT

Change-Id: I55ce184ff670321387bd6a6a72d00bdb208c4c60
Reviewed-on: https://chromium-review.googlesource.com/1017020
Commit-Ready: Cheng-Han Yang <chenghan@chromium.org>
Tested-by: Cheng-Han Yang <chenghan@chromium.org>
Reviewed-by: Yong Hong <yhong@google.com>

[modify] https://crrev.com/2c668ae3d64f20b9aeb43800d9da378b38627dc8/py/gooftool/commands.py

Status: Fixed (was: Untriaged)

Sign in to add a comment