Issue metadata
Sign in to add a comment
|
Weird scrollbars observed in devtools settings |
||||||||||||||||||||||
Issue descriptionChrome Version: Canary- 68.0.3399.0,dev-67.0.3393.4 OS: Mac 10.13.3 What steps will reproduce the problem? 1.Launch chrome 2.Right click and Inspect 3.Observe 2 scroll bars in the elements section (downwards) 4.Click on 3 dots on top right corner 5. Select 'settings' What is the expected result? Only one scroll bar should be displayed in devtools>settings page What happens instead? 3 extra scroll bars are seen which are not scrolling. Please find the attached screencast for reference. Bisect info: ------------- Good-67.0.3371.0-Revision-543278 Bad-67.0.3372.0-Revision-543592 Bisect tool info: ------------- You are probably looking for a change made after 543290 (known good), but no later than 543291 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/63667eca2a1d86f5de61f29c7c5c6417cc351757..3a3c78a924a686ed0d3f90d765b00cdd78453e11 Possible suspect: --------------- https://chromium.googlesource.com/chromium/src/+/3a3c78a924a686ed0d3f90d765b00cdd78453e11 wangxianzhu@, could you please take a look into it & reassign to the right owner if it is not related to your change. Note: No issue seen on windows & linux OS. Thanks..
,
Apr 18 2018
,
Apr 18 2018
,
Apr 18 2018
pdr@ can you take a look?
,
Apr 25 2018
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Apr 30 2018
Xianzhu, I'm stuck under RLS regressions and haven't been able to look at this. I don't want to let it slip though. Do you have cycles to pick this up?
,
Apr 30 2018
Sure. I will take a look.
,
Apr 30 2018
I couldn't reproduce on Mac 10.13.3 Retina display, on 67.0.3372.0. jmukthavaram@chromium.org what is your display configuration? Can you attach screen shot and/or video? Thanks.
,
Apr 30 2018
Maybe try --disable-prefer-compositing-to-lcd-text?
,
Apr 30 2018
Reproduced with --disable-prefer-compositing-to-lcd-text. The overlay scrollbars are always visible, without fading in and out. I thought the bug was related to composited scrolling because it reproduced on Mac but not Windows and Linux, but it is actually about non-composited overlay scrollbars.
,
Apr 30 2018
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3518c7115bed5c02568c01020e25a4fc9cb9f07e commit 3518c7115bed5c02568c01020e25a4fc9cb9f07e Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue May 01 16:08:08 2018 [SPv175] Apply opacity when painting scrollbar thumb on mac Previously the opacity was applied with CompositingRecorder which becomes no-op in SPv175. Now apply the opacity with GraphicsContext::BeginLayer(). Bug: 834296 Change-Id: Ie4968595a7df02592b81fb0ae2b14ee0097f4313 Reviewed-on: https://chromium-review.googlesource.com/1036223 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555055} [add] https://crrev.com/3518c7115bed5c02568c01020e25a4fc9cb9f07e/third_party/WebKit/LayoutTests/platform/mac/scrollbars/composited-platform-overlay-scrollbars-initially-invisible-expected.html [add] https://crrev.com/3518c7115bed5c02568c01020e25a4fc9cb9f07e/third_party/WebKit/LayoutTests/platform/mac/scrollbars/composited-platform-overlay-scrollbars-initially-invisible.html [add] https://crrev.com/3518c7115bed5c02568c01020e25a4fc9cb9f07e/third_party/WebKit/LayoutTests/platform/mac/scrollbars/non-composited-platform-overlay-scrollbars-initially-invisible-expected.html [add] https://crrev.com/3518c7115bed5c02568c01020e25a4fc9cb9f07e/third_party/WebKit/LayoutTests/platform/mac/scrollbars/non-composited-platform-overlay-scrollbars-initially-invisible.html [modify] https://crrev.com/3518c7115bed5c02568c01020e25a4fc9cb9f07e/third_party/blink/renderer/platform/scroll/scrollbar_theme.cc [modify] https://crrev.com/3518c7115bed5c02568c01020e25a4fc9cb9f07e/third_party/blink/renderer/platform/scroll/scrollbar_theme.h [modify] https://crrev.com/3518c7115bed5c02568c01020e25a4fc9cb9f07e/third_party/blink/renderer/platform/scroll/scrollbar_theme_mac.h [modify] https://crrev.com/3518c7115bed5c02568c01020e25a4fc9cb9f07e/third_party/blink/renderer/platform/scroll/scrollbar_theme_mac.mm
,
May 2 2018
Verified on 68.0.3417.0 canary on Mac with --disable-prefer-compositing-to-lcd-text that the bug has been fixed.
,
May 2 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 2 2018
Approving merge to M67 branch 3396 based on comment #15. Pls merge ASAP. Thank you.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/773f7fe147c10b958b0f87ca3b9143cc36f0a5a4 commit 773f7fe147c10b958b0f87ca3b9143cc36f0a5a4 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed May 02 18:31:49 2018 [SPv175] Apply opacity when painting scrollbar thumb on mac Previously the opacity was applied with CompositingRecorder which becomes no-op in SPv175. Now apply the opacity with GraphicsContext::BeginLayer(). TBR=wangxianzhu@chromium.org (cherry picked from commit 3518c7115bed5c02568c01020e25a4fc9cb9f07e) Bug: 834296 Change-Id: Ie4968595a7df02592b81fb0ae2b14ee0097f4313 Reviewed-on: https://chromium-review.googlesource.com/1036223 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#555055} Reviewed-on: https://chromium-review.googlesource.com/1040359 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#445} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [add] https://crrev.com/773f7fe147c10b958b0f87ca3b9143cc36f0a5a4/third_party/WebKit/LayoutTests/platform/mac/scrollbars/composited-platform-overlay-scrollbars-initially-invisible-expected.html [add] https://crrev.com/773f7fe147c10b958b0f87ca3b9143cc36f0a5a4/third_party/WebKit/LayoutTests/platform/mac/scrollbars/composited-platform-overlay-scrollbars-initially-invisible.html [add] https://crrev.com/773f7fe147c10b958b0f87ca3b9143cc36f0a5a4/third_party/WebKit/LayoutTests/platform/mac/scrollbars/non-composited-platform-overlay-scrollbars-initially-invisible-expected.html [add] https://crrev.com/773f7fe147c10b958b0f87ca3b9143cc36f0a5a4/third_party/WebKit/LayoutTests/platform/mac/scrollbars/non-composited-platform-overlay-scrollbars-initially-invisible.html [modify] https://crrev.com/773f7fe147c10b958b0f87ca3b9143cc36f0a5a4/third_party/blink/renderer/platform/scroll/scrollbar_theme.cc [modify] https://crrev.com/773f7fe147c10b958b0f87ca3b9143cc36f0a5a4/third_party/blink/renderer/platform/scroll/scrollbar_theme.h [modify] https://crrev.com/773f7fe147c10b958b0f87ca3b9143cc36f0a5a4/third_party/blink/renderer/platform/scroll/scrollbar_theme_mac.h [modify] https://crrev.com/773f7fe147c10b958b0f87ca3b9143cc36f0a5a4/third_party/blink/renderer/platform/scroll/scrollbar_theme_mac.mm
,
May 2 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jmukthavaram@chromium.org
, Apr 18 2018