update_kernel.py cannot correctly detect dev signed firmware |
||
Issue descriptionChrome Version: ToT OS: Chrome What steps will reproduce the problem? (1) Install dev signed firmware and pre-mp signed release image (2) Run update_kernel.py with argument `to_release=true` What is the expected result? Successfully update kernel. What happens instead? CalledProcessError: Command '['flashrom', '-r', '/tmp/cftmp.3GQ6b3', '-i', 'GBB', '-i', 'FMAP']' returned non-zero exit status 1
,
Apr 18 2018
should we change that to 'flashrom -p host -r FILE -i GBB -i FMAP' (add -p host)
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/208fd7ed73dc761caabd3d3c2b0234ee5fa910f7 commit 208fd7ed73dc761caabd3d3c2b0234ee5fa910f7 Author: Cheng-Han Yang <chenghan@google.com> Date: Thu Apr 19 05:31:13 2018 pytest: Make update_kernel correctly detect fw version update_kernel.py cannot correctly get firmware version using gooftool. This CL uses probe function to get the information. BUG= chromium:834292 TEST=manually test on DUT Change-Id: I93c5de40c51d2480b74002a6505051ce733c715d Reviewed-on: https://chromium-review.googlesource.com/1016821 Commit-Ready: Cheng-Han Yang <chenghan@chromium.org> Tested-by: Cheng-Han Yang <chenghan@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/208fd7ed73dc761caabd3d3c2b0234ee5fa910f7/py/test/pytests/update_kernel.py
,
May 23 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by chenghan@chromium.org
, Apr 18 2018