New issue
Advanced search Search tips

Issue 834291 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Real world leak detector false positives caused by requests made in unload event

Project Member Reported by keishi@chromium.org, Apr 18 2018

Issue description

Chrome Version: 68.0.3398.0

What steps will reproduce the problem?
(1) Run cluster telemetry leak detector for https://www.mkekabet.com
$ tools/perf/run_benchmark run leak_detection.cluster_telemetry --also-run-disabled-tests --user-agent=desktop --urls-list=http://www.mkekabet.com --archive-data-file=/Users/keishi/Downloads/59952/59952.json  --output-dir=/tmp --browser=release --device=desktop --pageset-repeat=1 --output-format=csv --show-stdout  -v
(2) final navigation to about:blank shows 404 error
(3) and a leak is detected

What is happening
(1) http://www.mkekabet.com uses cometd. cometd usually uses web sockets but when wpr proxy is used, web sockets don't work so it falls back to http long polling. (This is probably why the issue won't reproduce locally using the live site)
(2) Leak detector calls Page.Navigate("about:blank")
(3) http://www.mkekabet.com unload event handler runs, which issues an XHR to https://www.mkekabet.com/cometd/disconnect
(4) RenderFrameImpl::DidReceiveResponse gets the 404 response for https://www.mkekabet.com/cometd/disconnect and sets internal_data.http_status_code to 404
(5) Document::FinishedParsing for about:blank is called. It ends up calling RenderFrameImpl::RunScriptsAtDocumentReady which decides to show the 404 error page because (document_is_empty && internal_data.http_status_code is error).
According to the comments this is because, usually a blank document is likely to be a result of http error.
  // If this is an empty document with an http status code indicating an error,
  // we may want to display our own error page, so the user doesn't end up
  // with an unexplained blank page.

 
Components: -Blink Blink>Infra
I guess this falls under blink infra?
Ping from the ecosystem-infra sheriff. Is this still a P2 issue? Is there anyone who would be assigned to this bug?
Cc: -yuzus@chromium.org
Owner: yuzus@chromium.org
Status: Assigned (was: Available)
Assigning to yuzus@ like some other leak detector issues in Blink>Infra. yuzus@, please unassign or reassign if this is not correct.

Sign in to add a comment