New issue
Advanced search Search tips

Issue 834288 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug


Sign in to add a comment

Various flaky tests in org.chromium.shape_detection.FaceDetectionImplTest

Project Member Reported by futhark@chromium.org, Apr 18 2018

Issue description

See blocked issues.

 
Blockedon: 833089
Blockedon: 833090
Blockedon: 833094
Blockedon: 833099
Blockedon: 833184
Cc: futhark@chromium.org
Components: Blink>ImageCapture
Labels: -Pri-2 OS-Android Pri-1
Owner: mcasas@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by kbr@chromium.org, Apr 20 2018

Labels: Sheriff-Chromium
Why has this, and/or dependent bugs, not been addressed yet? This is causing a huge number of retries on https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/?limit=200 .

Sample error log from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/405153 :

java.lang.UnsatisfiedLinkError: No implementation found for int org.chromium.mojo.system.impl.CoreImpl.nativeGetNativeBufferOffset(java.nio.ByteBuffer, int) (tried Java_org_chromium_mojo_system_impl_CoreImpl_nativeGetNativeBufferOffset and Java_org_chromium_mojo_system_impl_CoreImpl_nativeGetNativeBufferOffset__Ljava_nio_ByteBuffer_2I)
	at org.chromium.mojo.system.impl.CoreImpl.nativeGetNativeBufferOffset(CoreImpl.java)
	at org.chromium.mojo.system.impl.CoreImpl.<init>(CoreImpl.java:82)
	at org.chromium.mojo.system.impl.CoreImpl.<init>(CoreImpl.java:38)
	at org.chromium.mojo.system.impl.CoreImpl$LazyHolder.<clinit>(CoreImpl.java:59)
	at org.chromium.mojo.system.impl.CoreImpl.getInstance(CoreImpl.java:75)
	at org.chromium.mojo_base.BigBufferUtil.createBigBufferFromBytes(BigBufferUtil.java:44)
	at org.chromium.shape_detection.TestUtils.mojoBitmapFromBitmap(TestUtils.java:47)
	at org.chromium.shape_detection.TestUtils.mojoBitmapFromFile(TestUtils.java:54)
	at org.chromium.shape_detection.FaceDetectionImplTest.<clinit>(FaceDetectionImplTest.java:34)
	at java.lang.reflect.Constructor.newInstance(Constructor.java)
	at org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
	at org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:268)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:201)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:43)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:183)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:120)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)

What changed? If a revert can't be pinpointed then please turn off these tests until they're fixed.

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/523d88f810e692ab26a0a8b8f05bdabdef5c9ed8

commit 523d88f810e692ab26a0a8b8f05bdabdef5c9ed8
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Apr 20 08:23:15 2018

Disable flaky services java tests.

TBR=sky@chromium.org

Bug:  834288 ,  833088 
Change-Id: Ide3dc52c89a77be635b1143dcb4c6ae28d3dcb0e
Reviewed-on: https://chromium-review.googlesource.com/1021120
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552283}
[modify] https://crrev.com/523d88f810e692ab26a0a8b8f05bdabdef5c9ed8/services/BUILD.gn

Labels: -Sheriff-Chromium
Blockedon: -833089
Blockedon: 833089
 Issue 833089  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/406893aa4e1cae8dad52230f162a55c8c71bcf72

commit 406893aa4e1cae8dad52230f162a55c8c71bcf72
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Apr 20 19:38:37 2018

Revert "Disable flaky services java tests."

This reverts commit 523d88f810e692ab26a0a8b8f05bdabdef5c9ed8.

Reason for revert: Tests should be fixed now.

Original change's description:
> Disable flaky services java tests.
> 
> TBR=sky@chromium.org
> 
> Bug:  834288 ,  833088 
> Change-Id: Ide3dc52c89a77be635b1143dcb4c6ae28d3dcb0e
> Reviewed-on: https://chromium-review.googlesource.com/1021120
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552283}

TBR=futhark@chromium.org

Change-Id: I1168452281fb0331ac7ee9e4cefbd53bef1c3318
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  834288 ,  833088 
Reviewed-on: https://chromium-review.googlesource.com/1022551
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552432}
[modify] https://crrev.com/406893aa4e1cae8dad52230f162a55c8c71bcf72/services/BUILD.gn

Project Member

Comment 13 by chromium...@appspot.gserviceaccount.com, Apr 20 2018

Labels: Sheriff-Chromium
Detected 10 new flakes for test/step "org.chromium.shape_detection.FaceDetectionImplTest#testDetectFacesInProfileWithGmsCore". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYQsSBUZsYWtlIlZvcmcuY2hyb21pdW0uc2hhcGVfZGV0ZWN0aW9uLkZhY2VEZXRlY3Rpb25JbXBsVGVzdCN0ZXN0RGV0ZWN0RmFjZXNJblByb2ZpbGVXaXRoR21zQ29yZQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 14 by jwd@chromium.org, Apr 20 2018

Labels: -Sheriff-Chromium
Status: Fixed (was: Assigned)
The flakiness dashboard doesn't show this tests as flaky anymore
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.shape_detection.FaceDetectionImplTest
so I guess we're good now after rockot@s patches.

Sign in to add a comment