New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834259 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Reduce the visibility of ambient install banner on navigation.

Project Member Reported by paulkin...@google.com, Apr 18 2018

Issue description

Chrome Version: 67.0.3396.0
OS: Android O

What steps will reproduce the problem?
(1) Go to https://paul.kinlan.me/
(2) See the ambient banner appear.
(3) Navigate to an interesting article.
(4) See the ambient banner appear.

What is the expected result?

I love the idea of the ambient banner, I found it incredibly frustrating that on every navigation it would appear. Because this banner is so visible, I could see a lot of people getting very very annoyed. 

I would love to see some changes to the heuristic along the lines of: Only show on the first navigation to the page, subsequent navigations whilst on the origin / scope, won't re-trigger. That way, if you go to it from the address bar, or another origin it will prompt, but whilst I am 'in-site' it will not get in the way.

What happens instead?

The ambient banner always appears and get's in the way until you scroll.


 
Cc: benwells@chromium.org
Thanks for filing. We want to make this UI steady state in a less intrusive form (e.g. omnibox badge), meaning that if we introduce a heuristic like this it would be temporary.

+benwells for thoughts (and since I'm about to go OOO).
Cc: dullweber@chromium.org
As users can always go to menu > add to homescreen and websites can prompt for installation, I wonder if the banner could be reduced to a single impression?

Comment 3 by ltian@chromium.org, Apr 19 2018

Labels: -Type-Bug android-fe-triaged Type-Feature
Status: Available (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b423ee3e193af2ec44260d1f19590fa5b7ea9980

commit b423ee3e193af2ec44260d1f19590fa5b7ea9980
Author: Dominick Ng <dominickn@chromium.org>
Date: Wed May 23 06:54:58 2018

Hide the ambient install infobar for 90 days if it has been dismissed.

This CL reduces the annoyingness of the ambient badge infobar on Android
when browsing a PWA. If the infobar is dismissed, it will not be shown
for 90 days, mirroring the existing block time for infobar app banners.
The infobar will continue to be shown on navigations until it is
dismissed.

BUG=782120, 834259 

Change-Id: Idbbb9e9451fd01f639e859a1b65470330929f993
Reviewed-on: https://chromium-review.googlesource.com/1068903
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560977}
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/banners/app_banner_manager_android.h
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/installable/installable_ambient_badge_infobar_delegate.cc
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/installable/installable_ambient_badge_infobar_delegate.h
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/tools/metrics/histograms/enums.xml

Status: Fixed (was: Available)
Cc: -dominickn@chromium.org
Owner: dominickn@chromium.org

Sign in to add a comment