New issue
Advanced search Search tips

Issue 834241 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] 'Audit to perform' overlay doesn’t get closed on pressing ‘Esc’ key.

Reported by dchau...@etouch.net, Apr 18 2018

Issue description

Chrome Version: 67.0.3396.10 (Official Build) Revision 5f5009767d16328f4a3c8c4cc6610a7f8bfe0d9e-refs/branch-heads/3396@{#66} 32/64-bit.
OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5) and Linux (14.04 LTS).

What steps will reproduce the problem?
1. Lunch Chrome and navigate to ‘chrome://settings/‘ page.
2. Open ‘DevTools’ and go to ‘Audits’ section.
3. Click on ‘Perform an audit’ button to open ‘Audit to perform’ overlay.
4. Now press ‘Esc’ key from keyboard and observe.

Actual: ‘Audit to perform’ overlay doesn’t get closed on pressing ‘Esc’ key.
Expected: ‘Audit to perform’ overlay should get closed on pressing ‘Esc’ key.

This is a regression issue, broken in M-66 series, below is manual regression range.

Good build: 66.0.3350.0 (Revision: 537343)
Bad build: 66.0.3352.0 (Revision: 538313)

Using the per-revision bisect providing the bisect results:

You are probably looking for a change made after 538299 (known good), but no later than 538300 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/2ffd5e285ca493d96d891db2b25d611d73eadbc6..e4daa74328a267cbe6b64ee846647dce1a901430

Suspecting: https://chromium.googlesource.com/chromium/src/+/e4daa74328a267cbe6b64ee846647dce1a901430

@paulirish: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

NOTE: This issue is also reproducible on M-66 Stable & Beta (build # 66.0.3359.117) and M-68 Canary (build # 68.0.3399.0).

Kindly review the attached screen-cast for reference.

Thank you.


 
Actual behavior.mov
4.0 MB View Download
Expected behavior.mov
2.8 MB View Download
Status: Fixed (was: Assigned)
Audits panel UI was redone in https://chromium-review.googlesource.com/c/chromium/src/+/1058708

This bug has now been fixed.

Sign in to add a comment