https://chromium-review.googlesource.com/c/chromium/src/+/1016447

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6989001fc3f80c691c6327f5876ff3d9bce3617d

commit 6989001fc3f80c691c6327f5876ff3d9bce3617d
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Apr 19 03:29:00 2018

Fix cl.exe warning

Bug: 834213
Change-Id: I6b5c07fa3a8e0d2eebd70cfd86e5679810da6063
Reviewed-on: https://chromium-review.googlesource.com/1016447
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551935}
[modify] https://crrev.com/6989001fc3f80c691c6327f5876ff3d9bce3617d/chrome/browser/ui/blocked_content/popup_tracker_browsertest.cc

We have yet another compile error..

https://luci-milo.appspot.com/buildbot/chromium.fyi/WinMSVC64%20Goma%20Canary/2712
[659/8243] CXX obj/services/ui/ws2/lib/client_change_tracker.obj
FAILED: obj/services/ui/ws2/lib/client_change_tracker.obj
ninja -t msvc -e environment.x64 -- E:\b\c\goma_client/gomacc.exe "E:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\VC\Tools\MSVC\14.11.25503\bin\HostX64\x64/cl.exe" /nologo /showIncludes  -DIS_WINDOW_SERVICE_IMPL -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL -DWEBP_EXTERN=extern -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -D"SK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"" -DSK_SUPPORT_GPU=1 -DGR_GL_FUNCTION_TYPE=__stdcall -DLEVELDB_PLATFORM_CHROMIUM=1 -DDeleteFile=DeleteFileW -DOS_WIN -I../.. -Igen -I../../third_party/khronos -I../../gpu -I../../third_party/libwebp/src -I../../third_party/wtl/include -I../../third_party/libyuv/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/third_party/skcms -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/libwebm/source -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include /utf-8 /wd4117 /D__DATE__= /D__TIME__= /D__TIMESTAMP__= /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- /W4 /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /MT /wd4267 /TP /wd4577 /GR- /c ../../services/ui/ws2/client_change_tracker.cc /Foobj/services/ui/ws2/lib/client_change_tracker.obj /Fd"obj/services/ui/ws2/lib_cc.pdb"
../..\ui/base/window_tracker_template.h(57): error C2027: use of undefined type 'aura::Window'
../..\services/ui/ws2/client_change.h(17): note: see declaration of 'aura::Window'
../..\ui/base/window_tracker_template.h(54): note: while compiling class template member function 'void ui::WindowTrackerTemplate<aura::Window,aura::WindowObserver>::Remove(T *)'
with
[
T=aura::Window
]
../..\ui/base/window_tracker_template.h(78): note: see reference to function template instantiation 'void ui::WindowTrackerTemplate<aura::Window,aura::WindowObserver>::Remove(T *)' being compiled
with
[
T=aura::Window
]
../..\services/ui/ws2/client_change.h(53): note: see reference to class template instantiation 'ui::WindowTrackerTemplate<aura::Window,aura::WindowObserver>' being compiled
../..\ui/base/window_tracker_template.h(57): error C2227: left of '->RemoveObserver' must point to class/struct/union/generic type

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FWinMSVC64_Goma_Canary%2F3105%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Flogs%2Fraw_io.output_failure_summary_%2F0

FAILED: obj/net/net/network_quality_estimator.obj
ninja -t msvc -e environment.x64 -- E:\b\c\goma_client/gomacc.exe "E:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\VC\Tools\MSVC\14.11.25503\bin\HostX64\x64/cl.exe" /nologo /showIncludes  -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DDLOPEN_KERBEROS -DNET_IMPLEMENTATION -DUSE_KERBEROS -DENABLE_BUILT_IN_DNS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -I../.. -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/zlib -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/brotli/include /utf-8 /wd4117 /D__DATE__= /D__TIME__= /D__TIMESTAMP__= /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- /W4 /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /MT /wd4267 /TP /wd4577 /GR- /c ../../net/nqe/network_quality_estimator.cc /Foobj/net/net/network_quality_estimator.obj /Fd"obj/net/net_cc.pdb"
e:\b\c\builder\win\src\net\nqe\network_quality_estimator.cc(1314) : error C2220: warning treated as error - no 'object' file generated
e:\b\c\builder\win\src\net\nqe\network_quality_estimator.cc(1314) : warning C4715: 'net::NetworkQualityEstimator::GetRTTEstimateInternal': not all control paths return a value

I wonder why the bot is still trying to build net -- what pulls that in? Webrtc?

Looks like so.
https://chromium.googlesource.com/chromium/src/+/220d4a1717c8ffd659f5b99cae8cf44892cc0071/third_party/webrtc_overrides/BUILD.gn#38
I will change build target to targets in webrtc directory.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73e1cc622910eb9b719e96027d20bd20a8028798

commit 73e1cc622910eb9b719e96027d20bd20a8028798
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Apr 26 03:55:13 2018

Drop webrtc and test from cl.exe builder

We don't want to run test on the builders.
I will add webrtc target in tools repository.
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

Bug: b/78251210
Bug: 835686
Bug: 834213
Change-Id: Ib2ac5238e86fc965df9bfd4af098d60d3cbfb89b
Reviewed-on: https://chromium-review.googlesource.com/1027575
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553903}
[modify] https://crrev.com/73e1cc622910eb9b719e96027d20bd20a8028798/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/73e1cc622910eb9b719e96027d20bd20a8028798/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/73e1cc622910eb9b719e96027d20bd20a8028798/testing/buildbot/waterfalls.pyl

https://luci-milo.appspot.com/buildbot/chromium.fyi/WinMSVC64%20Goma%20Canary/4991

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FWinMSVC64_Goma_Canary%2F4991%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Flogs%2Fraw_io.output_failure_summary_%2F0

AILED: obj/third_party/angle/libANGLE/TransformFeedbackNULL.obj
ninja -t msvc -e environment.x64 -- E:\b\c\goma\client/gomacc.exe "E:\b\c\win_toolchain\vs_files\5454e45bf3764c03d3fc1024b3bf5bc41e3ab62c\VC\Tools\MSVC\14.14.26428\bin\HostX64\x64/cl.exe" /nologo /showIncludes  -D"ANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES={ \"d3dcompiler_47.dll\", \"d3dcompiler_46.dll\", \"d3dcompiler_43.dll\" }" -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGL_GLEXT_PROTOTYPES -DEGL_EGLEXT_PROTOTYPES -DANGLE_IS_64_BIT_CPU -DANGLE_ENABLE_D3D9 -DANGLE_ENABLE_D3D11 -DANGLE_ENABLE_OPENGL -DANGLE_ENABLE_OPENGL_NULL -DANGLE_ENABLE_VULKAN -DANGLE_ENABLE_NULL -DLIBANGLE_IMPLEMENTATION -DVK_USE_PLATFORM_WIN32_KHR -DVK_USE_PLATFORM_WIN32_KHX -D"ANGLE_VK_DATA_DIR=\"angledata\"" -D"ANGLE_VK_ICD_JSON=\"angledata/VkICD_mock_icd.json\"" -D"API_NAME=\"Vulkan\"" -I../../third_party/angle/src/third_party/khronos -Igen/angle -I../../third_party/angle/include -I../../third_party/angle/src -I../../third_party/angle/src/common/third_party/base -I../../third_party/angle/third_party/vulkan-validation-layers/src/include -I../../third_party/angle/include -I../../third_party/angle/src -I../../third_party/angle/include -I../../third_party/angle/src -I../../third_party/angle/include -I../../third_party/angle/third_party/glslang/src -I../../third_party/angle/third_party/glslang/src/glslang/Public -Igen/third_party/angle/third_party/vulkan-validation-layers/angle/vulkan -I../../third_party/angle/third_party/vulkan-validation-layers/src/include -I../../third_party/angle/third_party/vulkan-validation-layers/src/loader /utf-8 /wd4117 /D__DATE__= /D__TIME__= /D__TIMESTAMP__= /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- /W4 /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /MT /we4244 /we4456 /we4458 /we4800 /we4838 /wd4530 /wd4201 /TP /wd4577 /GR- /c ../../third_party/angle/src/libANGLE/renderer/null/TransformFeedbackNULL.cpp /Foobj/third_party/angle/libANGLE/TransformFeedbackNULL.obj /Fd"obj/third_party/angle/libANGLE_cc.pdb"
GOMA:cl.exe ../../third_party/angle/src/libANGLE/renderer/null/TransformFeedbackNULL.cpp:*ERROR*: compiler_proxy:5388ms: No matching compiler(cl.exe 19.14.26428.1 (335529afd5dcbf64fae6d9ca4d2091d11a868559b9a2e2d8e17fc1a0b320f0ff)) found in server

http://b/79887164 ?

brucedawson pushed a new msvc toolchain today, maybe its compiler isn't on goma yet.

ah. filed http://b/79887982

Issue 843892 has been merged into this issue.

I've just deployed a new msvc compiler on goma. I hope it will work. Please check.

I think the goma issue is resolved. I re-ran our roll that still includes the toolchain upgrade:
https://chromium-review.googlesource.com/c/v8/v8/+/1062816/2

At least there are no goma errors. There are some new compiler warnings, which I filed separately as  https://crbug.com/v8/7771 

After disabling the warning, our roll is green again. From V8's p-o-v the toolchain update can reland in Chrome.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82a5f004e0e52897a6e8bac10490a14fc2845625

commit 82a5f004e0e52897a6e8bac10490a14fc2845625
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Fri May 18 20:05:49 2018

Reland "Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK"

This is a reland of 5a7f3c442684be5eeb244b904bbfc8e6edaf6fda

goma now supports this compiler and the new warnings were dealt with.

Original change's description:
> Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK
>
> This change switches the VS 2017 package to use VS 2017 Update 7.1 while
> using the 10.0.17134.12 SDK. The new SDK is needed to support new HDR
> features, and to stop forcing external developers to install an old
> ([Spring] Creators Update) SDK. This change will also bring in a new
> linker and other build tools, but the version of clang-cl will be
> unchanged.
>
> Packaging was done on a Windows Server 2016 VM, cleanly created for this
> purpose.
>
> Compiler was packaged up by downloading VS 2017 Update 7.1, from
> https://www.visualstudio.com/vs/, and then passing these parameters to
> the installer:
>
>     --add Microsoft.VisualStudio.Workload.NativeDesktop
>     --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
>     --passive
>
> Then Add or Remove Programs was used to modify the 10.0.17134.0 SDK to add
> the Debuggers package.
>
> Then the packaging script was run like this:
>
>   python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17134.0
>
> Bug:  773476 
> Change-Id: Ic819f3ae79d7e869227bf33fbb8d202e2f57039b
> Reviewed-on: https://chromium-review.googlesource.com/1054027
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559033}

Bug:  773476 ,834213
Change-Id: I903158f9dfa604f250010a7047496509f51782e7
Reviewed-on: https://chromium-review.googlesource.com/1066130
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560002}
[modify] https://crrev.com/82a5f004e0e52897a6e8bac10490a14fc2845625/base/win/windows_version.cc
[modify] https://crrev.com/82a5f004e0e52897a6e8bac10490a14fc2845625/build/toolchain/win/setup_toolchain.py
[modify] https://crrev.com/82a5f004e0e52897a6e8bac10490a14fc2845625/build/vs_toolchain.py
[modify] https://crrev.com/82a5f004e0e52897a6e8bac10490a14fc2845625/docs/windows_build_instructions.md
[modify] https://crrev.com/82a5f004e0e52897a6e8bac10490a14fc2845625/tools/gn/visual_studio_writer.cc
[modify] https://crrev.com/82a5f004e0e52897a6e8bac10490a14fc2845625/tools/gn/visual_studio_writer_unittest.cc

As noted, this is Blocking issue 832547, which is a fix for Windows HDR usage, which became particularly relevant after the Win10 1803 Spring feature update 4/30.

I'm seeing some pushback in the Chrome Help Forum here
  https://productforums.google.com/forum/#!topic/chrome/lAiOdlHS-XM

Any ETA on this making it's way forward?  Is there a way to track the master CR commit positions to deployment?

 Issue 823547  is fixed (which this blocks) and https://luci-milo.appspot.com/buildbot/chromium.fyi/WinMSVC64%20Goma%20Canary/ is green so this bug here is currently fixed too.

Issue 832547 (2 and 3 swapped) is open bug blocked on issue 659750 -- maybe you meant to comment there?

Oops: typo, c#18 Blocked issue should be  issue 823457 .

Thanks for the GOMA Canary build status.  When/Is this CR (834213) included in Canary?  How can I track the incorporation?

All the CLs on this bug have been in Canary for weeks. It's all build tweaks though, nothing visible in Chrome -- and Canary isn't built by MSVC. What exactly are you waiting for? This here is probably not the bug you want.

I want to know when  issue 823547  will be reach production: canary or merged to beta or stable. See c#18. 

See comment 19:  issue 823547  is blocked on issue 834213 and has nothing to do with the bug here.

If you're curious about the state of  issue 823547 , I'd recommend asking there.  Issue 823547  is marked fixed though, with a CL on May 8, so that fix has been on canary a while. (But as I said, ask there.)

thakis@ - So 823547 being blocked on this (834213) doesn't prevent 823547 from rolling into Canary?  If so, what's the sense of the Blocking tag?

Oh, I see. I think that blocker is wrong. I commented on the other bug.