New issue
Advanced search Search tips

Issue 834205 link

Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove non-MD bookmark manager

Project Member Reported by calamity@chromium.org, Apr 18 2018

Issue description

This bug tracks work to remove the non-MD bookmark manager.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d8828e68c6faf98403190a0c0096c70ad1a3772

commit 3d8828e68c6faf98403190a0c0096c70ad1a3772
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Apr 30 05:25:11 2018

Remove the old Bookmark Manager.

Bug:  834205 

TBR=sky@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8b23ae84f287f688b1f0cebd2f278f3580588c8a
Reviewed-on: https://chromium-review.googlesource.com/1016223
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554697}
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/WATCHLISTS
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/about_flags.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/bookmarks/bookmark_model_factory.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/browser_resources.grd
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/extensions/component_loader.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/extensions/extension_url_rewrite_browsertest.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/flag_descriptions.cc
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/css/bmm.css
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search.png
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search_rtl.png
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/images/2x/bookmarks_section_32.png
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/images/bookmark_manager_search.png
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/images/bookmark_manager_search_rtl.png
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/images/bookmarks_section_32.png
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/js/bmm.js
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/js/bmm_test.html
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/js/compiled_resources2.gyp
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/js/dnd.js
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/js/main.js
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/main.html
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/resources/bookmark_manager/manifest.json
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/resources/component_extension_resources.grd
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/ui/chrome_pages.cc
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/ui/webui/bookmarks_ui.cc
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/ui/webui/bookmarks_ui.h
[delete] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/ui/webui/bookmarks_ui_browsertest.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/ui/webui/log_web_ui_url.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/ui/webui/log_web_ui_url_unittest.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/common/chrome_features.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/common/chrome_features.h
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/common/extensions/api/_manifest_features.json
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/common/extensions/extension_constants.cc
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/common/extensions/extension_constants.h
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/test/BUILD.gn
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js
[modify] https://crrev.com/3d8828e68c6faf98403190a0c0096c70ad1a3772/third_party/closure_compiler/compiled_resources2.gyp

See https://bugs.chromium.org/p/chromium/issues/detail?id=869412

Google Chrome Stable 68.0.3440.75 removed the flag to disable Material Design in the Bookmark Manager - thus forcing Material Design of the Bookmark Manager.

The initial reason I preferred the prior Bookmark Manager is because I was able to copy bookmarks, and paste them in a different folder - which I am unable to do in the Material Design interface.

Now that the flag to disable Material Design in the Bookmark Manager has been removed, I notice that the Bookmark Manager only displays the first 60 bookmarks in a folder that contains roughly 100 bookmarks. Another folder that contains over 400 bookmarks also displays only the first 60.
I maintain TONS of bookmarks.

Some of the items are logically relevant to more than a single topic [folder].

The ability to store a bookmark in more than a single folder was very important to me when assembling citations [URLs] on a given topic.
I will speculate that the reason you haven't received a great deal of comment on this would be that many users disabled Material Design Bookmarks.

Further, I would guess that you might reasonably expect more comment now that the flag to disable Material Design Bookmarks has been abandoned.

Comment 6 Deleted

Attached screenshot shows whitespace in a folder that should display 1304 bookmarks.
Screenshot show number of bookmarks.png
200 KB View Download
Please bring back the good old non-material design bookmarks, or at least the flag for those who are accustomed to it and wish to re-enable it.
Thanks,
BillA

If you are able to click links here on this page, you are able to click links in the old bookmark manager.  

The material design bookmarks are a huge waste of space (so you could click on them easíer? Why?!) and it es slower  in every way then the way better old bookmarks. 

Need to refresh the bookmark manager to display all bookmarks, not only the first XY.

Just bring back the flag for the old manager, i dont want the worse new one. thanks.
The [old] bookmark manager worked just fine [without hardware acceleration]. 

Only when the code to support the prior bookmark manager was removed in M68 did I consider testing the Material Design Bookmark Manager with hardware acceleration enabled. 

I had to disable hardware acceleration mid Sept 2017 when Chrome M61 started crashing [sometimes freezing the system completely].

I have the most up to date drivers and my system functions perfectly. Unfortunately, Chrome still crashes with hardware acceleration enabled - the Chromium team never properly re-mediated whatever causes those crashes. 

I have been perfectly happy to run Chrome without hardware acceleration enabled, as I have observed no appreciable improvement in performance. 

Since your team is apparently deeply committed to migrating to a common code base across all your products on all platforms, the obvious question going forward is this: 

Shouldn't the Material Design Bookmark Manager properly display all the bookmarks in a folder - without hardware acceleration enabled? Will your team work to achieve that?

If not, then my choices become:

Replace my laptop? Upgrade the video card in my desktop? Or, more simply and less expensively, just get used to Firefox again?
It's pretty sad that now we have to BEG to get the NORMAL bookmark manager back, when it was a perfectly working piece of code.  Moreover why take away the OPTION for those who wish to re-enable it by this flag? 
chrome://flags/#enable-md-bookmarks
Please bring the flag back to make a lot of people happy. :)


Status: Fixed (was: Started)
Hey,

In the course of software engineering, it's not enough to just make software, we are obligated to maintain it. The old bookmark manager uses a lot of tools that we're actively trying to remove, and perpetuates outdated coding paradigms.

The new bookmark manager, while not perfect, has a path forward. The technologies it uses are in active development and are well-understood by the engineers in Chrome. This means when problems arise, we are in a good position to attempt to fix them.

The removal of the old bookmark manager is a necessary step forward in this engineering process. Leaving old code around leaves in complexity that can be perpetuated as people use it as a template for new projects, and it prevents us from removing outdated tooling.

The redesign is unrelated to the engineering process, so feel free to file bugs on what you feel are deficiencies in the design. If popular, these may be picked up by engineers with spare time, if they can get designer support.

The old bookmark manager is not coming back. However, it's probably possible to grab all the code deleted in crrev.com/3d8828e68c and with some work, package it as an extension and release on the Chrome Web Store (Hooray for open source!). This would override the current bookmark manager. Maintenance would then fall to the Extension author, and Chrome's engineering can move forward unburdened.

Thanks for understanding,
-Chris

Comment 13 Deleted

Some thoughts I'd like to share:

1. please use the same folder icons as in the bookmark bar
2. please make organizing functions more obvious
3. i liked the old design better, because it was fast, clear, easy to use, yet familiar because somewhat similar to windows explorer. but now it just feels like a forcibly modernized version, which lost the ease and the comfort of the old one.
Commenting on a closed issue, makes it less likely to get  much traction. I suggest filing a new bug with the proposed improvements for the new Bookmark UI so that they can be triaged and prioritized.

Sign in to add a comment