Issue metadata
Sign in to add a comment
|
Popup Menu: change the highlighted state of the items |
||||||||||||||||||||||
Issue descriptionWhen a popup menu is presented, the highlighted state of the items (state when the user hold a tap on an item) shouldn't be the default state (dark grey). Can you spec the new state and assign back to me?
,
Apr 25 2018
A full width/height view with a background color of black @ 0.05 alpha. +Martijn/Rohit/Sergio/Stepan: this same highlight state should be used for all the cells in collections and the omnibox completions view.
,
Apr 25 2018
,
Apr 25 2018
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd752afab16bf79f9db388d31858ee0aea7cf56d commit dd752afab16bf79f9db388d31858ee0aea7cf56d Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 02 11:00:43 2018 Adjust Popup Menu's item selected background color This CL changes the background color of the selected items of the Popup Menu, displayed when the cell is highlighted. Bug: 834201 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I704837ded09d5bbd35c4beabb188216dc27383ed Reviewed-on: https://chromium-review.googlesource.com/1039365 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555346} [modify] https://crrev.com/dd752afab16bf79f9db388d31858ee0aea7cf56d/ios/chrome/browser/ui/popup_menu/cells/BUILD.gn [modify] https://crrev.com/dd752afab16bf79f9db388d31858ee0aea7cf56d/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.mm [modify] https://crrev.com/dd752afab16bf79f9db388d31858ee0aea7cf56d/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm [modify] https://crrev.com/dd752afab16bf79f9db388d31858ee0aea7cf56d/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/dd752afab16bf79f9db388d31858ee0aea7cf56d/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm
,
May 2 2018
,
May 9 2018
The NextAction date has arrived: 2018-05-09 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mard...@chromium.org
, Apr 18 2018