"ServiceWorkerLazyBackgroundTestWithJSBindings/ServiceWorkerLazyBackgroundTest.EventsAfterRestart/0" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybQsSBUZsYWtlImJTZXJ2aWNlV29ya2VyTGF6eUJhY2tncm91bmRUZXN0V2l0aEpTQmluZGluZ3MvU2VydmljZVdvcmtlckxhenlCYWNrZ3JvdW5kVGVzdC5FdmVudHNBZnRlclJlc3RhcnQvMAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Findit identified the culprit r551343 with confidence 70.0% in the config "tryserver.chromium.chromiumos / linux-chromeos-rel" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy-QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLCAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzcwMTQvdml6X2Jyb3dzZXJfdGVzdHMvVTJWeWRtbGpaVmR2Y210bGNreGhlbmxDWVdOclozSnZkVzVrVkdWemRGZHBkR2hLVTBKcGJtUnBibWR6TDFObGNuWnBZMlZYYjNKclpYSk1ZWHA1UW1GamEyZHliM1Z1WkZSbGMzUXVSWFpsYm5SelFXWjBaWEpTWlhOMFlYSjBMekE9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Flake Analyzer is in beta. Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
The native bindings version has been flaky too. Disabling here: https://chromium-review.googlesource.com/c/chromium/src/+/1016606
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e674ba807e4349f7369195c37d125cebbf5677c6 commit e674ba807e4349f7369195c37d125cebbf5677c6 Author: Rune Lillesveen <futhark@chromium.org> Date: Wed Apr 18 16:20:20 2018 Disabling flaky ServiceWorkerLazyBackgroundTest. Disabling flaky ServiceWorkerLazyBackgroundTest.EventsAfterRestart. TBR=lazyboy@chromium.org Bug: 834200 Change-Id: Ib0ec023bbd9edd2220e10cde3d9ed1b89a6191cd Reviewed-on: https://chromium-review.googlesource.com/1016606 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#551708} [modify] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/chrome/browser/extensions/service_worker_apitest.cc
Sorry the culprit r551343 belongs to me, and a fix CL is in preparation.
Issue 834405 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf commit 8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf Author: Han Leon <leon.han@intel.com> Date: Wed May 02 04:17:00 2018 [ServiceWorker] Associate interfaces living on the SW thread together This CL switches those interfaces (ServiceWorkerHost, ServiceWorkerRegistrationObject[Host] etc.) associated with EmbeddedWorkerInstanceClient interface before to be associated with ServiceWorkerEventDispatcher interface living on its particular service worker thread in the renderer process. This will not only ensure them keeping the FIFO ordering with ServiceWorkerEventDispatcher, but also make all their Mojo message dispatches skip the main thread completely to avoid possible congestion. The idea is to let browser-side pass ServiceWorkerHost endpoint and ServiceWorkerRegistrationObjectInfo via a newly defined Mojo call ServiceWorkerEventDispatcher::InitializeGlobalScope() to the service worker thread, which holds on evaluating its service worker script until received that call. BUG= 745327 , 834200 , 834183 TBR=lazyboy@chromium.org for enabling a test in chrome/browser/extensions/service_worker_apitest.cc Change-Id: Icc9d03d2cc0f099735cfcf34660b835ccf908402 Reviewed-on: https://chromium-review.googlesource.com/981898 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#555307} [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/chrome/browser/extensions/service_worker_apitest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/payments/payment_app_content_unittest_base.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_instance_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_handle_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_test_utils.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_test_utils.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_version.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_version_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/common/service_worker/embedded_worker.mojom [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/common/service_worker/service_worker_provider.mojom [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/embedded_worker_instance_client_impl.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_network_provider.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_provider_context.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_provider_context.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_provider_context_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/public/web/modules/serviceworker/web_service_worker_context_proxy.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/web_embedded_worker_impl_test.cc
Detected 3 new flakes for test/step "ServiceWorkerLazyBackgroundTestWithNativeBindings/ServiceWorkerLazyBackgroundTest.EventsAfterRestart/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNycQsSBUZsYWtlImZTZXJ2aWNlV29ya2VyTGF6eUJhY2tncm91bmRUZXN0V2l0aE5hdGl2ZUJpbmRpbmdzL1NlcnZpY2VXb3JrZXJMYXp5QmFja2dyb3VuZFRlc3QuRXZlbnRzQWZ0ZXJSZXN0YXJ0LzAM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee commit d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee Author: Han Leon <leon.han@intel.com> Date: Thu May 03 00:33:14 2018 Revert "[ServiceWorker] Associate interfaces living on the SW thread together" This reverts commit 8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf. Reason for revert: crbug.com/838397 and 834200, reland later when we make all things clear Original change's description: > [ServiceWorker] Associate interfaces living on the SW thread together > > This CL switches those interfaces (ServiceWorkerHost, > ServiceWorkerRegistrationObject[Host] etc.) associated with > EmbeddedWorkerInstanceClient interface before to be associated with > ServiceWorkerEventDispatcher interface living on its particular service > worker thread in the renderer process. > This will not only ensure them keeping the FIFO ordering with > ServiceWorkerEventDispatcher, but also make all their Mojo message > dispatches skip the main thread completely to avoid possible congestion. > > The idea is to let browser-side pass ServiceWorkerHost endpoint and > ServiceWorkerRegistrationObjectInfo via a newly defined Mojo call > ServiceWorkerEventDispatcher::InitializeGlobalScope() to the service > worker thread, which holds on evaluating its service worker script until > received that call. > > BUG= 745327 , 834200 , 834183 > TBR=lazyboy@chromium.org for enabling a test in > chrome/browser/extensions/service_worker_apitest.cc > > Change-Id: Icc9d03d2cc0f099735cfcf34660b835ccf908402 > Reviewed-on: https://chromium-review.googlesource.com/981898 > Commit-Queue: Han Leon <leon.han@intel.com> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Han Leon <leon.han@intel.com> > Cr-Commit-Position: refs/heads/master@{#555307} TBR=falken@chromium.org,kinuko@chromium.org,lazyboy@chromium.org,shimazu@chromium.org,leon.han@intel.com Change-Id: I935bfdbce9b407c937c2e3a5da424773ec397a1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 745327 , 834200 , 834183 Reviewed-on: https://chromium-review.googlesource.com/1041050 Reviewed-by: Han Leon <leon.han@intel.com> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#555630} [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/chrome/browser/extensions/service_worker_apitest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/payments/payment_app_content_unittest_base.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_instance_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_handle_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_test_utils.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_test_utils.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_version.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_version_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/common/service_worker/embedded_worker.mojom [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/common/service_worker/service_worker_provider.mojom [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/embedded_worker_instance_client_impl.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_network_provider.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_provider_context.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_provider_context.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_provider_context_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/public/web/modules/serviceworker/web_service_worker_context_proxy.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/web_embedded_worker_impl_test.cc
Issue 838913 has been merged into this issue.
Findit identified the culprit r555307 with confidence 70.0% in the config "tryserver.chromium.linux / linux_chromium_asan_rel_ng" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy_QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLGAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIExTYW4gVGVzdHMgKDEpLzQ1MjQ4L2Jyb3dzZXJfdGVzdHMvVTJWeWRtbGpaVmR2Y210bGNreGhlbmxDWVdOclozSnZkVzVrVkdWemRGZHBkR2hPWVhScGRtVkNhVzVrYVc1bmN5OVRaWEoyYVdObFYyOXlhMlZ5VEdGNmVVSmhZMnRuY205MWJtUlVaWE4wTGtWMlpXNTBjMEZtZEdWeVVtVnpkR0Z5ZEM4dwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
Leon: did your patches fix this? Related bugs: bug 845979 bug 774606 bug 834200 bug 844821
Hi, Matt, I have no patch to fix this now, and unfortunately I'm still not clear about the root cause. Are we sure r551343 is the exact culprit causing this issue? If so I'd like to do some investigations based on some hints around r551343.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99aa96d7cbc261e079d33d4f481fc839c0b813af commit 99aa96d7cbc261e079d33d4f481fc839c0b813af Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Thu Sep 13 23:22:08 2018 [Extensions] Enable ServiceWorkerLazyBackgroundTest.EventsAfterRestart. The root cause is fixed by https://crrev.com/b8e24bdbf6bbe43bc32fd684f2a0aad914e804d2 and the test doesn't flake locally or on trybots anymore. Bug: 834200 Change-Id: I0bca3a12374cb70554c73063d7913dfbeec78e07 Reviewed-on: https://chromium-review.googlesource.com/1225700 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591203} [modify] https://crrev.com/99aa96d7cbc261e079d33d4f481fc839c0b813af/chrome/browser/extensions/service_worker_apitest.cc
The underlying issue (at least as of recently) was crbug.com/879015 , that fixed the flakiness and I've enabled the test.
Comment 1 by Findit
, Apr 18 2018