New issue
Advanced search Search tips

Issue 834188 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 834189
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

KeyboardEvent.code value for illegal key event should be 'Unidentified' rather than null or empty string

Reported by dtoybo...@gmail.com, Apr 18 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Steps to reproduce the problem:
1. Go to https://w3c.github.io/uievents/tools/key-event-viewer.html
2. Press key which is NOT supported by the OS.

What is the expected behavior?
The code value should be "Unidentified".

What went wrong?
Perhaps, it becomes null or empty string.

Did this work before? No 

Does this work in other browsers? No
 I'm still not sure how to reproduce this actually though, but as far as I read the source code of Chromium, there is this bug.

Chrome version: 65.0.3325.181  Channel: n/a
OS Version: 10.0
Flash Version: 

Older draft of UI Events code value, when code value cannot be resolved, it should've been empty string.  However, newer drafts declare "Unidentified" should be set.
https://w3c.github.io/uievents-code/#code-Unidentified

I'm trying to update some KeyboardEvent.code values of Firefox from legacy values to the latest values. However, I'm still afraid to use "Unidentified" since Chromium still uses null or empty string.

A lot of "Code" is mapped to NULL here:
https://cs.chromium.org/chromium/src/ui/events/keycodes/dom/keycode_converter_data.inc

And NULL mapped to empty string here:
https://cs.chromium.org/chromium/src/ui/events/keycodes/dom/keycode_converter.cc?l=120&rcl=81f17cb2241ab29dc07cc55f83e715ce2606fa0a
 
Labels: Needs-Triage-M65
Labels: Triaged-ET
Mergedinto: 834189
Status: Duplicate (was: Unconfirmed)
This issue is same as issue 834189. Hence merging into it.

Thanks!

Comment 3 Deleted

Comment 4 by mnak...@mozilla.com, Apr 19 2018

Oops, when I reported this issue, I saw Internal Server Error and reloaded. So, perhaps, the reload caused this duplicated report.

Sign in to add a comment