New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 834185 link

Starred by 5 users
Status: Fixed
Owner:
lukasza@chromium.org
Closed: Aug 31
Cc:
█ mkwst@chromium.org
yhirano@chromium.org
jam@chromium.org
█ roc...@chromium.org
blink-network-dev@chromium.org
dpranke@chromium.org
robertma@chromium.org
dcheng@chromium.org
nedngu...@google.com
█ tibell@chromium.org
toyoshim@chromium.org
estaab@chromium.org
u...@chromium.org
sa...@chromium.org
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

many http/tests/fetch tests are flaky on oopif

Project Member Reported by tkent@chromium.org, Apr 18 2018 
The following layout test is flaky on all platforms.

http/tests/fetch/serviceworker/thorough/redirect-credentials-base-https-other-https.html
http/tests/fetch/serviceworker-proxied/thorough/redirect-credentials-base-https-other-https.html
http/tests/fetch/window/thorough/redirect-credentials-base-https-other-https.html
http/tests/fetch/workers/thorough/redirect-credentials-base-https-other-https.html

Probable cause:
Unknown

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_webkit_layout_tests&tests=redirect-credentials-base-https-other-https.html%0A%20redirect-credentials-base-https-other-https.html%0A
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f20739a3b0d648cab0bc1fcdcef011fd164e06b2

commit f20739a3b0d648cab0bc1fcdcef011fd164e06b2
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Apr 18 07:39:16 2018

Mark some tests as flaky.

external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html
http/tests/fetch/serviceworker-proxied/thorough/redirect-credentials-base-https-other-https.html
http/tests/fetch/serviceworker/thorough/redirect-credentials-base-https-other-https.html
http/tests/fetch/window/thorough/redirect-credentials-base-https-other-https.html
http/tests/fetch/workers/thorough/redirect-credentials-base-https-other-https.html
virtual/outofblink-cors/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html

TBR=dcheng@chromium.org
NOTRY=true

Bug:  834183 ,  834185 
Change-Id: I6eb3d60775dc18aea2339f1be17358d9a00e5e97
Reviewed-on: https://chromium-review.googlesource.com/1016340
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551606}
[modify] https://crrev.com/f20739a3b0d648cab0bc1fcdcef011fd164e06b2/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/f20739a3b0d648cab0bc1fcdcef011fd164e06b2/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by tkent@chromium.org, Apr 24 2018 

 Issue 836090  has been merged into this issue.

Comment 3 by yhirano@chromium.org, May 1 2018

Status: Available (was: Untriaged)

Comment 4 by falken@chromium.org, Jun 22 2018

Summary: many http/tests/fetch tests are flaky on oopif (was: redirect-credentials-base-https-other-https.html is flaky only with oopif)
There are many tests with this bug number in FlagExpectations.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72ef4e47846d30d3fa26599c7864efd38def1704

commit 72ef4e47846d30d3fa26599c7864efd38def1704
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Jun 22 01:42:43 2018

Gardening: Move OOPIF only OOR-CORS failures to FlagExpectations/site-per-process

These are only flaky on OOPIF (site-per-process), and there are existing
flaky expectations for the non-OOR-CORS tests.

I'm not sure why the OOR-CORS tests regressed recently, but since it's
an experimental feature and the non-OOR-CORS tests are also flaky I'll
leave it for OOR-CORS or OOPIF team to look.

Bug:  854630 ,  834185 
Change-Id: I93db44e01e96adb0d0f715061b66f0f7ec3f2862
TBR: dgrogan
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1111479
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569500}
[modify] https://crrev.com/72ef4e47846d30d3fa26599c7864efd38def1704/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/72ef4e47846d30d3fa26599c7864efd38def1704/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by ynovikov@chromium.org, Jun 27 2018 

I also saw
virtual/outofblink-cors/http/tests/fetch/workers/thorough/redirect-credentials-base-https-other-https.html
flake in https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/128651.
Could you please add a flake expectation for it as well?
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/167df1612d0807a69d0d55fb20524b2596744b5a

commit 167df1612d0807a69d0d55fb20524b2596744b5a
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Jul 06 17:35:09 2018

Mark redirect-credentials-base-https-other-https.html as timeout failure

This test is flaky with site-per-process:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_webkit_layout_tests&tests=virtual%2Foutofblink-cors%2Fhttp%2Ftests%2Ffetch%2Fserviceworker-proxied%2Fthorough%2Fredirect-credentials-base-https-other-https.html%20

Most recent failure:
https://test-results.appspot.com/data/layout_results/linux-xenial-rel/1461/site_per_process_webkit_layout_tests/layout-test-results/results.html

This patch marks the test as timing out and failing which matches the current
behavior.

TBR=ynovikov@chromium.org

Bug:  834185 
Change-Id: I7d79585ec8417625c82cb7cdc077fa56505d0c76
Reviewed-on: https://chromium-review.googlesource.com/1128041
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573005}
[modify] https://crrev.com/167df1612d0807a69d0d55fb20524b2596744b5a/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39661c75086cce244dbcb87c8b89e8a305adecfe

commit 39661c75086cce244dbcb87c8b89e8a305adecfe
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Jul 06 18:10:13 2018

Mark scheme-data-base-https-other-https.html as timing out

This test is flaky with site-per-process:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_webkit_layout_tests&tests=etch%2Fserviceworker-proxied%2Fthorough%2Fscheme-data-base-https-other-https.html

Most recent failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/134955

This patch marks the test as timing out and passing which matches the current
behavior.

TBR=ynovikov@chromium.org

No-Try: true
Bug:  834185 
Change-Id: I38c12e53b7fe27add8c6d50160426a3da666d1f6
Reviewed-on: https://chromium-review.googlesource.com/1128163
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573013}
[modify] https://crrev.com/39661c75086cce244dbcb87c8b89e8a305adecfe/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7078711ffa7d0890ddbcb7d34ae4fcca1e3786bb

commit 7078711ffa7d0890ddbcb7d34ae4fcca1e3786bb
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Jul 06 20:52:13 2018

Mark redirect-base-https-other-https.html as timing out

This test is flaky with site-per-process:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_webkit_layout_tests&tests=redirect-base-https-other-https.html

The test lines have also been sorted to make adding these easier.

TBR=ynovikov@chromium.org

No-Try: true
Bug:  834185 ,  854630 
Change-Id: I370a9fd75326ebecc90253b0fc208bc2c915b83f
Reviewed-on: https://chromium-review.googlesource.com/1128258
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573065}
[modify] https://crrev.com/7078711ffa7d0890ddbcb7d34ae4fcca1e3786bb/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3

commit 627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jul 20 01:26:52 2018

[OOR-CORS] Reorganize layout test expectations for site-per-process

virtual/outofblink-cors and virtual/outofblink-cors-ns should inherit
existing test expectations. There is a dedicated bug for
virtual/outofblink-cors,  https://crbug.com/854630 , but that doesn't
make sense as none of them are OOR-CORS specific, so I changed the bug
number.

TBR=dcheng@chromium.org

No-Try: true
Bug:  834185 ,  854630 , 859988, 862184
Change-Id: I4886c8ed063e95306d79234649dbc54a8bb53100
Reviewed-on: https://chromium-review.googlesource.com/1144582
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576749}
[modify] https://crrev.com/627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3/third_party/WebKit/LayoutTests/TestExpectations

Comment 11 by yhirano@chromium.org, Jul 20

Cc: blink-network-dev@chromium.org yhirano@chromium.org toyoshim@chromium.org
 Issue 854630  has been merged into this issue.

Comment 12 by lukasza@chromium.org, Aug 18

Cc: robertma@chromium.org estaab@chromium.org dpranke@chromium.org nedngu...@google.com
 Issue 875430  has been merged into this issue.

Comment 13 by lukasza@chromium.org, Aug 20

Owner: lukasza@chromium.org
Status: Assigned (was: Available)
It seems that ReplicateTestConfiguration IPC never reaches the rederer running the tests - I am still trying to understand what may cause this.

...
[207576:207576:0820/131811.467257:ERROR:layout_test_render_frame_observer.cc(86)] LayoutTestRenderFrameObserver::ReplicateTestConfiguration
...
[206872:206872:0820/131811.580632:ERROR:render_process_host_impl.cc(3172)] RenderProcessHostImpl::OnChannelConnected; GetID() = 52; GetProcess().Pid() = 207589
...
[206872:206872:0820/131811.601195:ERROR:blink_test_controller.cc(841)] BlinkTestController::HandleNewRenderFrameHost; main_window = 1; frame->GetParent() = (nil); frame->GetProcess()->GetID() = 52; did_send_initial_test_configuration_ = 1; main_window_render_process_hosts_.size() = 1; base::ContainsKey(main_window_render_process_hosts_, process_host) = 0
[206872:206872:0820/131811.601265:ERROR:blink_test_controller.cc(870)] BlinkTestController::HandleNewRenderFrameHost - sending ReplicateTestConfiguration; frame->GetProcess()->GetID() = 52
...
... no LayoutTestRenderFrameObserver::ReplicateTestConfiguration reported from process 52 / 207589
...
[207589:207589:0820/131811.853611:ERROR:blink_test_runner.cc(459)] BlinkTestRunner::TestFinished: 1; interfaces->TestIsRunning() = 0; stack = #0 0x7fecd2f0ebcc base::debug::StackTrace::StackTrace()
#1 0x000000432062 content::BlinkTestRunner::TestFinished()
#2 0x7fecc9bd77d3 test_runner::TestRunner::NotifyDone()
#3 0x7fecc9bd2123 test_runner::TestRunnerBindings::NotifyDone()
...
... test times out because !TestIsRunning() caused an early exit above ...
...

Comment 14 by lukasza@chromium.org, Aug 20 

I've found the problem - BlinkTestController::layout_test_control_map_ uses |RenderProcessHost*| as a key and the address gets reused:

...
[213970:213970:0820/133938.422694:ERROR:blink_test_controller.cc(1277)] BlinkTestController::GetLayoutTestControlPtr; no ControlPtr yet; frame = 0xe32cdafe900; frame->GetProcess()->GetID() = 6
[213970:213970:0820/133938.422768:ERROR:blink_test_controller.cc(1289)] BlinkTestController::GetLayoutTestControlPtr; returning...; layout_test_control_map_[frame].get() = 0xe32cdc4c470; frame = 0xe32cdafe900; frame->GetProcess()->GetID() = 6
...
[213970:213970:0820/133938.566095:ERROR:blink_test_controller.cc(1289)] BlinkTestController::GetLayoutTestControlPtr; returning...; layout_test_control_map_[frame].get() = 0xe32cdc4c470; frame = 0xe32cdafe900; frame->GetProcess()->GetID() = 7
...

Same |frame| address, different |frame->GetProcess()->GetID()|.  Ooops.  I guess I can only blame myself for not catching this during code review at https://codereview.chromium.org/2594913002...

Comment 15 by lukasza@chromium.org, Aug 20

Status: Started (was: Assigned)
WIP CL @ https://chromium-review.googlesource.com/c/chromium/src/+/1182316

Comment 16 by lukasza@chromium.org, Aug 20

Blocking: 874695

Comment 17 by lukasza@chromium.org, Aug 21

Blocking: -874695
Cc: sa...@chromium.org jam@chromium.org tibell@chromium.org mkwst@chromium.org
+author and other reviewers of https://codereview.chromium.org/2594913002 to point out that:

- Using |RenderFrameHost*| as a map key is risky.  Using a pair of (process id, frame routing id) is more obviously correct.

- interface_using_frame_pipe_ptr.set_connection_error_handler(EraseMapElement) doesn't help, because there is a delay between 1) destroying RenderFrameHost and 2) actually running EraseMapElement.  This seems similar to the problem in https://docs.google.com/document/d/1pu-VjoQiPK4w7N04-bMBBKODnqZGb4QHZNuoYgzMU9A

Comment 18 by lukasza@chromium.org, Aug 21

Cc: roc...@chromium.org u...@chromium.org dcheng@chromium.org
+dcheng@, rockot@, ulan@ as this seems a bit similar to the mojo ordering/delay problem described in https://docs.google.com/document/d/1pu-VjoQiPK4w7N04-bMBBKODnqZGb4QHZNuoYgzMU9A
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7663e81247c1494770dd8de1603b648a4aaeeeb

commit b7663e81247c1494770dd8de1603b648a4aaeeeb
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Tue Aug 21 18:23:30 2018

|RenderFrameHost*| shouldn't be used as a key by BlinkTestController.

Addresses can be reused and therefore pointers shouldn't be used as
container keys (unless the code maintaining the container can guarantee
that the old entry will be destroyed before the pointer gets freed).
In particular, using |RenderFrameHost*| as a key of BlinkTestController's
layout_test_control_map_ was incorrect and led to timeouts described
in more details in  https://crbug.com/834185#c13  - #c14.

This CL replaces
    std::map<RenderFrameHost*, ...>
with
    std::map<std::pair<int, int>, ...>
and uses (process id, frame routing id) as a key.

After this CL around ~200 flaky timeouts from
FlagExpectations/site-per-process seem to avoided.  Before this CL, I
could reliably repro a timeout in
- http/tests/fetch/window/thorough/redirect-nocors-base-https-other-https.html
- http/tests/fetch/serviceworker-proxied/thorough/scheme-data-base-https-other-https.html
when running it 20 iterations.  After this CL, I cannot repro any
timeouts when running all ~200 tests 20 times:

    $ DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests \
        -t rel --no-retry --additional-driver-flag=--site-per-process \
        --iterations=20 \
        --exit-after-n-failures=1 --exit-after-n-crashes-or-timeouts=1 \
        --additional-driver-flag=--no-sandbox \
        --additional-driver-flag=--isolate-origins=http://www.web-platform.test:8001/,http://www1.web-platform.test:8001/,http://www2.web-platform.test:8001/,http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8001/,http://xn--lve-6lad.web-platform.test:8001/,http://www.web-platform.test:8081/,http://www1.web-platform.test:8081/,http://www2.web-platform.test:8081/,http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8081/,http://xn--lve-6lad.web-platform.test:8081/,https://www.web-platform.test:8444/,https://www1.web-platform.test:8444/,https://www2.web-platform.test:8444/,https://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8444/,https://xn--lve-6lad.web-platform.test:8444/ \
        --test-list=$HOME/scratch/test-list
    ...
    Found 206 tests; running 206 (20 times each: --repeat-each=1 --iterations=20), skipping 0.
    ...
    All 4120 tests ran as expected.

Bug:  801992 ,  834185 ,  711468 , 859988
Change-Id: I9f2c1abf87027fcb3824c54e597e561ac72babb9
Reviewed-on: https://chromium-review.googlesource.com/1182316
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584841}
[modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/content/shell/browser/layout_test/blink_test_controller.h
[modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f

commit 09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Thu Aug 23 15:53:17 2018

Use content::GlobalFrameRoutingId instead of std::pair<int, int>.

This CL exposes content::GlobalFrameRoutingId and GlobalRoutingID via
//content/public/browser API and uses it where appropriate instead of
std::pair<int, int>.

This CL also opportunistically fixes some other minor issues:
- IWYU problems reported by |git cl lint|
- Presubmit issues (e.g. using base::Callback instead of OnceCallback)

This CL is intended to be pure refactoring - no intended behavior
change.

Bug:  834185 
Change-Id: I39daff220c8a7da19114d28a1ea9ca8e24cc93fe
Reviewed-on: https://chromium-review.googlesource.com/1184150
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585498}
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/data_use_measurement/chrome_data_use_recorder.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/media/router/presentation/local_presentation_manager.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/media/router/presentation/local_presentation_manager.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/media/router/presentation/local_presentation_manager_unittest.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/media/router/presentation/presentation_service_delegate_impl.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/media/router/presentation/presentation_service_delegate_observers.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/media/router/presentation/presentation_service_delegate_observers.h
[delete] https://crrev.com/952e31b21b483012b2349d24a75b12f9c77e0d0e/chrome/browser/media/router/presentation/render_frame_host_id.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/chrome/browser/ui/media_router/presentation_receiver_window_controller_browsertest.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/BUILD.gn
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/frame_host/render_frame_host_impl.h
[delete] https://crrev.com/952e31b21b483012b2349d24a75b12f9c77e0d0e/content/browser/loader/global_routing_id.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/loader/loader_io_thread_notifier.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/media/capture/audio_mirroring_manager.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/media/capture/audio_mirroring_manager.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/media/capture/audio_mirroring_manager_unittest.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/media/capture/web_contents_audio_input_stream.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/media/capture/web_contents_audio_muter.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/payments/payment_app_info_fetcher.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/payments/payment_app_info_fetcher.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/payments/payment_instrument_icon_fetcher.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/payments/payment_instrument_icon_fetcher.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/service_worker/service_worker_content_settings_proxy_impl.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/service_worker/service_worker_context_wrapper.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/shared_worker/shared_worker_host.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/browser/web_contents/web_drag_dest_mac.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/public/browser/BUILD.gn
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/public/browser/content_browser_client.h
[add] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/public/browser/global_routing_id.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/public/browser/presentation_request.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/public/browser/presentation_request.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/shell/browser/layout_test/blink_test_controller.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/test/test_web_contents.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/content/test/web_contents_observer_sanity_checker.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/extensions/browser/guest_view/web_view/web_view_renderer_state.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/extensions/browser/guest_view/web_view/web_view_renderer_state.h
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/headless/lib/browser/headless_browser_context_impl.cc
[modify] https://crrev.com/09060bdf7e7bcc5bfdc051b15a55b4d1f5f84f0f/headless/lib/browser/headless_browser_context_impl.h

Comment 21 by lukasza@chromium.org, Aug 31

Status: Fixed (was: Started)
Let's mark this as fixed - the test expectations removed in r584841 / #c19 above don't seem to be causing any trouble.
►

Sign in to add a comment