The following layout test is flaky on all platforms. external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html virtual/outofblink-cors/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html Probable cause: Unknown https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=ServiceWorkerGlobalScope%2Fupdate.https.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f20739a3b0d648cab0bc1fcdcef011fd164e06b2 commit f20739a3b0d648cab0bc1fcdcef011fd164e06b2 Author: Kent Tamura <tkent@chromium.org> Date: Wed Apr 18 07:39:16 2018 Mark some tests as flaky. external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html http/tests/fetch/serviceworker-proxied/thorough/redirect-credentials-base-https-other-https.html http/tests/fetch/serviceworker/thorough/redirect-credentials-base-https-other-https.html http/tests/fetch/window/thorough/redirect-credentials-base-https-other-https.html http/tests/fetch/workers/thorough/redirect-credentials-base-https-other-https.html virtual/outofblink-cors/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html TBR=dcheng@chromium.org NOTRY=true Bug: 834183 , 834185 Change-Id: I6eb3d60775dc18aea2339f1be17358d9a00e5e97 Reviewed-on: https://chromium-review.googlesource.com/1016340 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#551606} [modify] https://crrev.com/f20739a3b0d648cab0bc1fcdcef011fd164e06b2/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process [modify] https://crrev.com/f20739a3b0d648cab0bc1fcdcef011fd164e06b2/third_party/WebKit/LayoutTests/TestExpectations
Probably https://chromium-review.googlesource.com/c/chromium/src/+/967863 falken@ said that there is a CL to fix the problem (not sure which CL though).
Yeah there is a fix CL for this: https://chromium-review.googlesource.com/c/chromium/src/+/981898
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf commit 8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf Author: Han Leon <leon.han@intel.com> Date: Wed May 02 04:17:00 2018 [ServiceWorker] Associate interfaces living on the SW thread together This CL switches those interfaces (ServiceWorkerHost, ServiceWorkerRegistrationObject[Host] etc.) associated with EmbeddedWorkerInstanceClient interface before to be associated with ServiceWorkerEventDispatcher interface living on its particular service worker thread in the renderer process. This will not only ensure them keeping the FIFO ordering with ServiceWorkerEventDispatcher, but also make all their Mojo message dispatches skip the main thread completely to avoid possible congestion. The idea is to let browser-side pass ServiceWorkerHost endpoint and ServiceWorkerRegistrationObjectInfo via a newly defined Mojo call ServiceWorkerEventDispatcher::InitializeGlobalScope() to the service worker thread, which holds on evaluating its service worker script until received that call. BUG= 745327 , 834200 , 834183 TBR=lazyboy@chromium.org for enabling a test in chrome/browser/extensions/service_worker_apitest.cc Change-Id: Icc9d03d2cc0f099735cfcf34660b835ccf908402 Reviewed-on: https://chromium-review.googlesource.com/981898 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#555307} [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/chrome/browser/extensions/service_worker_apitest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/payments/payment_app_content_unittest_base.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_instance_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_handle_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_test_utils.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_test_utils.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_version.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_version_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/common/service_worker/embedded_worker.mojom [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/common/service_worker/service_worker_provider.mojom [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/embedded_worker_instance_client_impl.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_network_provider.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_provider_context.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_provider_context.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_provider_context_unittest.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/public/web/modules/serviceworker/web_service_worker_context_proxy.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.h [modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/web_embedded_worker_impl_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee commit d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee Author: Han Leon <leon.han@intel.com> Date: Thu May 03 00:33:14 2018 Revert "[ServiceWorker] Associate interfaces living on the SW thread together" This reverts commit 8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf. Reason for revert: crbug.com/838397 and 834200, reland later when we make all things clear Original change's description: > [ServiceWorker] Associate interfaces living on the SW thread together > > This CL switches those interfaces (ServiceWorkerHost, > ServiceWorkerRegistrationObject[Host] etc.) associated with > EmbeddedWorkerInstanceClient interface before to be associated with > ServiceWorkerEventDispatcher interface living on its particular service > worker thread in the renderer process. > This will not only ensure them keeping the FIFO ordering with > ServiceWorkerEventDispatcher, but also make all their Mojo message > dispatches skip the main thread completely to avoid possible congestion. > > The idea is to let browser-side pass ServiceWorkerHost endpoint and > ServiceWorkerRegistrationObjectInfo via a newly defined Mojo call > ServiceWorkerEventDispatcher::InitializeGlobalScope() to the service > worker thread, which holds on evaluating its service worker script until > received that call. > > BUG= 745327 , 834200 , 834183 > TBR=lazyboy@chromium.org for enabling a test in > chrome/browser/extensions/service_worker_apitest.cc > > Change-Id: Icc9d03d2cc0f099735cfcf34660b835ccf908402 > Reviewed-on: https://chromium-review.googlesource.com/981898 > Commit-Queue: Han Leon <leon.han@intel.com> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Han Leon <leon.han@intel.com> > Cr-Commit-Position: refs/heads/master@{#555307} TBR=falken@chromium.org,kinuko@chromium.org,lazyboy@chromium.org,shimazu@chromium.org,leon.han@intel.com Change-Id: I935bfdbce9b407c937c2e3a5da424773ec397a1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 745327 , 834200 , 834183 Reviewed-on: https://chromium-review.googlesource.com/1041050 Reviewed-by: Han Leon <leon.han@intel.com> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#555630} [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/chrome/browser/extensions/service_worker_apitest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/payments/payment_app_content_unittest_base.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_instance_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_handle_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_test_utils.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_test_utils.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_version.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_version_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/common/service_worker/embedded_worker.mojom [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/common/service_worker/service_worker_provider.mojom [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/embedded_worker_instance_client_impl.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_network_provider.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_provider_context.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_provider_context.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_provider_context_unittest.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/public/web/modules/serviceworker/web_service_worker_context_proxy.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.h [modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/web_embedded_worker_impl_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea53efda17c8c5c3604d56caaa98823a0cc88c20 commit ea53efda17c8c5c3604d56caaa98823a0cc88c20 Author: Han Leon <leon.han@intel.com> Date: Mon May 14 09:48:44 2018 Reland: [ServiceWorker] Associate interfaces living on the SW thread together We reverted the original CL https://chromium-review.googlesource.com/c/chromium/src/+/981898 by https://chromium-review.googlesource.com/c/chromium/src/+/1041050 because we wanted to solve the crash in bug 838397 immediately at the time, but after that we have landed its real fix https://chromium-review.googlesource.com/c/chromium/src/+/1036498, so now we can reland this one. The only change from the original CL is that we do not re-enable the test ServiceWorkerLazyBackgroundTest#EventsAfterRestart in this CL, because it proved that this CL cannot really solve it, we need further investigation on it (tracker issue: 834200 ). BUG= 745327 , 834183 TBR=shimazu,falken,kinuko Change-Id: Id5dedfc914b1526af2ea510ef890b768456982cf Reviewed-on: https://chromium-review.googlesource.com/1056796 Reviewed-by: Han Leon <leon.han@intel.com> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#558241} [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/payments/payment_app_content_unittest_base.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/embedded_worker_instance_unittest.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_handle_unittest.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_test_utils.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_test_utils.h [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_version.h [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_version_unittest.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/common/service_worker/embedded_worker.mojom [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/common/service_worker/service_worker_provider.mojom [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/embedded_worker_instance_client_impl.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_network_provider.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_provider_context.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_provider_context.h [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_provider_context_unittest.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/public/web/modules/serviceworker/web_service_worker_context_proxy.h [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.h [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.h [modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/serviceworkers/web_embedded_worker_impl_test.cc
Comment 1 by bugdroid1@chromium.org
, Apr 18 2018