New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The AEC3 initial alignment may sometimes be off, causing short periods of echo leakage initially.

Project Member Reported by peah@chromium.org, Apr 18 2018

Issue description

Since AEC3 does not utilize any externally reported audio path delay, it may leak echoes initially if for a certain types of signals/scenarios where the delay estimator is slow to detect the delay. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/d0fa82055947b76554e9b3dd11fea7c1c61650a8

commit d0fa82055947b76554e9b3dd11fea7c1c61650a8
Author: Per Åhgren <peah@webrtc.org>
Date: Wed Apr 18 09:05:54 2018

Allow AEC3 to use any externally reported audio buffer delay in AEC3

This CL adds support for using any externally reported audio buffer
delay to set the initial alignment in AEC3 which is used before the
AEC has been able to detect the delay.

Bug:  chromium:834182 , webrtc:9163 
Change-Id: Ic71355f69b7c4d5815b78e49987043441e7908fb
Reviewed-on: https://webrtc-review.googlesource.com/70580
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22917}
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/api/audio/echo_control.h
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/aec3/block_processor.cc
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/aec3/block_processor.h
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/aec3/echo_canceller3.cc
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/aec3/echo_canceller3.h
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/aec3/echo_canceller3_unittest.cc
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/aec3/mock/mock_block_processor.h
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/aec3/mock/mock_render_delay_buffer.h
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/aec3/render_delay_buffer.cc
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/aec3/render_delay_buffer.h
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/audio_processing_impl.cc
[modify] https://crrev.com/d0fa82055947b76554e9b3dd11fea7c1c61650a8/modules/audio_processing/include/mock_audio_processing.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e1ea4951a683b44e28cdc22f7766bef58f927fb

commit 8e1ea4951a683b44e28cdc22f7766bef58f927fb
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Apr 18 13:18:58 2018

Roll src/third_party/webrtc/ b02644f2b..4736d4e52 (4 commits)

https://webrtc.googlesource.com/src.git/+log/b02644f2b89d..4736d4e52456

$ git log b02644f2b..4736d4e52 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG= chromium:834182 


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8ac8d7221b68105a565ec87fc7606bacea176e41
Reviewed-on: https://chromium-review.googlesource.com/1016581
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551651}
[modify] https://crrev.com/8e1ea4951a683b44e28cdc22f7766bef58f927fb/DEPS

Comment 3 by peah@chromium.org, Apr 24 2018

Cc: gustaf@chromium.org hlundin@chromium.org
Labels: Merge-Request-67
We would like to merge this into M67. The code has been active in Canary for 6 days and the stats look good.

Project Member

Comment 4 by sheriffbot@chromium.org, Apr 24 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Apr 24 2018

Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comment #3. Please merge ASAP. Thank you.

Comment 6 by peah@chromium.org, Apr 25 2018

Cc: gov...@chromium.org
The CL for this issue was merged an hour ago. 

Comment 7 by gov...@chromium.org, Apr 25 2018

Could you pls point the merged CL here?

Comment 8 by peah@chromium.org, Apr 25 2018

The CL for the merge is: https://webrtc-review.googlesource.com/c/src/+/72540

Comment 9 by gov...@chromium.org, Apr 25 2018

Labels: -Merge-Approved-67 merge-merged-67
Thank you  peah@.

M67 merge is done at #8.
Is this finished?

Comment 11 by peah@chromium.org, Jun 14 2018

Status: Fixed (was: Started)

Sign in to add a comment