A CL removing *.vpython file causes a presubmit error |
|||
Issue descriptionA CL [1] removes wpt-import and wpt-import.vpython. It causes a presubmit error like the following: ** Presubmit ERRORS ** Verify /b/swarming/w/ir/cache/builder/chromium_presubmit/src/third_party/WebKit/Tools/Scripts/wpt-import.vpython (0.01s) failed [E2018-04-18T00:04:18.445789-07:00 19854 0 annotate.go:242] original error: open /b/swarming/w/ir/cache/builder/chromium_presubmit/src/third_party/WebKit/Tools/Scripts/wpt-import.vpython: no such file or directory [E2018-04-18T00:04:18.445819-07:00 19854 0 annotate.go:242] [E2018-04-18T00:04:18.445827-07:00 19854 0 annotate.go:242] goroutine 1: [E2018-04-18T00:04:18.445835-07:00 19854 0 annotate.go:242] #0 go.chromium.org/luci/vpython/spec/load.go:60 - spec.Load() [E2018-04-18T00:04:18.445846-07:00 19854 0 annotate.go:242] reason: failed to load file from: /b/swarming/w/ir/cache/builder/chromium_presubmit/src/third_party/WebKit/Tools/Scripts/wpt-import.vpython [E2018-04-18T00:04:18.445853-07:00 19854 0 annotate.go:242] [E2018-04-18T00:04:18.445865-07:00 19854 0 annotate.go:242] #1 go.chromium.org/luci/vpython/application/application.go:259 - application.(*application).mainImpl() [E2018-04-18T00:04:18.445875-07:00 19854 0 annotate.go:242] #2 go.chromium.org/luci/vpython/application/application.go:402 - application.(*Config).Main.func1() [E2018-04-18T00:04:18.445884-07:00 19854 0 annotate.go:242] #3 go.chromium.org/luci/vpython/application/support.go:47 - application.run() [E2018-04-18T00:04:18.445892-07:00 19854 0 annotate.go:242] #4 go.chromium.org/luci/vpython/application/application.go:401 - application.(*Config).Main() [E2018-04-18T00:04:18.445900-07:00 19854 0 annotate.go:242] #5 vpython/main.go:92 - main.mainImpl() [E2018-04-18T00:04:18.445909-07:00 19854 0 annotate.go:242] #6 vpython/main.go:98 - main.main() [E2018-04-18T00:04:18.445917-07:00 19854 0 annotate.go:242] #7 runtime/proc.go:198 - runtime.main() [E2018-04-18T00:04:18.445924-07:00 19854 0 annotate.go:242] #8 runtime/asm_amd64.s:2361 - runtime.goexit() Log URL: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8948927214983055952%2F%2B%2Fsteps%2Fpresubmit%2F0%2Fstdout Reading a removed file looks unreasonable. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1013856
,
Apr 18 2018
this is a bug in CheckVPythonSpec: https://codesearch.chromium.org/chromium/tools/depot_tools/presubmit_canned_checks.py?rcl=85c75025906ac77b4f7979896985119dfb8dca1b&l=1145 Fix is https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1016690
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/161623779eaf8cd3dd571dfa4aa5b44b9611396f commit 161623779eaf8cd3dd571dfa4aa5b44b9611396f Author: John Budorick <jbudorick@chromium.org> Date: Wed Apr 18 22:44:39 2018 presubmit: don't attempt to verify nonexistent vpython specs. Bug: 834180 Change-Id: I431431e4fdf99c16c5fc3dbc7ed999b0c8da24bc Reviewed-on: https://chromium-review.googlesource.com/1016690 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/161623779eaf8cd3dd571dfa4aa5b44b9611396f/presubmit_canned_checks.py [modify] https://crrev.com/161623779eaf8cd3dd571dfa4aa5b44b9611396f/presubmit_support.py [modify] https://crrev.com/161623779eaf8cd3dd571dfa4aa5b44b9611396f/tests/presubmit_unittest.py
,
Apr 18 2018
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1836ae055c5d7b71f00eb2f6080551abfc9f6aa3 commit 1836ae055c5d7b71f00eb2f6080551abfc9f6aa3 Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 19 00:44:58 2018 Roll src/third_party/depot_tools/ 9ccad5689..161623779 (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9ccad5689c09..161623779eaf $ git log 9ccad5689..161623779 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 jbudorick presubmit: don't attempt to verify nonexistent vpython specs. Created with: roll-dep src/third_party/depot_tools BUG= chromium:834180 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I70646d12e50d3cfca80f675570afd5e5dee317c8 Reviewed-on: https://chromium-review.googlesource.com/1018106 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551903} [modify] https://crrev.com/1836ae055c5d7b71f00eb2f6080551abfc9f6aa3/DEPS |
|||
►
Sign in to add a comment |
|||
Comment 1 by tkent@chromium.org
, Apr 18 2018