New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 834172 link

Starred by 1 user
Status: Fixed
Owner:
thestig@chromium.org
Closed: Apr 2018
Cc:
█ manoranj...@chromium.org
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Print using system dialog' link does not work in latest Canary #68.0.3399.0

Reported by avsha...@etouch.net, Apr 18 2018 
Chrome Version : 68.0.3399.0 (Official Build) d20bd588bc3710f957224d4b791975e67d8c0119-refs/heads/master@{#551554} 32/64-bit
OS : Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, open NTP and hit Ctrl + P.
2. Click on 'Print using systemm dialog' and obsrve.

Actual Result : Unable to print any page using 'Print using systemm dialog' link.

Expected Result : 'Print using systemm dialog' link should work as expected.

This is a regression issue, broken in M-68 and wiil soon update other info.

Comment 1 by avsha...@etouch.net, Apr 18 2018

Labels: RegressedIn-68 ET-MUM-Reported hasbisect FoundIn-68 Target-68
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression : 'Print using system dialog' link does not work in latest Canary #68.0.3399.0 (was: Rehression : 'Print using system dialog' link does not work in latest Canary #68.0.3399.0)
This is a regression issue, broken in M-68 and providing the narrow bisect using old script:
Good Build : 68.0.3398.0 (Revision : 551179)
Bad Build : 68.0.3399.0 (Revision : 551554)

(Getting 'No enough builds..' error while performing bisect with per-revision script hence providing the bisect using old script)

Narrow bisect URL : 
https://chromium.googlesource.com/chromium/src/+log/72ac5c08820272be7452ebd9181f9308bf62a223..f3613456ff8ef8a1c872ee79c850b18996fc6ebf?pretty=fuller&n=10000

Suspecting : r551457 ?

@Lei : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : Issue is not observed on Mac(10.12.6, 10.13.1, 10.13.5) and Linux(14.04 LTS) OS.
Actual_Print.mp4
302 KB View Download
Expected_Print.mp4
273 KB View Download

Comment 2 by rbasuvula@chromium.org, Apr 18 2018

Cc: pbomm...@chromium.org manoranj...@chromium.org
Labels: ReleaseBlock-Beta
As this is a recent regression adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!

Comment 3 by thestig@chromium.org, Apr 19 2018

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/1020068
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ba7352fff013c8f4aee1cc6b38987a9ae4d6ac3

commit 1ba7352fff013c8f4aee1cc6b38987a9ae4d6ac3
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Apr 20 22:12:57 2018

Printing: Fix regression with system dialogs on Windows.

This effectively reverts one file in r551457 which was confusing. Add a
comment to explain what is going on.

BUG= 834172 

Change-Id: I27279382d1b6bbc08688a31a3dc308a791bbc37f
Reviewed-on: https://chromium-review.googlesource.com/1020068
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552492}
[modify] https://crrev.com/1ba7352fff013c8f4aee1cc6b38987a9ae4d6ac3/printing/printing_context_win.cc

Comment 5 by thestig@chromium.org, Apr 20 2018

Status: Fixed (was: Started)

Comment 6 by avsha...@etouch.net, Apr 23 2018

Labels: TE-Verified-M68 TE-Verified-68.0.3404.0
Update : 
Retested above issue in latest Canary build #68.0.3404.0 on Windows(7,8,8.1,10) OS and the issue is fixed. 'Print using system dialog' option in print preview is working as intended. Kindly review an attached screen-cast.

Thank you..!
Printing.mp4
373 KB View Download
►

Sign in to add a comment