generate_build_files failing on multiple builders |
||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of toyoshim@google.com generate_build_files failing on multiple builders Builders failed on: - linux-jumbo-rel: https://build.chromium.org/p/chromium.linux/builders/linux-jumbo-rel - win-jumbo-rel: https://build.chromium.org/p/chromium.win/builders/win-jumbo-rel
,
Apr 18 2018
There are two ToRtcOptional definition in anonymous namespace in the same jumbo build group.
media_stream_video_webrtc_sink.cc:
rtc::Optional<bool> ToRtcOptional(const base::Optional<bool>& value) { ... }
rtc_rtp_parameters.cc:
template <typename T, typename F>
rtc::Optional<T> ToRtcOptional(const base::Optional<F>& from) { ... }
I will submit a tentative fix that renames the first one to ToRtcOptionalBool.
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58c15949898bf4e163069c1ed7128bbbbe012faa commit 58c15949898bf4e163069c1ed7128bbbbe012faa Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Wed Apr 18 07:45:57 2018 Jumbo build fix: rename ToRtcOptinoal to ToRtcOptionalBool There are two ToRtcOptinlal functions in the same jumbo build group, and it breaks jumbo builders. Bug: 834162 Change-Id: Id37adc6bef5ce4d0e38b8e564f3998d27084a53d Tbr: sergeyu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1016217 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#551607} [modify] https://crrev.com/58c15949898bf4e163069c1ed7128bbbbe012faa/content/renderer/media/webrtc/media_stream_video_webrtc_sink.cc
,
Apr 18 2018
,
Apr 18 2018
,
Jun 7 2018
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable? |
||||
►
Sign in to add a comment |
||||
Comment 1 by toyoshim@chromium.org
, Apr 18 2018