New issue
Advanced search Search tips

Issue 834158 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Chrome crashes always when we do Stylus button event on currently redirecting page after choosing to navigate to new webpage.

Reported by mahesh...@samsung.com, Apr 18 2018

Issue description

Steps to reproduce the problem:
1. Use stylus on Note 8 and Load facebook.com
2. Go to url bar - type gmail
3. Click on the suggestion using stylus - www.gmail.com
4. Press the Stylus button and drag on current page (which is still facebook.com and URL load is in progress)

What is the expected behavior?
No crash should happen.

What went wrong?
Chrome browser crashed.

Crashed report ID: 2c152235be7daa99

How much crashed? Whole browser

Is it a problem with a plugin? No 

Did this work before? N/A 

Chrome version: 64.0.3282.137  Channel: stable
OS Version: 8.0
Flash Version: SM-N950F

These steps reproduce the crash always.
 
Components: UI>Browser>Selection
Owner: amaralp@chromium.org
Status: Assigned (was: Unconfirmed)
Crash in Selection Popup Controller.
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d19b4bd87453493f386f8dfef18c8867bbcb08a

commit 3d19b4bd87453493f386f8dfef18c8867bbcb08a
Author: Mahesh Machavolu <mahesh.ma@samsung.com>
Date: Thu May 03 08:43:43 2018

Replace DCHECK with null check for selection_popup_controller_ in RWHVA

selection_popup_controller_ object is swapped to new_rwhva when new render
process gets created and this pointer is set to null for the old_rwhva.
Refer to API SelectionPopupController::UpdateRenderProcessConnection().
When stylus button event is given to this old_rwhva before the browser
loads the new page, then it will cause a crash as OnStylusSelectBegin()
will try to access selection_popup_controller_ which is already null.

So, don't handle any selection events when selection_popup_controller_
is null.

BUG:  834158 
Change-Id: I2f55f9109183fe93a7fa7964cf4a67dfb9175e21
Reviewed-on: https://chromium-review.googlesource.com/1016180
Reviewed-by: AJITH KUMAR V <ajith.v@samsung.com>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com>
Cr-Commit-Position: refs/heads/master@{#555680}
[modify] https://crrev.com/3d19b4bd87453493f386f8dfef18c8867bbcb08a/content/browser/renderer_host/render_widget_host_view_android.cc

Status: Fixed (was: Assigned)

Sign in to add a comment