I see in [1] that R67-10575.3.0 is bad (only for some codecs) and R66-10452.69.0
is good, but there's a sizeable amount of CLs in that range, how did you bisect?



[1] https://stainless.corp.google.com/search?view=matrix&row=board&col=build&first_date=2018-04-16&last_date=2018-04-18&test=video_VideoSeek&exclude_cts=false&exclude_not_run=false&exclude_non_release=false&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=true

We found video_VideoSeek started to fail since 10554.0.0.
Chrome was upreved on the version. https://chromium.googlesource.com/chromium/src/+log/67.0.3383.0..67.0.3390.0?n=10000
Because this failure is only on intel devices, we bet https://chromium-review.googlesource.com/#/c/chromium/src/+/973684.
akahuang@ confirmed this was bad CL.

In addition, akahuang@ already have been looking into. He had some clues and would fix this issue. Or perhaps I hand over this task.
Anyway, our team would fix this issue.

The bug is caused by calling TryFinishSurfaceSetChange() again before calling AssignPictureBuffers(). When AssignPictureBuffers() receives the previous requested buffer, it failed at checking the buffer amount. 

https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_video_decode_accelerator.cc?q=vaapi_video_decode_accelerator.cc&dr&l=506

Aka. Can we add a test case in VDA unittest to catch this?

I took it over this work from akahuang@.

wucheng, of course, I will do the task of adding test cases to VDA unittest.

 Issue 834663  has been merged into this issue.

Interestingly enough, I can repro by navigating to [1] and jumping back
and forth in the stream (that is meant to switch resolution). After a 
while, I can get it to lock up, but the problem causing it is in [2],
AssignPictureBuffers() is called with 9 PictureBuffers while it expected
10. I have no idea how my removing the ConditionVariables might be causing 
this :-)  -- but allowing for this circumstance to not be an error seems
to fix the test -- together with correctly locking the 
|awaiting_va_surfaces_recycle_|, which might have something to do and 
because of that I'm merging the bugs.

[1] http://commondatastorage.googleapis.com/chromiumos-test-assets-public/MSE/switch_1080p_720p.mp4
[2] https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_video_decode_accelerator.cc?sq=package:chromium&dr&l=507

Ah, hiroh@ sent me a piece of information that was not in the bug:
" 
As far as I investigated this problem, [the] change, crrev.com/c/973684, 
still has problem for resolution changes.
In the test, two buffers are coming, which I call Buffer A and Buffer B.
Buffer A issues 1920x1088 resolution change, and Buffer B issues 1280x720
resolution change.
After [the] change, those resolution changes are processed in parallel.
TryFinishSurfaceChange() on buffer A, TryFinishSurfaceChange() on buffer 
B, and then AssignPictureBuffers() on buffer A, AssignPictureBuffers() on 
buffer B.
In ProvidePictureBuffers() on buffer A, the mismatch of request_num_pics 
and request_pic_size_ happens since they are updated to ones for buffer B 
in TryFinishSurfaceChange().

The solution is block DecodeTask on bufferB until AssignPictureBuffers() are completed.
I would prefer introducing kAwaitingPictureBuffers similar to V4L2SVDA.
I tried introducing but the state machine in vaapi VDA was complicated to me.
I cannot have succeeded to make VDA work correctly.
" 

Hence my solution in #9 is not enough, scrub all that.

I'm running now with DCHECK()s on (thought I was, but wasn't), and have
found a few other invariants that don't apply anymore on ToT, so I'll revert
the code back to the last known good-ish state, and also merge back to M67,
that branched on 550428.  Then I'll tackle again the appropriate bugs.

FYI these are the CLs that need revert and their landing index, plus an annotation of 
those that need merge to M67 (Y/N):



Revert "RELAND: Vaapi: Remove ConditionVariables and use PostTask"
This reverts commit 5eec367971c0b4d21328f4798ed304c240d89e72.       546827  Y

Revert "vaapi: cleanup a few comments and var names"
This reverts commit c813adf6312dda8d54aca42dd5dc4460248726ad.       547552  Y

Revert "vaapi: add a log when running out available va surfaces, 
which causes decoding fail."
This reverts commit e9ea7ba41399d0a0e52f3a7e98a4b790e4e98569.       548917  Y

Revert "vaapi: minor cleanups in VaVDA (OutputPicture, mostly)"
This reverts commit b4990829f33305ea94a6649771e331af97d3066d.       549506  Y

Revert "media/gpu/vaapi: Post DecodeTask() from ReusePictureBuffer()"
This reverts commit 7cf2167e0709987aff777468eb080133d0283f88.       550155  Y

Revert "vaapi: Don't use = {} to clear base::queues"
This reverts commit 83bd765601072b55ab31b8b23665a31578deca19.       550162  Y

Revert "VaVDA: Move BlitSurface to |decoder_thread_task_runner_|"
This reverts commit 051ec184287440813ad2ae4f515f6d99a16e764d.       551006  N

(Chromium branched at revision: 550428)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e54827d909805f80bc26fe171dcfa3644c2085c9

commit e54827d909805f80bc26fe171dcfa3644c2085c9
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Apr 19 19:27:55 2018

Revert "VaVDA: Move BlitSurface to |decoder_thread_task_runner_|"

This reverts commit 051ec184287440813ad2ae4f515f6d99a16e764d.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 

Original change's description:
> VaVDA: Move BlitSurface to |decoder_thread_task_runner_|
>
> This CL moves the call to VaapiPicture::DownloadFromSurface,
> which in turn calls VaapiWrapper::BlitSurface(), to be executed
> in the decoder thread of VaVDA. This considerable offloads the
> Gpu main thread for more urgent tasks, and anyway the said
> decoder thread is idle most of the time (seen in chrome:trace),
> so utilizing it more doesn't impact the overall performance but
> increases responsiveness.
>
> This Chrome:tracing details shows the change (soraka vp9 720p@30)
> before: https://i.imgur.com/CkqXqTp.png (https://imgur.com/a/pYVpf)
> after: https://i.imgur.com/o0c4ksW.png (https://imgur.com/a/wblx0)
> (the actual duration is inconsequential since it depends on the
> actual frame).
>
> nit: TRACE_EVENT1 is moved to the Vaapi*Picture because it results
> in easier syntax around the PostTaskAndReplyWithResult().
>
> TEST= simplechrome+crosvideo and v_d_a_unittest h264/vp8/vp9
> on soraka. No perf regression observed in the produced numbers.
>
> Bug: 717265
> Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Icc4af2ef96141cebf95ac8fbb89c6e386e194a30
> Reviewed-on: https://chromium-review.googlesource.com/947341
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551006}

TBR=mcasas@chromium.org,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717265
Change-Id: I86b367bc2b5d596b4f755440c494656555fa796f
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020000
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552114}
[modify] https://crrev.com/e54827d909805f80bc26fe171dcfa3644c2085c9/media/gpu/vaapi/vaapi_picture_native_pixmap.cc
[modify] https://crrev.com/e54827d909805f80bc26fe171dcfa3644c2085c9/media/gpu/vaapi/vaapi_picture_tfp.cc
[modify] https://crrev.com/e54827d909805f80bc26fe171dcfa3644c2085c9/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/e54827d909805f80bc26fe171dcfa3644c2085c9/media/gpu/vaapi/vaapi_video_decode_accelerator.h
[modify] https://crrev.com/e54827d909805f80bc26fe171dcfa3644c2085c9/media/gpu/video_decode_accelerator_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/015a217b3fc3a34021e67726c05789c41a564e5a

commit 015a217b3fc3a34021e67726c05789c41a564e5a
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Apr 19 19:41:23 2018

Revert "media/gpu/vaapi: Post DecodeTask() from ReusePictureBuffer()"

This reverts commit 7cf2167e0709987aff777468eb080133d0283f88.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 

Original change's description:
> media/gpu/vaapi: Post DecodeTask() from ReusePictureBuffer()
>
> DecodeTask() is posted from mainly QueueInputBuffer() or
> RecycleVASurfaceID() in most cases.
> Some DecodeTask() posted from QueueInputBuffer() do nothing since va
> surface is not available yet. It will be available after AssignPictureBuffers().
> If the first buffer contains information about coded size, DecodeTask() for the
> succeeding buffers are pended. In this case, DecodeTask() may be called twice;
> in QueueInputBuffer() and the other once in AssignPictureBuffers().
> If the third buffer is a dummy buffer queued by Flush(), the buffer is not
> popped in DecodeTask() and thus FlushTask() is not executed permanently.
> It can be a problem when a client expects the picture decoded from second buffer
> is returned, because decoding of the second buffer might be pending in driver.
> FlushTask() which can ask driver to decode the second buffer is not executed now
> due to the above reason.
> The following CTS tests behave similarly to the problem case.
> * android.media.cts.DecoderTest#testEOSBehaviorH264
> * android.media.cts.DecoderTest#testEOSBehaviorVP8"
> * android.media.cts.DecoderTest#testEOSBehaviorVP9"
>
> These CTS starts to fail from crrev.com/c/973684. In the CL, DecodeTask() was
> changed to not execute DecodeTask() to the succeeding buffers.
>
> This changes VDA as to post DecodeTask() from ReusePictureBuffer(), and the
> number of executing DecodeTask() is sufficient to get driver finish decoding
> storing picture buffers.
>
> BUG=b:77840176
> TEST=CtsMediaTestCases on eve
> TEST=VDA unittest
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/1006563
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Pawel Osciak <posciak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550155}

TBR=posciak@chromium.org,mcasas@chromium.org,hiroh@chromium.org,acourbot@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:77840176
Change-Id: I7b9c7049a8b050138bd5eb7d99ce8cd36af19e67
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020002
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552120}
[modify] https://crrev.com/015a217b3fc3a34021e67726c05789c41a564e5a/media/gpu/vaapi/vaapi_video_decode_accelerator.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e1aa3d31b61440058b3f157622d963ec05a4e97

commit 4e1aa3d31b61440058b3f157622d963ec05a4e97
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Apr 19 19:46:10 2018

Revert "vaapi: Don't use = {} to clear base::queues"

This reverts commit 83bd765601072b55ab31b8b23665a31578deca19.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 

Original change's description:
> vaapi: Don't use = {} to clear base::queues
>
> This CL removes the use of = {} to clear base::queues, because, for classes,
> zero initialization simply clears the (non-static) data members, which might
> leave the objects in an incorrect meta state because ctors are not called:
> this should not be an issue for std::queue, but it is for base::queue, which
> is implemented as a base::circular_deque.
>
> Nothing is crashing now, but a sibling unlanded sister CL (crrev.com/c/947341)
> had some issues with a similar idiom, so I'm removing it just in case.
>
> [1] http://en.cppreference.com/w/cpp/language/zero_initialization
>
> Bug: 717265
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: I96af3e6475c0596f3316219bd51732e085f5e098
> Reviewed-on: https://chromium-review.googlesource.com/1005917
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550162}

TBR=mcasas@chromium.org,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717265
Change-Id: I06bc48deafedb9badd0937f9a2efd37c318edf6d
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020001
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552124}
[modify] https://crrev.com/4e1aa3d31b61440058b3f157622d963ec05a4e97/media/gpu/vaapi/vaapi_video_decode_accelerator.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4edbb5feac3fe4c3748175b8150726db3e4e18

commit 4a4edbb5feac3fe4c3748175b8150726db3e4e18
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Apr 19 20:04:25 2018

Revert "vaapi: add a log when running out available va surfaces, which causes decoding fail."

This reverts commit e9ea7ba41399d0a0e52f3a7e98a4b790e4e98569.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 


Original change's description:
> vaapi: add a log when running out available va surfaces, which causes decoding fail.
>
> There is GPU hang related to RTC decoding. I guess it's because there is not
> an available va surface. This CL will prove it.
>
> BUG=b/72676160
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: I4349d9b00f46c03210498e13d30636b752078980
> Reviewed-on: https://chromium-review.googlesource.com/999101
> Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
> Cr-Commit-Position: refs/heads/master@{#548917}

TBR=dongseong.hwang@intel.com,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/72676160
Change-Id: Ib5ba7e753aebd2bfc0c248664381d08659528467
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020004
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552134}
[modify] https://crrev.com/4a4edbb5feac3fe4c3748175b8150726db3e4e18/media/gpu/vaapi/vaapi_video_decode_accelerator.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba217eddda82e1781ee977c4ad5f4d26feb2bdda

commit ba217eddda82e1781ee977c4ad5f4d26feb2bdda
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Apr 19 20:33:33 2018

Revert "vaapi: minor cleanups in VaVDA (OutputPicture, mostly)"

This reverts commit b4990829f33305ea94a6649771e331af97d3066d.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 


Original change's description:
> vaapi: minor cleanups in VaVDA (OutputPicture, mostly)
>
> This CL is a few cleanups to ease review of crrev.com/c/986353:
>
> - PictureById() is moved to the end of the cc file, following the
>  order of its declaration. Code untouched (except s/NULL/nullptr/).
>  A call to PictureById  is substituted with base::ContainsKey()
>  to better reflect intent.
>
> - OutputPicture() loses its last parameter, that is then calculated
>  on the spot (it's |available_picture_buffers_.front()|). This makes
>  OutputCB unnecessary, so it's made a Closure, and a OnceClosure at
>  that.
>
> Test: eve crosvideo vp9 cycling resolutions.
>
> Bug: 822346
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: Ie17f23f2fb20752463e9ebeacd1bf7a9b6150437
> Reviewed-on: https://chromium-review.googlesource.com/1000297
> Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549506}

TBR=mcasas@chromium.org,hoegsberg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 822346
Change-Id: If0d162b5373c33c266268d9cd82e3de5fd4e4a7e
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020003
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552146}
[modify] https://crrev.com/ba217eddda82e1781ee977c4ad5f4d26feb2bdda/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/ba217eddda82e1781ee977c4ad5f4d26feb2bdda/media/gpu/vaapi/vaapi_video_decode_accelerator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2edc7ca953140f70f5c5e79defda98511c9fa046

commit 2edc7ca953140f70f5c5e79defda98511c9fa046
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Apr 19 21:36:05 2018

Revert "vaapi: cleanup a few comments and var names"

This reverts commit c813adf6312dda8d54aca42dd5dc4460248726ad.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 

Original change's description:
> vaapi: cleanup a few comments and var names
>
> This CL cleans up a few things that I realized while
> debugging other CLs in the area:
> - |available_va_surfaces_| is a std::list on ToT, but has
>  queue semantics, so it's changed int his CL.
> -  s/output_buffers_/available_va_surfaces_/ because that's
>  what they are.
> - s/TryOutputSurface/TryOutputPicture/ because that's what
>  the method does.
> - s/pictures_/picture_map_/ to better define what it is. After
>  dcastagna@ suggestion, it's made a base::small_map in PS7
>
> Comments updated throughout these variables.
>
> No change in behaviour intended, but tested nonetheless with
> vp8/9-h264 crosvideo playback.
>
> Bug: 822346
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: I2117ceac29f7d6ed23d698c4abd5c72e0140ae47
> Reviewed-on: https://chromium-review.googlesource.com/988512
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547552}

TBR=mcasas@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 822346
Change-Id: I7d242ad92a68596766f6cfe0ad2be37da3c4fb20
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020005
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552166}
[modify] https://crrev.com/2edc7ca953140f70f5c5e79defda98511c9fa046/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/2edc7ca953140f70f5c5e79defda98511c9fa046/media/gpu/vaapi/vaapi_video_decode_accelerator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1b30a7a9f2fa342058b128c55c37c27a878f416

commit a1b30a7a9f2fa342058b128c55c37c27a878f416
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Apr 19 22:45:36 2018

Revert "RELAND: Vaapi: Remove ConditionVariables and use PostTask"

This reverts commit 5eec367971c0b4d21328f4798ed304c240d89e72.

Reason for revert: Caused regression in video_VideoSeek:
 https://crbug.com/834146 
Bug:  834146 

Original change's description:
> RELAND: Vaapi: Remove ConditionVariables and use PostTask
>
> This CL relands the attached CL that got reverted due to scaling
> issues, i.e. when the decode bitstream changed resolution, there
> was the chance that before marking |awaiting_va_surfaces_recycle_|,
> we could get an "old" resolution frame, that would confuse |decoder_|.
>
> The solution is to move |awaiting_va_surfaces_recycle_| marking to
> DecodeTask(), and hold off any more Decode() operations until the
> "old" resolution frames are processed. This in turn makes
> InitiateSurfaceSetChange() superfluous, so it's moved into DecodeTask().
> The rest is comment update :-)
> ** Changes can be found here: crrev.com/c/973684/3..9
>
> TEST=http://crosvideo.appspot.com/?codec=vp9&cycle=true&loop=true&mute=true
> and letting it roll through many many many resolution changes.
>
> Original CL description ------------------------------------------------
>
> This CL removes the use of the ConditionVariables inside VaVDA and
> uses instead PostTask()ing. This removes blocking the worker
> thread, which allows for moving other tasks there, e.g. the
> Surface Blit (as done in the follow up WIP CL crrev.com/c/947341)
>
> For all that goodness, this CL:
>
> - Refactors the waiting logic that on ToT is spread between
>  GetCurrInputBuffer_Locked() and WaitForSurfaces_Locked() and
>  simplifies it in DecodeTask() itself.
>
> - Moves the |curr_input_buffer_| filling logic in
>  GetCurrInputBuffer_Locked() into DecodeTask() proper.
>
> - Reduces the scoped of the |lock_| in DecodeTask() (note that
>  |curr_input_buffer_| and |decode_| are only used on the decoder
>  thread -- added a .h comment).
>
> Minor stuff: This CL also moves together the declaration of the
> related member vars |input_buffers_|, |curr_input_buffer_| and
> |available_va_surfaces_|
>
> TEST=simplechrome+crosvideo (including seeks) on soraka, and
> v_d_a_unittest with h264, vp8, vp9 (with dcheck_always_on=true).
>
> Bug: 717265
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: I86d179ac4d48c63b36787f5c7bdcb0da3839ed69
> Reviewed-on: https://chromium-review.googlesource.com/949283
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#542955}
> Reviewed-on: https://chromium-review.googlesource.com/973684
> Cr-Commit-Position: refs/heads/master@{#546827}

TBR=posciak@chromium.org,mcasas@chromium.org,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717265
Change-Id: Ic31471daf757fd08ff2f420afc5be7e973a88c01
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020040
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552190}
[modify] https://crrev.com/a1b30a7a9f2fa342058b128c55c37c27a878f416/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/a1b30a7a9f2fa342058b128c55c37c27a878f416/media/gpu/vaapi/vaapi_video_decode_accelerator.h

This happens on M67 as well. Is there a need to cherry-pick to M67?
Let me set this issue owner to mcasas@.

#21: yes, I thought I had marked it as Merge-Request-67 :-?

Requesting to merge back those CLs in the series above that made
it to M67 (See c12 about which are those:  https://crbug.com/834146#c12 )

Also, I tried locally and current ToT (with all the patches reverted) 
seems to work fine, hiroh@ or anyone else in cc, could you please 
verify as well ? Thx

Thank you mcasas@.
I have confident the problem will be gone.
Let me verify next week. At that time, all the reverted CL will hopefully be landed on Chrome OS ToT.

Approving merge to M67 Chrome OS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ed1cbcb8bcfc393bb947740fc5e53a2023d2ad6

commit 2ed1cbcb8bcfc393bb947740fc5e53a2023d2ad6
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Apr 20 22:04:22 2018

Revert "vaapi: Don't use = {} to clear base::queues"

This reverts commit 83bd765601072b55ab31b8b23665a31578deca19.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 

Original change's description:
> vaapi: Don't use = {} to clear base::queues
>
> This CL removes the use of = {} to clear base::queues, because, for classes,
> zero initialization simply clears the (non-static) data members, which might
> leave the objects in an incorrect meta state because ctors are not called:
> this should not be an issue for std::queue, but it is for base::queue, which
> is implemented as a base::circular_deque.
>
> Nothing is crashing now, but a sibling unlanded sister CL (crrev.com/c/947341)
> had some issues with a similar idiom, so I'm removing it just in case.
>
> [1] http://en.cppreference.com/w/cpp/language/zero_initialization
>
> Bug: 717265
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: I96af3e6475c0596f3316219bd51732e085f5e098
> Reviewed-on: https://chromium-review.googlesource.com/1005917
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550162}

TBR=mcasas@chromium.org,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717265
Change-Id: I06bc48deafedb9badd0937f9a2efd37c318edf6d
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020001
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552124}(cherry picked from commit 4e1aa3d31b61440058b3f157622d963ec05a4e97)
Reviewed-on: https://chromium-review.googlesource.com/1022890
Cr-Commit-Position: refs/branch-heads/3396@{#177}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/2ed1cbcb8bcfc393bb947740fc5e53a2023d2ad6/media/gpu/vaapi/vaapi_video_decode_accelerator.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e822105d243cbe482aaec5a43356d68d812ea43

commit 4e822105d243cbe482aaec5a43356d68d812ea43
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Apr 20 22:06:32 2018

Revert "media/gpu/vaapi: Post DecodeTask() from ReusePictureBuffer()"

This reverts commit 7cf2167e0709987aff777468eb080133d0283f88.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 

Original change's description:
> media/gpu/vaapi: Post DecodeTask() from ReusePictureBuffer()
>
> DecodeTask() is posted from mainly QueueInputBuffer() or
> RecycleVASurfaceID() in most cases.
> Some DecodeTask() posted from QueueInputBuffer() do nothing since va
> surface is not available yet. It will be available after AssignPictureBuffers().
> If the first buffer contains information about coded size, DecodeTask() for the
> succeeding buffers are pended. In this case, DecodeTask() may be called twice;
> in QueueInputBuffer() and the other once in AssignPictureBuffers().
> If the third buffer is a dummy buffer queued by Flush(), the buffer is not
> popped in DecodeTask() and thus FlushTask() is not executed permanently.
> It can be a problem when a client expects the picture decoded from second buffer
> is returned, because decoding of the second buffer might be pending in driver.
> FlushTask() which can ask driver to decode the second buffer is not executed now
> due to the above reason.
> The following CTS tests behave similarly to the problem case.
> * android.media.cts.DecoderTest#testEOSBehaviorH264
> * android.media.cts.DecoderTest#testEOSBehaviorVP8"
> * android.media.cts.DecoderTest#testEOSBehaviorVP9"
>
> These CTS starts to fail from crrev.com/c/973684. In the CL, DecodeTask() was
> changed to not execute DecodeTask() to the succeeding buffers.
>
> This changes VDA as to post DecodeTask() from ReusePictureBuffer(), and the
> number of executing DecodeTask() is sufficient to get driver finish decoding
> storing picture buffers.
>
> BUG=b:77840176
> TEST=CtsMediaTestCases on eve
> TEST=VDA unittest
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/1006563
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Pawel Osciak <posciak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550155}

TBR=posciak@chromium.org,mcasas@chromium.org,hiroh@chromium.org,acourbot@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:77840176
Change-Id: I7b9c7049a8b050138bd5eb7d99ce8cd36af19e67
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020002
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552120}(cherry picked from commit 015a217b3fc3a34021e67726c05789c41a564e5a)
Reviewed-on: https://chromium-review.googlesource.com/1022892
Cr-Commit-Position: refs/branch-heads/3396@{#178}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/4e822105d243cbe482aaec5a43356d68d812ea43/media/gpu/vaapi/vaapi_video_decode_accelerator.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1fa9073428c71ee8f333b6c121c5a853d45402d

commit f1fa9073428c71ee8f333b6c121c5a853d45402d
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Apr 20 22:07:00 2018

Revert "vaapi: minor cleanups in VaVDA (OutputPicture, mostly)"

This reverts commit b4990829f33305ea94a6649771e331af97d3066d.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 


Original change's description:
> vaapi: minor cleanups in VaVDA (OutputPicture, mostly)
>
> This CL is a few cleanups to ease review of crrev.com/c/986353:
>
> - PictureById() is moved to the end of the cc file, following the
>  order of its declaration. Code untouched (except s/NULL/nullptr/).
>  A call to PictureById  is substituted with base::ContainsKey()
>  to better reflect intent.
>
> - OutputPicture() loses its last parameter, that is then calculated
>  on the spot (it's |available_picture_buffers_.front()|). This makes
>  OutputCB unnecessary, so it's made a Closure, and a OnceClosure at
>  that.
>
> Test: eve crosvideo vp9 cycling resolutions.
>
> Bug: 822346
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: Ie17f23f2fb20752463e9ebeacd1bf7a9b6150437
> Reviewed-on: https://chromium-review.googlesource.com/1000297
> Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549506}

TBR=mcasas@chromium.org,hoegsberg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 822346
Change-Id: If0d162b5373c33c266268d9cd82e3de5fd4e4a7e
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020003
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552146}(cherry picked from commit ba217eddda82e1781ee977c4ad5f4d26feb2bdda)
Reviewed-on: https://chromium-review.googlesource.com/1022634
Cr-Commit-Position: refs/branch-heads/3396@{#179}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/f1fa9073428c71ee8f333b6c121c5a853d45402d/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/f1fa9073428c71ee8f333b6c121c5a853d45402d/media/gpu/vaapi/vaapi_video_decode_accelerator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d71a5c09424d25b66c37735d08e85db2819383e7

commit d71a5c09424d25b66c37735d08e85db2819383e7
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Apr 20 22:07:35 2018

Revert "vaapi: add a log when running out available va surfaces, which causes decoding fail."

This reverts commit e9ea7ba41399d0a0e52f3a7e98a4b790e4e98569.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 


Original change's description:
> vaapi: add a log when running out available va surfaces, which causes decoding fail.
>
> There is GPU hang related to RTC decoding. I guess it's because there is not
> an available va surface. This CL will prove it.
>
> BUG=b/72676160
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: I4349d9b00f46c03210498e13d30636b752078980
> Reviewed-on: https://chromium-review.googlesource.com/999101
> Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
> Cr-Commit-Position: refs/heads/master@{#548917}

TBR=dongseong.hwang@intel.com,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/72676160
Change-Id: Ib5ba7e753aebd2bfc0c248664381d08659528467
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020004
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552134}(cherry picked from commit 4a4edbb5feac3fe4c3748175b8150726db3e4e18)
Reviewed-on: https://chromium-review.googlesource.com/1022910
Cr-Commit-Position: refs/branch-heads/3396@{#180}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/d71a5c09424d25b66c37735d08e85db2819383e7/media/gpu/vaapi/vaapi_video_decode_accelerator.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e77a576a01e4d3f7f7e4c69d892f8cf60c4c9440

commit e77a576a01e4d3f7f7e4c69d892f8cf60c4c9440
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Apr 20 22:07:59 2018

Revert "vaapi: cleanup a few comments and var names"

This reverts commit c813adf6312dda8d54aca42dd5dc4460248726ad.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek:  https://crbug.com/834146 
Bug:  834146 

Original change's description:
> vaapi: cleanup a few comments and var names
>
> This CL cleans up a few things that I realized while
> debugging other CLs in the area:
> - |available_va_surfaces_| is a std::list on ToT, but has
>  queue semantics, so it's changed int his CL.
> -  s/output_buffers_/available_va_surfaces_/ because that's
>  what they are.
> - s/TryOutputSurface/TryOutputPicture/ because that's what
>  the method does.
> - s/pictures_/picture_map_/ to better define what it is. After
>  dcastagna@ suggestion, it's made a base::small_map in PS7
>
> Comments updated throughout these variables.
>
> No change in behaviour intended, but tested nonetheless with
> vp8/9-h264 crosvideo playback.
>
> Bug: 822346
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: I2117ceac29f7d6ed23d698c4abd5c72e0140ae47
> Reviewed-on: https://chromium-review.googlesource.com/988512
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547552}

TBR=mcasas@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 822346
Change-Id: I7d242ad92a68596766f6cfe0ad2be37da3c4fb20
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020005
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552166}(cherry picked from commit 2edc7ca953140f70f5c5e79defda98511c9fa046)
Reviewed-on: https://chromium-review.googlesource.com/1022911
Cr-Commit-Position: refs/branch-heads/3396@{#181}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/e77a576a01e4d3f7f7e4c69d892f8cf60c4c9440/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/e77a576a01e4d3f7f7e4c69d892f8cf60c4c9440/media/gpu/vaapi/vaapi_video_decode_accelerator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2296de366e227d2bfa466159061ebbef6d309394

commit 2296de366e227d2bfa466159061ebbef6d309394
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Apr 20 22:08:30 2018

Revert "RELAND: Vaapi: Remove ConditionVariables and use PostTask"

This reverts commit 5eec367971c0b4d21328f4798ed304c240d89e72.

Reason for revert: Caused regression in video_VideoSeek:
 https://crbug.com/834146 
Bug:  834146 

Original change's description:
> RELAND: Vaapi: Remove ConditionVariables and use PostTask
>
> This CL relands the attached CL that got reverted due to scaling
> issues, i.e. when the decode bitstream changed resolution, there
> was the chance that before marking |awaiting_va_surfaces_recycle_|,
> we could get an "old" resolution frame, that would confuse |decoder_|.
>
> The solution is to move |awaiting_va_surfaces_recycle_| marking to
> DecodeTask(), and hold off any more Decode() operations until the
> "old" resolution frames are processed. This in turn makes
> InitiateSurfaceSetChange() superfluous, so it's moved into DecodeTask().
> The rest is comment update :-)
> ** Changes can be found here: crrev.com/c/973684/3..9
>
> TEST=http://crosvideo.appspot.com/?codec=vp9&cycle=true&loop=true&mute=true
> and letting it roll through many many many resolution changes.
>
> Original CL description ------------------------------------------------
>
> This CL removes the use of the ConditionVariables inside VaVDA and
> uses instead PostTask()ing. This removes blocking the worker
> thread, which allows for moving other tasks there, e.g. the
> Surface Blit (as done in the follow up WIP CL crrev.com/c/947341)
>
> For all that goodness, this CL:
>
> - Refactors the waiting logic that on ToT is spread between
>  GetCurrInputBuffer_Locked() and WaitForSurfaces_Locked() and
>  simplifies it in DecodeTask() itself.
>
> - Moves the |curr_input_buffer_| filling logic in
>  GetCurrInputBuffer_Locked() into DecodeTask() proper.
>
> - Reduces the scoped of the |lock_| in DecodeTask() (note that
>  |curr_input_buffer_| and |decode_| are only used on the decoder
>  thread -- added a .h comment).
>
> Minor stuff: This CL also moves together the declaration of the
> related member vars |input_buffers_|, |curr_input_buffer_| and
> |available_va_surfaces_|
>
> TEST=simplechrome+crosvideo (including seeks) on soraka, and
> v_d_a_unittest with h264, vp8, vp9 (with dcheck_always_on=true).
>
> Bug: 717265
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: I86d179ac4d48c63b36787f5c7bdcb0da3839ed69
> Reviewed-on: https://chromium-review.googlesource.com/949283
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#542955}
> Reviewed-on: https://chromium-review.googlesource.com/973684
> Cr-Commit-Position: refs/heads/master@{#546827}

TBR=posciak@chromium.org,mcasas@chromium.org,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717265
Change-Id: Ic31471daf757fd08ff2f420afc5be7e973a88c01
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020040
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552190}(cherry picked from commit a1b30a7a9f2fa342058b128c55c37c27a878f416)
Reviewed-on: https://chromium-review.googlesource.com/1022912
Cr-Commit-Position: refs/branch-heads/3396@{#182}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/2296de366e227d2bfa466159061ebbef6d309394/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/2296de366e227d2bfa466159061ebbef6d309394/media/gpu/vaapi/vaapi_video_decode_accelerator.h

Reverted all the fellas below on refs/branch-heads/3396, marking this
bug as Fixed, hiroh@ please verify in a few days, thanks!


Revert "RELAND: Vaapi: Remove ConditionVariables and use PostTask"
This reverts commit 5eec367971c0b4d21328f4798ed304c240d89e72.       546827  

Revert "vaapi: cleanup a few comments and var names"
This reverts commit c813adf6312dda8d54aca42dd5dc4460248726ad.       547552  

Revert "vaapi: add a log when running out available va surfaces, 
which causes decoding fail."
This reverts commit e9ea7ba41399d0a0e52f3a7e98a4b790e4e98569.       548917  

Revert "vaapi: minor cleanups in VaVDA (OutputPicture, mostly)"
This reverts commit b4990829f33305ea94a6649771e331af97d3066d.       549506  

Revert "media/gpu/vaapi: Post DecodeTask() from ReusePictureBuffer()"
This reverts commit 7cf2167e0709987aff777468eb080133d0283f88.       550155  

Revert "vaapi: Don't use = {} to clear base::queues"
This reverts commit 83bd765601072b55ab31b8b23665a31578deca19.       550162  


(Chromium branched at revision: 550428)

All the reverted CLs were landed on 10601.0.0 and 10575.10.0.
video_VideoSeek failures caused by these changes were gone.

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=video_VideoSeek&suite=&daysBack=30

The NextAction date has arrived: 2018-04-26