New issue
Advanced search Search tips

Issue 834143 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: Apr 2018
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fix new tab button hit test when window is maximized or fullscreen

Project Member Reported by afakhry@chromium.org, Apr 18 2018 
For Fitts' Law needs
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0666c337affc1730befe2489b45049266a31e78

commit c0666c337affc1730befe2489b45049266a31e78
Author: Ahmed Fakhry <afakhry@google.com>
Date: Thu Apr 19 00:01:08 2018

Fix the touchable new tab button Fitts' Law behavior

BUG= 834143 

Change-Id: I946b2761866549a5736d2ba01e4f58a9b2d1a03d
Reviewed-on: https://chromium-review.googlesource.com/1016166
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551886}
[modify] https://crrev.com/c0666c337affc1730befe2489b45049266a31e78/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/c0666c337affc1730befe2489b45049266a31e78/chrome/browser/ui/views/tabs/new_tab_button.h

Comment 2 by afakhry@chromium.org, Apr 19 2018

Labels: Merge-Request-67
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 20 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfc8b29c9dacbe55fab89eaa6d1a18d22c28819e

commit bfc8b29c9dacbe55fab89eaa6d1a18d22c28819e
Author: Ahmed Fakhry <afakhry@google.com>
Date: Fri Apr 20 18:00:32 2018

[Merge to M-67] Fix the touchable new tab button Fitts' Law behavior

TBR=pkasting@chromium.org
BUG= 834143 

(cherry picked from commit c0666c337affc1730befe2489b45049266a31e78)

Change-Id: I946b2761866549a5736d2ba01e4f58a9b2d1a03d
Reviewed-on: https://chromium-review.googlesource.com/1016166
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551886}
Reviewed-on: https://chromium-review.googlesource.com/1022231
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#167}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/bfc8b29c9dacbe55fab89eaa6d1a18d22c28819e/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/bfc8b29c9dacbe55fab89eaa6d1a18d22c28819e/chrome/browser/ui/views/tabs/new_tab_button.h

Comment 5 by afakhry@chromium.org, Apr 20 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment