Shouldn't this text just be (default text size + some constant size offset), and the bubble resize to match?

And shouldn't the size offset be similar across platforms?

All that adds up to saying: what does e.g. Windows do and how certain are you that the new behavior is not better than the old?

One line of thinking may be that it looks kinda like a tooltip, so should be consistent with the system treatment for those.

(Although tooltips on my Linux workstation are blurry/spidery white text on black multiline thingos, so I wouldn't go too far..)

Safari tooltips appear to be 11pt font.

The issue I'm running into is that in MacViews, the font size is determined by the system font and the system font's size appears to be changing during runtime.

In the current version (non-MacViews) the font size is determined by the current NSWindow's contentView.

Any suggestions on how to proceed are greatly appreciated.

StatusBubbleViews has multiple codepaths that just invoke gfx::FontList(), which results in 12pt (or 13pt in some locales on ChromeOS, or other-things-if-configured-by-the-user-on-Windows). I.e. it's just "default".

StatusBubbleViews should be explicit about what font size it wants, and request a font via views:style::GetFont(..).

All that's left is for a designer to tell us what size they want, which is this bug :). bettes@ says 11pt on Mac, so let's do that.

Note there's no 11pt font in the Harmony spec. There is `CONTEXT_DEPRECATED_SMALL` (don't use that). Adding a CONTEXT_STATUS_BUBBLE which gives a `size_delta = -1;` on Mac and `size_delta = 0;` everywhere else is the way I would fix this.

Okay, I'll get to work on that, thank you so much for your help!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c17f99f7c1d9567f0dfe9523752803dd2d3af0e

commit 6c17f99f7c1d9567f0dfe9523752803dd2d3af0e
Author: Tessa Nijssen <tnijssen@google.com>
Date: Fri Jun 08 18:49:42 2018

[MacViews] Status Bubble Font Size Fix

StatusBubbleViews now calls views::style::GetFont() instead of
gfx::FontList(). This allows the passing of a TextContext,
in this case CONTEXT_LABEL. When the context is passed on Mac,
the font returned has a default size of 12pt. This is more consistent
with Safari and other platforms.

Since the system font on Mac (without user changes) returns 13pt font,
this change now sets the StatusBubbleViews font size to 12pt on Mac.

On other platforms, the default font size was already 12pt, so this
change does not change the status bubble font size on non-Mac
platforms.

Bug:  834125 
Change-Id: Ic1a9c5f728228341f18ddb41e36ea1e51078f95a
Reviewed-on: https://chromium-review.googlesource.com/1079849
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565703}
[modify] https://crrev.com/6c17f99f7c1d9567f0dfe9523752803dd2d3af0e/chrome/browser/ui/views/status_bubble_views.cc

Tried verifying the fix on latest chrome version 69.0.3493.0 using Mac 10.13.1. As we couldn't perfectly distinguish the difference(except slight variation of the darkness in letters...) between the reported version and the version in which fix landed, could someone help us in verifying the fix. Attaching the screen shot showing the behaviour of both the versions for reference.

Thanks! 

Deleted: CL 834125.png 345 KB

	CL 834125.png 345 KB View Download