New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 834119 link

Starred by 3 users
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Jan 14
Cc:
tbansal@chromium.org
ksakamoto@chromium.org
█ kenjibaheux@chromium.org
toyoshim@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 879071


Sign in to add a comment

Experiment with giving higher priority to RTT from QUIC connections

Project Member Reported by tbansal@chromium.org, Apr 18 2018 
Currently, network quality estimator gives the same priority to RTT from TCP sockets and RTT from QUIC connections. However, on some connections that have TCP middleboxes, the TCP RTT may not be accurate. On such connections, RTT from QUIC connections is expected to be more accurate since it's end-to-end. 

 Issue 823322  is also related to this.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f884c105d91cd6b3def641d1e45c154b78f53c0

commit 3f884c105d91cd6b3def641d1e45c154b78f53c0
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Apr 23 19:02:00 2018

Remove obsolete code from network quality estimator

Remove code related to experimenting with different
statistical algorithms and ECT computing functions.
Those experiments have completed, and
there is no need to keep this code around.

Change-Id: I0016ba2fda758dae7f3952cc2b120645ef996638
Bug:  834119 
Reviewed-on: https://chromium-review.googlesource.com/1023275
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552780}
[modify] https://crrev.com/3f884c105d91cd6b3def641d1e45c154b78f53c0/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/3f884c105d91cd6b3def641d1e45c154b78f53c0/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/3f884c105d91cd6b3def641d1e45c154b78f53c0/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/3f884c105d91cd6b3def641d1e45c154b78f53c0/net/nqe/network_quality_estimator_params.h
[modify] https://crrev.com/3f884c105d91cd6b3def641d1e45c154b78f53c0/net/nqe/network_quality_estimator_params_unittest.cc
[modify] https://crrev.com/3f884c105d91cd6b3def641d1e45c154b78f53c0/net/nqe/network_quality_estimator_test_util.cc
[modify] https://crrev.com/3f884c105d91cd6b3def641d1e45c154b78f53c0/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/3f884c105d91cd6b3def641d1e45c154b78f53c0/net/nqe/network_quality_estimator_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92f0b09dd3807d6ddc033815ee8b00209e7c1354

commit 92f0b09dd3807d6ddc033815ee8b00209e7c1354
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue May 01 23:11:34 2018

Network Quality Estimator: Refactor of how observation buffers are stored

Store RTT observation buffers together in an array.
This makes it easier to combine various methods which will be
done in the next CL.

This CL does not change any functionality.

Change-Id: Iaa54895778b078640e6155f833d90903d733f391
Bug:  834119 
Reviewed-on: https://chromium-review.googlesource.com/1034391
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555219}
[modify] https://crrev.com/92f0b09dd3807d6ddc033815ee8b00209e7c1354/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/92f0b09dd3807d6ddc033815ee8b00209e7c1354/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/92f0b09dd3807d6ddc033815ee8b00209e7c1354/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/92f0b09dd3807d6ddc033815ee8b00209e7c1354/net/nqe/network_quality_observation.cc
[modify] https://crrev.com/92f0b09dd3807d6ddc033815ee8b00209e7c1354/net/nqe/network_quality_observation_source.h
[modify] https://crrev.com/92f0b09dd3807d6ddc033815ee8b00209e7c1354/net/nqe/observation_buffer.cc
[modify] https://crrev.com/92f0b09dd3807d6ddc033815ee8b00209e7c1354/net/nqe/observation_buffer.h
Project Member

Comment 3 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cacfa07a7854dfce9c0e1edcd2b6e8ddc9b906b8

commit cacfa07a7854dfce9c0e1edcd2b6e8ddc9b906b8
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon May 07 23:48:24 2018

NQE: Combine HTTP RTT and transport RTT related methods

This CL does not introduce any functionality change, but makes
it easier to add a new category of RTTs by combining similar
methods in Network Quality Estimator (NQE).

Bug:  834119 
Change-Id: I60623ad51733c9339168993cb8b10202c0a68adf
Reviewed-on: https://chromium-review.googlesource.com/1040913
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556612}
[modify] https://crrev.com/cacfa07a7854dfce9c0e1edcd2b6e8ddc9b906b8/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/cacfa07a7854dfce9c0e1edcd2b6e8ddc9b906b8/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/cacfa07a7854dfce9c0e1edcd2b6e8ddc9b906b8/net/nqe/network_quality_estimator_test_util.cc
[modify] https://crrev.com/cacfa07a7854dfce9c0e1edcd2b6e8ddc9b906b8/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/cacfa07a7854dfce9c0e1edcd2b6e8ddc9b906b8/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/cacfa07a7854dfce9c0e1edcd2b6e8ddc9b906b8/net/nqe/network_quality_provider.h
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f00e42eab4e14c0d941f99d7ec5245dee730554e

commit f00e42eab4e14c0d941f99d7ec5245dee730554e
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed May 16 02:48:51 2018

NQE: Compute and record end-to-end RTT.

Record end-to-end RTT in a separate histogram in
network quality estimator. Right now, this only
includes the RTT from QUIC connections.

Long term plan is to use end-to-end RTT measurements
to adjust the HTTP RTT estimates.

Change-Id: Ie51ab8cc774c71ec82218d9c617fb34a4efe718a
Bug:  834119 
Reviewed-on: https://chromium-review.googlesource.com/1034281
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558938}
[modify] https://crrev.com/f00e42eab4e14c0d941f99d7ec5245dee730554e/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/f00e42eab4e14c0d941f99d7ec5245dee730554e/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/f00e42eab4e14c0d941f99d7ec5245dee730554e/net/nqe/network_quality_estimator_test_util.cc
[modify] https://crrev.com/f00e42eab4e14c0d941f99d7ec5245dee730554e/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/f00e42eab4e14c0d941f99d7ec5245dee730554e/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/f00e42eab4e14c0d941f99d7ec5245dee730554e/net/nqe/network_quality_observation.cc
[modify] https://crrev.com/f00e42eab4e14c0d941f99d7ec5245dee730554e/net/nqe/network_quality_observation.h
[modify] https://crrev.com/f00e42eab4e14c0d941f99d7ec5245dee730554e/net/nqe/network_quality_observation_source.h
[modify] https://crrev.com/f00e42eab4e14c0d941f99d7ec5245dee730554e/tools/metrics/histograms/histograms.xml

Comment 5 by bengr@chromium.org, Jun 22 2018

Labels: -Pri-3 M-70 Pri-2
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdc86986500a2777a9cb4ea454003b823a1c3a46

commit bdc86986500a2777a9cb4ea454003b823a1c3a46
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Jul 17 21:05:23 2018

Record count of end to end RTT observations

This will be used in a subsequent CL to change the HTTP RTT
estimate of the count of end to end RTT observations is more than
a certain threshold.

Change-Id: I4268568e2c7df0c45651fdecb19ba59925430565
Bug:  834119 
Reviewed-on: https://chromium-review.googlesource.com/1117771
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575770}
[modify] https://crrev.com/bdc86986500a2777a9cb4ea454003b823a1c3a46/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/bdc86986500a2777a9cb4ea454003b823a1c3a46/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/bdc86986500a2777a9cb4ea454003b823a1c3a46/net/nqe/network_quality_estimator_test_util.cc
[modify] https://crrev.com/bdc86986500a2777a9cb4ea454003b823a1c3a46/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/bdc86986500a2777a9cb4ea454003b823a1c3a46/net/nqe/network_quality_estimator_unittest.cc

Comment 8 by tbansal@chromium.org, Aug 30

Cc: ksakamoto@chromium.org kenjibaheux@chromium.org toyoshim@chromium.org tbansal@chromium.org
 Issue 871698  has been merged into this issue.

Comment 9 by tbansal@chromium.org, Sep 6

Blockedon: 879071
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc2bace4e5d7d1b6fc5593de351bba9ec9f5596

commit 7fc2bace4e5d7d1b6fc5593de351bba9ec9f5596
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Oct 15 19:48:05 2018

Network Quality Estimator: Use end to end rtt to clamp HTTP RTT

Use the end to end RTT provided by QUIC connections to clamp the
upper bound on HTTP RTT.

In some cases, network quality estimator may not detect hanging
XHR requests, and use the RTT samples from such requests when
computing the HTTP RTT estimate. Using end-to-end
RTT to clamp HTTP RTT helps in improving the accuracy of HTTP RTT
estimate in such cases.

Change-Id: I0c2b60eb73b35408c4d32d38ffffc29f6d3e0ce1
Bug:  834119 
Reviewed-on: https://chromium-review.googlesource.com/c/1279435
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599720}
[modify] https://crrev.com/7fc2bace4e5d7d1b6fc5593de351bba9ec9f5596/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/7fc2bace4e5d7d1b6fc5593de351bba9ec9f5596/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/7fc2bace4e5d7d1b6fc5593de351bba9ec9f5596/net/nqe/network_quality_estimator_params.h
[modify] https://crrev.com/7fc2bace4e5d7d1b6fc5593de351bba9ec9f5596/net/nqe/network_quality_estimator_unittest.cc

Comment 11 by bengr@chromium.org, Dec 5 

tbansal: What's the status of this issue?

Comment 12 by tbansal@chromium.org, Dec 5 

Experiment is configured to run at ~15% in M-71 stable. M-71 goes to stable this week. So, I will start getting some data soon.
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/749feb11c36ef8da21f3db4d8de9ac3eb4d69c7d

commit 749feb11c36ef8da21f3db4d8de9ac3eb4d69c7d
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Jan 09 02:42:43 2019

NQE: Enable experiment to use end-to-end RTT and signal strength

In network quality estimator, enable the experiment to use
end-to-end RTT to adjust RTT value.
Also, enable the experiment to use the signal strength when
computing RTT sample weights.

Change-Id: I6d59c2a40555af16765c2caa1ffad53e2e53cdcd
Bug:  513681 , 834119 
Reviewed-on: https://chromium-review.googlesource.com/c/1397430
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621012}
[modify] https://crrev.com/749feb11c36ef8da21f3db4d8de9ac3eb4d69c7d/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/749feb11c36ef8da21f3db4d8de9ac3eb4d69c7d/testing/variations/fieldtrial_testing_config.json

Comment 14 by tbansal@chromium.org, Jan 14

Status: Fixed (was: Started)
►

Sign in to add a comment