No way to publish draft comments on review from command line |
|||
Issue descriptionIt's a common workflow for me to respond to comments on a review with 'Done' as I work through them, and then with a flourish upload my CL in a one-liner with 'git cl upload -t fixes' but I always then have to go to the review in my browser, refresh it, and THEN hit 'Reply' to publish my responses. I was hoping that the --send-mail (-s) option, ie. git cl upload -s would publish the draft responses so I didn't need the extra steps.
,
Nov 22
If you _always_ want to do this you can set it as a personal preference in Gerrit: https://gerrit-review.googlesource.com/Documentation/intro-user.html#publish-comments-on-push To conditionally support it we'd need to add a flag to git cl, but the option is already supported in Gerrit: https://gerrit-review.googlesource.com/Documentation/user-upload.html#publish-comments I really thought this was possible, because we have other developers filing bugs around not great things happening when comments are getting published on patchset upload. But I don't see it in the source code. Maybe Andrii knows how to do this today. For now treating this a feature request for git cl.
,
Nov 27
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sergeybe...@chromium.org
, Apr 18 2018