When crostini is enabled and container exists, then show new root in FilesApp named 'Linux apps' Icon in http://crbug.com/820616
When user clicks, start crostini container if required and do sftp mount.
I'm happy to help with this if needed :) I added some notes a while ago on how to mount new directories in the Files app: https://g3doc.corp.google.com/company/teams/chromeos-filesystem/g3doc/code-docs/mounting.md?cl=head You want to mount it on the C++ side, then you can set the icon/etc on the UI side. All the filesystem accesses are done through the FileManagerPrivate API.
Clarification that the label will be 'Linux Files' (not 'Linux apps' as per #c1)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ab36feb0d228e6893e2403b5b91fd3d852970aa commit 0ab36feb0d228e6893e2403b5b91fd3d852970aa Author: Joel Hockey <joelhockey@chromium.org> Date: Thu May 03 00:09:32 2018 Add flag to enable Crostini Files in Files app Bug: 834103 Change-Id: Ib4fd72617f0648e99de0f6f84c03b1b65498e978 Reviewed-on: https://chromium-review.googlesource.com/1039109 Reviewed-by: Sasha Morrissey <sashab@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#555619} [modify] https://crrev.com/0ab36feb0d228e6893e2403b5b91fd3d852970aa/chrome/browser/about_flags.cc [modify] https://crrev.com/0ab36feb0d228e6893e2403b5b91fd3d852970aa/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/0ab36feb0d228e6893e2403b5b91fd3d852970aa/chrome/browser/flag_descriptions.h [modify] https://crrev.com/0ab36feb0d228e6893e2403b5b91fd3d852970aa/chromeos/chromeos_switches.cc [modify] https://crrev.com/0ab36feb0d228e6893e2403b5b91fd3d852970aa/chromeos/chromeos_switches.h [modify] https://crrev.com/0ab36feb0d228e6893e2403b5b91fd3d852970aa/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82e98b03cf9c2a53335cd1109fa72bdd0d3436f5 commit 82e98b03cf9c2a53335cd1109fa72bdd0d3436f5 Author: Joel Hockey <joelhockey@chromium.org> Date: Thu May 03 01:38:16 2018 Refactor ordering of NavigationListModel items Replace the logic in NavigationListModel.prototype.item and NavigationListModel.prototype.length_ to instead calculate the order and preserve it in an array in reorderNavigationItems_. This makes the ordering rules clearer and should also give faster performance for the more frequently accessed item function. Update tests to include recent. This change in done in advance of adding crostini Linux Files. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I08c3222b4317b0d38524c52e320545d6717ef9b0 Reviewed-on: https://chromium-review.googlesource.com/1039207 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#555649} [modify] https://crrev.com/82e98b03cf9c2a53335cd1109fa72bdd0d3436f5/ui/file_manager/file_manager/foreground/js/file_manager.js [modify] https://crrev.com/82e98b03cf9c2a53335cd1109fa72bdd0d3436f5/ui/file_manager/file_manager/foreground/js/navigation_list_model.js [modify] https://crrev.com/82e98b03cf9c2a53335cd1109fa72bdd0d3436f5/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
Design doc: https://docs.google.com/document/d/1vZPG4iOq2HHdqL9a98QBAModHVDS7etHmnNrD58huUg/edit
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37fa72b0eeeaa0504fc8fb7851307e96f5206b22 commit 37fa72b0eeeaa0504fc8fb7851307e96f5206b22 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed May 09 05:34:52 2018 CrOS FilesApp integrate with crostini * New fileManagerPrivate APIs: - isCrostiniEnabled: returns true if device supports crostini and termina/penguin container exists. This function is controlled by flag 'crostini-files'. - mountCrostiniContainer: starts and mounts container. * Created new root type NavigationModelSFTPMountItem which uses a FakeEntry, similar to 'Recent', to show the 'Linux Files' root. * Click handler for Linux Files will start and mount crostini container. * Code in NavigationModel to order roots detects when mounted volumes already contains an FSP-provided mount for fileSystemId='crostini'. In this case, the fake root is left out and the real volume should be in the same position. * Error handling code for SFTP mount/disconnect to be implemented when sshfs is available. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8a3bec948871dc9671ea513d7378035d89d565eb Reviewed-on: https://chromium-review.googlesource.com/1025545 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#557104} [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/chrome/common/extensions/api/file_manager_private.idl [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/third_party/closure_compiler/externs/file_manager_private.js [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/tools/metrics/histograms/enums.xml [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/background/js/background.js [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/common/js/volume_manager_common.js [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/foreground/css/file_types.css [add] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/foreground/images/volumes/2x/linux_files.png [add] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/foreground/images/volumes/2x/linux_files_active.png [add] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/foreground/images/volumes/linux_files.png [add] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/foreground/images/volumes/linux_files_active.png [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/foreground/js/directory_model.js [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/foreground/js/navigation_list_model.js [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js [modify] https://crrev.com/37fa72b0eeeaa0504fc8fb7851307e96f5206b22/ui/file_manager/file_manager/test/js/strings.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7f84ea0d3735ca90820b8b89efd2931c57d64ec commit f7f84ea0d3735ca90820b8b89efd2931c57d64ec Author: Joel Hockey <joelhockey@chromium.org> Date: Thu May 10 02:26:45 2018 FilesApp calling RestartCrostini Implement fileManagerPrivate.mountCrostiniContainer to call Crostini Restart. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7a6326e0faa92c48cd1014ce426b1a19f0b35d0d Reviewed-on: https://chromium-review.googlesource.com/1049988 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#557430} [modify] https://crrev.com/f7f84ea0d3735ca90820b8b89efd2931c57d64ec/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc [modify] https://crrev.com/f7f84ea0d3735ca90820b8b89efd2931c57d64ec/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h [modify] https://crrev.com/f7f84ea0d3735ca90820b8b89efd2931c57d64ec/chrome/common/extensions/api/file_manager_private.idl [modify] https://crrev.com/f7f84ea0d3735ca90820b8b89efd2931c57d64ec/third_party/closure_compiler/externs/file_manager_private.js [modify] https://crrev.com/f7f84ea0d3735ca90820b8b89efd2931c57d64ec/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/386046ea4b9dcf674ac8912496df9f6e994e26d0 commit 386046ea4b9dcf674ac8912496df9f6e994e26d0 Author: Joel Hockey <joelhockey@chromium.org> Date: Mon May 14 20:12:06 2018 FilesApp use lastError in mountCrostiniContainer Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4825a67e3716cca47c09b1510180c61079445dbd Reviewed-on: https://chromium-review.googlesource.com/1056931 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558431} [modify] https://crrev.com/386046ea4b9dcf674ac8912496df9f6e994e26d0/chrome/common/extensions/api/file_manager_private.idl [modify] https://crrev.com/386046ea4b9dcf674ac8912496df9f6e994e26d0/third_party/closure_compiler/externs/file_manager_private.js [modify] https://crrev.com/386046ea4b9dcf674ac8912496df9f6e994e26d0/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a5171b48211a7edcaaf82915da026ef6ff38f86 commit 4a5171b48211a7edcaaf82915da026ef6ff38f86 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue May 15 00:48:09 2018 Fix JS style error for var name Bug: 834103 Tbr: fukino@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I631cdeb7ab48743424356a64222a4d2276714b1b Reviewed-on: https://chromium-review.googlesource.com/1058727 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558556} [modify] https://crrev.com/4a5171b48211a7edcaaf82915da026ef6ff38f86/ui/file_manager/file_manager/background/js/volume_manager_impl.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9 commit 3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue May 15 02:06:37 2018 New crostini volume type in VolumeManager Added new volume type for crostini, and new VolumeManager::AddCrostiniVolume API. Network volumes such as sshfs used by crostini will need to register specifically with VolumeManager. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id47fcb8850c9dee8e76b6c2881880a86b39b0a2b Reviewed-on: https://chromium-review.googlesource.com/1056968 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#558583} [modify] https://crrev.com/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc [modify] https://crrev.com/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9/chrome/browser/chromeos/file_manager/volume_manager.cc [modify] https://crrev.com/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9/chrome/browser/chromeos/file_manager/volume_manager.h [modify] https://crrev.com/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9/chrome/common/extensions/api/file_manager_private.idl [modify] https://crrev.com/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9/tools/metrics/histograms/enums.xml [modify] https://crrev.com/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9/ui/file_manager/file_manager/background/js/volume_info_list_impl.js [modify] https://crrev.com/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9/ui/file_manager/file_manager/background/js/volume_manager_impl.js [modify] https://crrev.com/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9/ui/file_manager/file_manager/common/js/util.js [modify] https://crrev.com/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9/ui/file_manager/file_manager/common/js/volume_manager_common.js [modify] https://crrev.com/3428fd63fcb9167c5a88a9a6bbc245d2f6e085e9/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/195b6482075ea59cfcb136450693a145152b67ba commit 195b6482075ea59cfcb136450693a145152b67ba Author: Joel Hockey <joelhockey@chromium.org> Date: Tue May 15 10:55:58 2018 FilesApp add fileManagerPrivate crostini functions for test.html Add fileManagerPrivate.isCrostiniEnabled and fileManagerPrivate.mountCrostiniContainer. Add paper-progress polymer lib to test.html. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If90e8005100286229219a9771b488722b0f14275 Reviewed-on: https://chromium-review.googlesource.com/1059098 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558658} [modify] https://crrev.com/195b6482075ea59cfcb136450693a145152b67ba/ui/file_manager/file_manager/test/js/chrome_file_manager.js [modify] https://crrev.com/195b6482075ea59cfcb136450693a145152b67ba/ui/file_manager/file_manager/test/scripts/create_test_main.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4ce38eb18ace2d293853ca61d423391ec32e181 commit c4ce38eb18ace2d293853ca61d423391ec32e181 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue May 15 11:49:43 2018 FilesApp set crostini Linux Files root from fileManager Set NavigationListModel.linuxFilesItems async from FileManager to allow directoryTree redraw which is required to show the item when FilesApp first launches. Remove specialized SFTPMountItem class and combine Recent and Linux Files to use NavigationModelFakeItem and DirectoryTree/FakeItem. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie840c8826368df5c63b608dcc5be59601f6452cb Reviewed-on: https://chromium-review.googlesource.com/1059368 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558665} [modify] https://crrev.com/c4ce38eb18ace2d293853ca61d423391ec32e181/ui/file_manager/file_manager/foreground/css/file_types.css [modify] https://crrev.com/c4ce38eb18ace2d293853ca61d423391ec32e181/ui/file_manager/file_manager/foreground/js/file_manager.js [modify] https://crrev.com/c4ce38eb18ace2d293853ca61d423391ec32e181/ui/file_manager/file_manager/foreground/js/navigation_list_model.js [modify] https://crrev.com/c4ce38eb18ace2d293853ca61d423391ec32e181/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js [modify] https://crrev.com/c4ce38eb18ace2d293853ca61d423391ec32e181/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ff2f680665353d5e14053df31b4082327a18b10 commit 5ff2f680665353d5e14053df31b4082327a18b10 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue May 15 12:20:17 2018 FilesApp add CrostiniMounter ContentScanner Add a new ContentScanner class for crostini that shows an empty directory and spinner whilst starting and mounting the crostini container. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5dd83c7db3783fff2d0298234d16bb00478ba3d8 Reviewed-on: https://chromium-review.googlesource.com/1059427 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558669} [modify] https://crrev.com/5ff2f680665353d5e14053df31b4082327a18b10/ui/file_manager/file_manager/foreground/js/directory_contents.js [modify] https://crrev.com/5ff2f680665353d5e14053df31b4082327a18b10/ui/file_manager/file_manager/foreground/js/directory_model.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13d5d22e1de20440be6a9a30be94262fafeea5a1 commit 13d5d22e1de20440be6a9a30be94262fafeea5a1 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue May 15 12:57:47 2018 FilesApp Crostini mounting as a Disk volume rather than FSP Update FilesApp to expect crostini to mount with sshfs and show up as a disk volume rather than using sftp and mounting using the File System Provider API. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iede287504e2d6af50fc60d1c175c21360b3d0882 Reviewed-on: https://chromium-review.googlesource.com/1059494 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558678} [modify] https://crrev.com/13d5d22e1de20440be6a9a30be94262fafeea5a1/ui/file_manager/file_manager/background/js/background.js [modify] https://crrev.com/13d5d22e1de20440be6a9a30be94262fafeea5a1/ui/file_manager/file_manager/background/js/volume_manager_util.js [modify] https://crrev.com/13d5d22e1de20440be6a9a30be94262fafeea5a1/ui/file_manager/file_manager/common/js/volume_manager_common.js [modify] https://crrev.com/13d5d22e1de20440be6a9a30be94262fafeea5a1/ui/file_manager/file_manager/foreground/js/directory_model.js [modify] https://crrev.com/13d5d22e1de20440be6a9a30be94262fafeea5a1/ui/file_manager/file_manager/foreground/js/navigation_list_model.js [modify] https://crrev.com/13d5d22e1de20440be6a9a30be94262fafeea5a1/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/218b72e7226a1b9f6c34503d9b986aef38841fc5 commit 218b72e7226a1b9f6c34503d9b986aef38841fc5 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue May 15 13:00:50 2018 FilesApp add description for CrostiniMounter Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If3bb0d2604f9778ebb3cf3bdbb799e234755472d Reviewed-on: https://chromium-review.googlesource.com/1059533 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558679} [modify] https://crrev.com/218b72e7226a1b9f6c34503d9b986aef38841fc5/ui/file_manager/file_manager/foreground/js/directory_contents.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f02933ae62620d7c0bfdff727e19a89a8639b35 commit 5f02933ae62620d7c0bfdff727e19a89a8639b35 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue May 15 13:35:35 2018 FilesApp fix calls to NavigationModelFakeItem to set type Bug: 834103 Tbr: noel@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If1e8186e560ef53674fe1a2a5c1bc05d443aac7d Reviewed-on: https://chromium-review.googlesource.com/1059633 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558686} [modify] https://crrev.com/5f02933ae62620d7c0bfdff727e19a89a8639b35/ui/file_manager/file_manager/foreground/js/file_manager.js [modify] https://crrev.com/5f02933ae62620d7c0bfdff727e19a89a8639b35/ui/file_manager/file_manager/foreground/js/navigation_list_model.js [modify] https://crrev.com/5f02933ae62620d7c0bfdff727e19a89a8639b35/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddbe97c36f7f953e101a4fe6e10df1451e0ef888 commit ddbe97c36f7f953e101a4fe6e10df1451e0ef888 Author: Joel Hockey <joelhockey@chromium.org> Date: Fri May 18 05:45:10 2018 FilesApp crostini show error alert on failed connection * Updated util.DOMError to take optional message field to match real DOMError. * Fixed all scan error related functions to take and pass on DOMError. The errorCallback already expects this field, however it was not being read or passed along. * Changed DirectoryModel.scan to not do a rescan for crostini connection failure. If the first attempt to start and mount the crostini container fails, there is no benefit to attempting this again. * EmptyFolderController updated to listen for scan-fail event and also look at the attached DOMError object. For crostini connection error, it will display an alert with the appropriate title and included DOMError.message. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5f431bd8c62220007cfbdc9d34efb0fb3fc8ae65 Reviewed-on: https://chromium-review.googlesource.com/1063048 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#559809} [modify] https://crrev.com/ddbe97c36f7f953e101a4fe6e10df1451e0ef888/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/ddbe97c36f7f953e101a4fe6e10df1451e0ef888/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/ddbe97c36f7f953e101a4fe6e10df1451e0ef888/ui/file_manager/file_manager/common/js/util.js [modify] https://crrev.com/ddbe97c36f7f953e101a4fe6e10df1451e0ef888/ui/file_manager/file_manager/foreground/js/directory_contents.js [modify] https://crrev.com/ddbe97c36f7f953e101a4fe6e10df1451e0ef888/ui/file_manager/file_manager/foreground/js/directory_model.js [modify] https://crrev.com/ddbe97c36f7f953e101a4fe6e10df1451e0ef888/ui/file_manager/file_manager/foreground/js/empty_folder_controller.js [modify] https://crrev.com/ddbe97c36f7f953e101a4fe6e10df1451e0ef888/ui/file_manager/file_manager/foreground/js/file_manager.js [modify] https://crrev.com/ddbe97c36f7f953e101a4fe6e10df1451e0ef888/ui/file_manager/file_manager/test/js/strings.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/849db4e602539fa048d76266c5a7823f9d8c8208 commit 849db4e602539fa048d76266c5a7823f9d8c8208 Author: Joel Hockey <joelhockey@chromium.org> Date: Fri May 18 10:00:06 2018 FilesApp mountCrostiniContainer add GetSshKeys, MountPath * Add call to CrostiniManager::GetSshKeys to obtain the keys required for sshfs. * Add call to DiskMountManager::MountPath to invoke sshfs * Listen for cros-disks mount event and then call to ExternalMountPoints::RegisterFileSystem and add the volume to file_manager::VolumeManager. The mount will then show up in FilesApp as a disk volume. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6493fce7b469f675c041f1793d5dec9c0e654679 Reviewed-on: https://chromium-review.googlesource.com/1051425 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#559850} [modify] https://crrev.com/849db4e602539fa048d76266c5a7823f9d8c8208/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc [modify] https://crrev.com/849db4e602539fa048d76266c5a7823f9d8c8208/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de423d752596787a9b1b832bf942c1c7b556dfe2 commit de423d752596787a9b1b832bf942c1c7b556dfe2 Author: Joel Hockey <joelhockey@chromium.org> Date: Thu May 24 06:04:41 2018 FilesApp remove crostini-files flag FilesApp will only show crostini integration when features::kExperimentalCrostiniUI is enabled. There is no need for a dedicated crostini-files flag. Bug: 834103 Change-Id: I019f56abe6348b6723c0de9b86425d05b0fe22f4 Reviewed-on: https://chromium-review.googlesource.com/1068584 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#561394} [modify] https://crrev.com/de423d752596787a9b1b832bf942c1c7b556dfe2/chrome/browser/about_flags.cc [modify] https://crrev.com/de423d752596787a9b1b832bf942c1c7b556dfe2/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc [modify] https://crrev.com/de423d752596787a9b1b832bf942c1c7b556dfe2/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/de423d752596787a9b1b832bf942c1c7b556dfe2/chrome/browser/flag_descriptions.h [modify] https://crrev.com/de423d752596787a9b1b832bf942c1c7b556dfe2/chromeos/chromeos_switches.cc [modify] https://crrev.com/de423d752596787a9b1b832bf942c1c7b556dfe2/chromeos/chromeos_switches.h [modify] https://crrev.com/de423d752596787a9b1b832bf942c1c7b556dfe2/tools/metrics/histograms/enums.xml
Comment 1 by joelhockey@chromium.org
, Apr 18 2018