New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834094 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[Omnibox] Win and CrOS regression in Omnibox.CharTypedToRepaintLatency and .ToPaint in 67.0.3363.0

Project Member Reported by dschuyler@chromium.org, Apr 17 2018

Issue description

Status: Fixed (was: Started)
CL at https://chromium-review.googlesource.com/c/chromium/src/+/1014412
Context (summarized from bug 76626474, so that this bug makes more sense on its own)

My CL at https://chromium-review.googlesource.com/c/chromium/src/+/938493 is suspected of introducing a regression in the Omnibox.CharTypedToRepaintLatency and .ToPaint stats (performance metrics).

My change didn't port (i.e. had removed) a short-circuit for single-line non-wrapping results (which are common). The fix mentioned in #1 restores the short-cut.
Cc: skare@chromium.org
dschuyler@,
I just noticed from alerts that it appear this change was never merged in M-67.  M-67 beta is still notably worse than M-66 beta.  I believe merging was the intent--hence the comment on the code review: "Added  bug 834094  (because A bug is needed to merge)".

I also imagine the follow-up change "yep, and Dave landed another change to reduce the number of string calls" mentioned in http://b/76626474#comment30 was not merged either.

Can you please attempt to get both of these merged?  Sorry I didn't catch this earlier.

thanks,
mark

Labels: Merge-Request-67 OS-Linux
Project Member

Comment 5 by sheriffbot@chromium.org, May 15 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: mpear...@chromium.org

Comment 7 by gov...@chromium.org, May 15 2018

Before we approve merge to M67, please answer followings:
* Is this M67 regression? Is it critical?
* Is this feature behind finch and can be easily disabled if something goes wrong?
* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M67?
* Any other important details to justify the merge.

Please note M67 is already in Beta, so merge bar is very high. Thank you.
Cc: jdonnelly@chromium.org
Omnibox TL here. We (omnibox team) investigated further and agreed that the effect of this merge is very important for omnibox performance. Further, the change is very small, targeted, low-risk and has been baked into Canary and under heavy use since. We would like to proceed with the merge.

Please let me know if you have any further questions.

Comment 9 by gov...@chromium.org, May 17 2018

Labels: -Merge-Review-67 Merge-Approved-67
Thank you  jdonnelly@ and omnibox team.

Approving merge to M67 branch 3396 based on comment #8. Please merge ASAP.
Thank you dschuyler@.

Pls remove "Merge-Approved-67" label and apply "Merge-merged-3396" label if nothing else is pending for M67.
Labels: -Merge-Approved-67 merge-merged-3396

Sign in to add a comment