[Omnibox] Win and CrOS regression in Omnibox.CharTypedToRepaintLatency and .ToPaint in 67.0.3363.0 |
||||||||
Issue description
,
Apr 17 2018
Context (summarized from bug 76626474, so that this bug makes more sense on its own) My CL at https://chromium-review.googlesource.com/c/chromium/src/+/938493 is suspected of introducing a regression in the Omnibox.CharTypedToRepaintLatency and .ToPaint stats (performance metrics). My change didn't port (i.e. had removed) a short-circuit for single-line non-wrapping results (which are common). The fix mentioned in #1 restores the short-cut.
,
May 15 2018
dschuyler@, I just noticed from alerts that it appear this change was never merged in M-67. M-67 beta is still notably worse than M-66 beta. I believe merging was the intent--hence the comment on the code review: "Added bug 834094 (because A bug is needed to merge)". I also imagine the follow-up change "yep, and Dave landed another change to reduce the number of string calls" mentioned in http://b/76626474#comment30 was not merged either. Can you please attempt to get both of these merged? Sorry I didn't catch this earlier. thanks, mark
,
May 15 2018
,
May 15 2018
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2018
,
May 15 2018
Before we approve merge to M67, please answer followings: * Is this M67 regression? Is it critical? * Is this feature behind finch and can be easily disabled if something goes wrong? * Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M67? * Any other important details to justify the merge. Please note M67 is already in Beta, so merge bar is very high. Thank you.
,
May 17 2018
Omnibox TL here. We (omnibox team) investigated further and agreed that the effect of this merge is very important for omnibox performance. Further, the change is very small, targeted, low-risk and has been baked into Canary and under heavy use since. We would like to proceed with the merge. Please let me know if you have any further questions.
,
May 17 2018
Thank you jdonnelly@ and omnibox team. Approving merge to M67 branch 3396 based on comment #8. Please merge ASAP.
,
May 18 2018
Cherry pick done in https://chromium-review.googlesource.com/c/chromium/src/+/1066870
,
May 18 2018
Thank you dschuyler@. Pls remove "Merge-Approved-67" label and apply "Merge-merged-3396" label if nothing else is pending for M67.
,
May 18 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dschuyler@chromium.org
, Apr 17 2018