New issue
Advanced search Search tips

Issue 834092 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Device sign out happens with just one time key press using 'ctrl+shift+q' shortcut keys

Project Member Reported by mkarkada@chromium.org, Apr 17 2018

Issue description

Chrome OS version: 10575.4.0, 67.0.3396.8 dev channel eve, nautilus

Steps to repro:
1. Login to the device
2. Sign out of the device by pressing shortcut keys 'ctrl+shift+q' only once
3. You may try signing in back and sign out again using shortcut keys once.

Actual behavior?
Able to sign out of the device by pressing shortcut keys 'ctrl+shift+q' only once

Actual behavior?
Should be able to sign out of the device by pressing shortcut keys twice and not by one time press.

This is a bug regression as this behavior is not seen on (10539.0.0, 67.0.3383.0)
 
Sorry, typo in bug description, it should be:
"
Expected behavior?
Should be able to sign out of the device by pressing shortcut keys twice and not by one time press.
"
Cc: r...@chromium.org
Components: UI>Shell>StartScreen
Labels: ReleaseBlock-Beta
Reprod on EVE TOT 10592.0.0 / 68.0.3397.0 build

Comment 5 by r...@chromium.org, Apr 18 2018

Components: -UI>Shell>StartScreen -UI>SignIn
This seems to be purely a keyboard issue.
Is  crbug/835610 a DUP?

Can we get this triaged / escalated as a RBB?  Along with board scope?

Comment 7 by warx@chromium.org, Apr 23 2018

Cc: est...@chromium.org afakhry@chromium.org jamescook@chromium.org
 Issue 835610  has been merged into this issue.

Comment 8 by warx@chromium.org, Apr 23 2018

Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
It's probably related to the cleanup of IDC_EXIT.

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5883ad596711781d9d04e26b97421a06e95956bd

commit 5883ad596711781d9d04e26b97421a06e95956bd
Author: Evan Stade <estade@chromium.org>
Date: Wed Apr 25 17:13:45 2018

[Chrome OS] Revert recent changes to IDC_EXIT accelerator handling.

In db110f78b92a0f802b0c90e55555dd9120a35a07, IDC_EXIT was changed to be
handled by Chrome instead of Ash. This reverts that change.

Originally, I thought Chrome would have to register the IDC_EXIT command
so that menus would show that shortcut in the relevant row. However,
the Exit command isn't shown in the Chrome OS app menu so it should be
fine to skip registering it completely and let Ash handle it.

Also verified that ctrl+shift+q is still treated as reserved, i.e. cannot
be eaten by a webpage. This site is useful for manually testing that:
  http://unixpapa.com/js/testkey.html


Bug:  834092 
Change-Id: Ie6de31a0efa36da0f67def3ba7a5124b6c527bd3
Reviewed-on: https://chromium-review.googlesource.com/1024876
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553613}
[modify] https://crrev.com/5883ad596711781d9d04e26b97421a06e95956bd/chrome/browser/browser_shutdown_browsertest.cc
[modify] https://crrev.com/5883ad596711781d9d04e26b97421a06e95956bd/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc
[modify] https://crrev.com/5883ad596711781d9d04e26b97421a06e95956bd/chrome/browser/ui/views/accelerator_table.cc
[modify] https://crrev.com/5883ad596711781d9d04e26b97421a06e95956bd/chrome/browser/ui/views/accelerator_table_unittest.cc

Labels: Merge-Request-67
Labels: -Merge-Request-67 Merge-Approved-67
Confirmed with estade@ that this was tested on ToT and low risk as a revert.

Approving merge to M67 Chrome OS.

Please get the merge in today so we can keep going for Beta.  Thanks :-)
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/968ccfdbce5cba09f0e30ad888461b527558f177

commit 968ccfdbce5cba09f0e30ad888461b527558f177
Author: Evan Stade <estade@chromium.org>
Date: Wed Apr 25 20:30:37 2018

[Chrome OS] Revert recent changes to IDC_EXIT accelerator handling.

In db110f78b92a0f802b0c90e55555dd9120a35a07, IDC_EXIT was changed to be
handled by Chrome instead of Ash. This reverts that change.

Originally, I thought Chrome would have to register the IDC_EXIT command
so that menus would show that shortcut in the relevant row. However,
the Exit command isn't shown in the Chrome OS app menu so it should be
fine to skip registering it completely and let Ash handle it.

Also verified that ctrl+shift+q is still treated as reserved, i.e. cannot
be eaten by a webpage. This site is useful for manually testing that:
  http://unixpapa.com/js/testkey.html


Bug:  834092 
Change-Id: Ie6de31a0efa36da0f67def3ba7a5124b6c527bd3
Reviewed-on: https://chromium-review.googlesource.com/1024876
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553613}(cherry picked from commit 5883ad596711781d9d04e26b97421a06e95956bd)
Reviewed-on: https://chromium-review.googlesource.com/1028493
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#305}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/968ccfdbce5cba09f0e30ad888461b527558f177/chrome/browser/browser_shutdown_browsertest.cc
[modify] https://crrev.com/968ccfdbce5cba09f0e30ad888461b527558f177/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc
[modify] https://crrev.com/968ccfdbce5cba09f0e30ad888461b527558f177/chrome/browser/ui/views/accelerator_table.cc
[modify] https://crrev.com/968ccfdbce5cba09f0e30ad888461b527558f177/chrome/browser/ui/views/accelerator_table_unittest.cc

Thanks for merging; please set as 'fixed' 
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on M68 (10718.34.0, 68.0.3440.40) and M67 (10575.58.0, 67.0.3396.99).

Sign in to add a comment