Issue metadata
Sign in to add a comment
|
Device sign out happens with just one time key press using 'ctrl+shift+q' shortcut keys |
||||||||||||||||||||||
Issue descriptionChrome OS version: 10575.4.0, 67.0.3396.8 dev channel eve, nautilus Steps to repro: 1. Login to the device 2. Sign out of the device by pressing shortcut keys 'ctrl+shift+q' only once 3. You may try signing in back and sign out again using shortcut keys once. Actual behavior? Able to sign out of the device by pressing shortcut keys 'ctrl+shift+q' only once Actual behavior? Should be able to sign out of the device by pressing shortcut keys twice and not by one time press. This is a bug regression as this behavior is not seen on (10539.0.0, 67.0.3383.0)
,
Apr 17 2018
,
Apr 17 2018
Attaching eve device logs in this link: https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/834092/
,
Apr 18 2018
Reprod on EVE TOT 10592.0.0 / 68.0.3397.0 build
,
Apr 18 2018
This seems to be purely a keyboard issue.
,
Apr 23 2018
Is crbug/835610 a DUP? Can we get this triaged / escalated as a RBB? Along with board scope?
,
Apr 23 2018
Issue 835610 has been merged into this issue.
,
Apr 23 2018
,
Apr 23 2018
It's probably related to the cleanup of IDC_EXIT.
,
Apr 23 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5883ad596711781d9d04e26b97421a06e95956bd commit 5883ad596711781d9d04e26b97421a06e95956bd Author: Evan Stade <estade@chromium.org> Date: Wed Apr 25 17:13:45 2018 [Chrome OS] Revert recent changes to IDC_EXIT accelerator handling. In db110f78b92a0f802b0c90e55555dd9120a35a07, IDC_EXIT was changed to be handled by Chrome instead of Ash. This reverts that change. Originally, I thought Chrome would have to register the IDC_EXIT command so that menus would show that shortcut in the relevant row. However, the Exit command isn't shown in the Chrome OS app menu so it should be fine to skip registering it completely and let Ash handle it. Also verified that ctrl+shift+q is still treated as reserved, i.e. cannot be eaten by a webpage. This site is useful for manually testing that: http://unixpapa.com/js/testkey.html Bug: 834092 Change-Id: Ie6de31a0efa36da0f67def3ba7a5124b6c527bd3 Reviewed-on: https://chromium-review.googlesource.com/1024876 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#553613} [modify] https://crrev.com/5883ad596711781d9d04e26b97421a06e95956bd/chrome/browser/browser_shutdown_browsertest.cc [modify] https://crrev.com/5883ad596711781d9d04e26b97421a06e95956bd/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc [modify] https://crrev.com/5883ad596711781d9d04e26b97421a06e95956bd/chrome/browser/ui/views/accelerator_table.cc [modify] https://crrev.com/5883ad596711781d9d04e26b97421a06e95956bd/chrome/browser/ui/views/accelerator_table_unittest.cc
,
Apr 25 2018
,
Apr 25 2018
Confirmed with estade@ that this was tested on ToT and low risk as a revert. Approving merge to M67 Chrome OS. Please get the merge in today so we can keep going for Beta. Thanks :-)
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/968ccfdbce5cba09f0e30ad888461b527558f177 commit 968ccfdbce5cba09f0e30ad888461b527558f177 Author: Evan Stade <estade@chromium.org> Date: Wed Apr 25 20:30:37 2018 [Chrome OS] Revert recent changes to IDC_EXIT accelerator handling. In db110f78b92a0f802b0c90e55555dd9120a35a07, IDC_EXIT was changed to be handled by Chrome instead of Ash. This reverts that change. Originally, I thought Chrome would have to register the IDC_EXIT command so that menus would show that shortcut in the relevant row. However, the Exit command isn't shown in the Chrome OS app menu so it should be fine to skip registering it completely and let Ash handle it. Also verified that ctrl+shift+q is still treated as reserved, i.e. cannot be eaten by a webpage. This site is useful for manually testing that: http://unixpapa.com/js/testkey.html Bug: 834092 Change-Id: Ie6de31a0efa36da0f67def3ba7a5124b6c527bd3 Reviewed-on: https://chromium-review.googlesource.com/1024876 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#553613}(cherry picked from commit 5883ad596711781d9d04e26b97421a06e95956bd) Reviewed-on: https://chromium-review.googlesource.com/1028493 Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#305} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/968ccfdbce5cba09f0e30ad888461b527558f177/chrome/browser/browser_shutdown_browsertest.cc [modify] https://crrev.com/968ccfdbce5cba09f0e30ad888461b527558f177/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc [modify] https://crrev.com/968ccfdbce5cba09f0e30ad888461b527558f177/chrome/browser/ui/views/accelerator_table.cc [modify] https://crrev.com/968ccfdbce5cba09f0e30ad888461b527558f177/chrome/browser/ui/views/accelerator_table_unittest.cc
,
Apr 25 2018
Thanks for merging; please set as 'fixed'
,
Apr 25 2018
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8303e89f2793cf8c9e371204f01bd4c8d72bed8 commit e8303e89f2793cf8c9e371204f01bd4c8d72bed8 Author: Evan Stade <estade@chromium.org> Date: Thu May 03 00:04:51 2018 [Mash] fix color of Settings app frame. Bug: 834092 Change-Id: I0676206a08de89cb6f4a8d0884228357b9576d60 Reviewed-on: https://chromium-review.googlesource.com/1028982 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#555618} [modify] https://crrev.com/e8303e89f2793cf8c9e371204f01bd4c8d72bed8/chrome/browser/ui/views/frame/browser_frame_ash.h [modify] https://crrev.com/e8303e89f2793cf8c9e371204f01bd4c8d72bed8/chrome/browser/ui/views/frame/browser_frame_mus.cc [modify] https://crrev.com/e8303e89f2793cf8c9e371204f01bd4c8d72bed8/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
,
Jul 2
Verified on M68 (10718.34.0, 68.0.3440.40) and M67 (10575.58.0, 67.0.3396.99). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mkarkada@chromium.org
, Apr 17 2018