New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834085 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Revert button missing from ANGLE Gerrit

Project Member Reported by jmad...@chromium.org, Apr 17 2018

Issue description

This button seems to be missing - maybe related to recent changes to block revert button spam? This came at a very inopportune time when the whole tree is on fire.

 
Owner: aga...@chromium.org
Status: Unconfirmed (was: Untriaged)
agable@, can you help triage this?
Status: Available (was: Unconfirmed)

Comment 3 by agable@google.com, Apr 20 2018

Owner: ----
angle appears to use chromium-style CQ label, but chromiumos-style CR label. I am not surprised that this totally messes with the plugin and confuses it.

I don't have time to fix this in the near future. There's a standing TODO to generalize the plugin and stop hardcoding CR+1/CR+2/etc. Addressing that would likely resolve this issue.

If someone would like to contribute to https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/master/src/main/resources/static/chromium-behavior.html I'd be happy to review and deploy.
Cc: dpranke@chromium.org kbr@chromium.org
Labels: -Type-Bug Type-Bug-Regression

Comment 6 by kbr@chromium.org, Apr 21 2018

Cc: estaab@chromium.org
Components: Infra>Client>Chrome
estaab: this is a very unsatisfying resolution to this bug. Who can help fix it?

Components: -Infra>Client>Chrome Infra>Platform

Comment 8 by estaab@chromium.org, Apr 23 2018

Cc: jparent@chromium.org
Components: -Infra>Platform
This definitely falls under devx and not platform so agable/jparent need to make the call on how they want to prioritize this.

Maybe just make the CR label chromium-style in the short term?
Cc: geoffl...@chromium.org
What constitutes chromium style? How about this proposal: we switch to +1 Code-Review and +1 Owner-Review, where commits are gated on Owner-Review?
(Sorry if that's not a help - not sure what chromium-style and chromeos-style are).
Owner: aga...@chromium.org
Status: Fixed (was: Available)
This seems to have come back at some point. Closing.

Sign in to add a comment