Issue metadata
Sign in to add a comment
|
Revert button missing from ANGLE Gerrit |
||||||||||||||||||||||
Issue descriptionThis button seems to be missing - maybe related to recent changes to block revert button spam? This came at a very inopportune time when the whole tree is on fire.
,
Apr 20 2018
,
Apr 20 2018
angle appears to use chromium-style CQ label, but chromiumos-style CR label. I am not surprised that this totally messes with the plugin and confuses it. I don't have time to fix this in the near future. There's a standing TODO to generalize the plugin and stop hardcoding CR+1/CR+2/etc. Addressing that would likely resolve this issue. If someone would like to contribute to https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/master/src/main/resources/static/chromium-behavior.html I'd be happy to review and deploy.
,
Apr 20 2018
,
Apr 20 2018
,
Apr 21 2018
estaab: this is a very unsatisfying resolution to this bug. Who can help fix it?
,
Apr 21 2018
,
Apr 23 2018
This definitely falls under devx and not platform so agable/jparent need to make the call on how they want to prioritize this. Maybe just make the CR label chromium-style in the short term?
,
Apr 23 2018
What constitutes chromium style? How about this proposal: we switch to +1 Code-Review and +1 Owner-Review, where commits are gated on Owner-Review?
,
Apr 23 2018
(Sorry if that's not a help - not sure what chromium-style and chromeos-style are).
,
May 9 2018
This seems to have come back at some point. Closing. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by reve...@chromium.org
, Apr 20 2018Status: Unconfirmed (was: Untriaged)