presubmit crashes when moving or removing directories |
|||||
Issue descriptionIf you deleted or moved a directory containing a PRESUBMIT.py file, then the presubmit checks would crash trying to run tests in a directory that no longer existed. See https://chromium-review.googlesource.com/c/chromium/src/+/1015600/1, https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit/88545, and https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8948973294362798080%2F%2B%2Fsteps%2Fpresubmit%2F0%2Fstdout for an example.
,
Apr 17 2018
,
Apr 18 2018
Introduced by https://chromium-review.googlesource.com/c/chromium/src/+/966906
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3855731efecbd347602e515df44fd036eb1b7303 commit 3855731efecbd347602e515df44fd036eb1b7303 Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Apr 18 00:53:07 2018 Fix crash in PRESUBMIT.py when moving dirs. If you deleted or moved a directory containing a PRESUBMIT.py file, then the presubmit checks would crash trying to run tests in a directory that no longer existed. R=agable@chromium.org BUG= 834077 Change-Id: I8deb59c2d00b80f6b5215597076bba34ff1f0872 Reviewed-on: https://chromium-review.googlesource.com/1015976 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551542} [modify] https://crrev.com/3855731efecbd347602e515df44fd036eb1b7303/PRESUBMIT.py
,
Apr 18 2018
,
Nov 29
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dpranke@chromium.org
, Apr 17 2018Components: Infra>SDK