Make master/slave scheduling swarming friendly. |
|||
Issue descriptionCurrently, master/slave builds are very aware of the waterfall they are running on. We need to update our slave launching logic to allow slaves to be launched as swarming builds if the master is a swarming build.
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/353830374be545c248ba5251ed4e83f2eb1ab37c commit 353830374be545c248ba5251ed4e83f2eb1ab37c Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat May 19 02:14:36 2018 Roll src/third_party/chromite/ 17530e94d..752413029 (3 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/17530e94d1c5..752413029ca9 $ git log 17530e94d..752413029 --date=short --no-merges --format='%ad %ae %s' 2018-05-16 dgarrett CleanUpStage: Revamp build slave cancellation. 2018-05-16 dgarrett ScheduleSlavesStage: Fix master buildbucket id. 2018-05-15 dgarrett request_build: Add features needed by master/slave builds. Created with: roll-dep src/third_party/chromite BUG= chromium:834076 ,chromium:None,chromium:824550 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I68e7f2ad0d0e706785667b5bc74c072491b61a4e Reviewed-on: https://chromium-review.googlesource.com/1066928 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560145} [modify] https://crrev.com/353830374be545c248ba5251ed4e83f2eb1ab37c/DEPS
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5a952e9ac6921f7330b6df466bd1a09503b95f97 commit 5a952e9ac6921f7330b6df466bd1a09503b95f97 Author: Don Garrett <dgarrett@google.com> Date: Thu May 31 19:09:20 2018 scheduler_stages: Switch to request_build library. Now that we have a shiny new request_build library for requesting builds, use it when master builders schedule slave builds. After this is in place, existing waterfall builds should be unaffected, but it should be possible to move the scheduling of slave builders from the current waterfalls to swarming by updating the build configs of the slaves in question. I consider this to be an extremely dangerous change. If successful, it will have no immediate impact until matching build config changes are made. BUG= chromium:834076 TEST=run_tests Change-Id: I5a8e215739e450dcbc6435682010094dc9018ca7 Reviewed-on: https://chromium-review.googlesource.com/1062204 Tested-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Nichols <mikenichols@chromium.org> [modify] https://crrev.com/5a952e9ac6921f7330b6df466bd1a09503b95f97/cbuildbot/stages/scheduler_stages.py [modify] https://crrev.com/5a952e9ac6921f7330b6df466bd1a09503b95f97/cbuildbot/stages/scheduler_stages_unittest.py
,
May 31 2018
Watching a master builder schedule slaves now to see if this works as expected.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/7461ecbae5479a9af4693f9942a1a52ff806dd5f commit 7461ecbae5479a9af4693f9942a1a52ff806dd5f Author: Don Garrett <dgarrett@chromium.org> Date: Thu May 31 19:46:30 2018 Revert "scheduler_stages: Switch to request_build library." This reverts commit 5a952e9ac6921f7330b6df466bd1a09503b95f97. Reason for revert: Caused failures while scheduling slave builders. BUG= chromium:834076 TEST=None Original change's description: > scheduler_stages: Switch to request_build library. > > Now that we have a shiny new request_build library for requesting > builds, use it when master builders schedule slave builds. > > After this is in place, existing waterfall builds should be > unaffected, but it should be possible to move the scheduling of slave > builders from the current waterfalls to swarming by updating the build > configs of the slaves in question. > > I consider this to be an extremely dangerous change. If successful, it > will have no immediate impact until matching build config changes are > made. > > BUG= chromium:834076 > TEST=run_tests > > Change-Id: I5a8e215739e450dcbc6435682010094dc9018ca7 > Reviewed-on: https://chromium-review.googlesource.com/1062204 > Tested-by: Don Garrett <dgarrett@chromium.org> > Trybot-Ready: Don Garrett <dgarrett@chromium.org> > Reviewed-by: Mike Nichols <mikenichols@chromium.org> Bug: chromium:834076 Change-Id: Iee02aa4d71dfea2ac2c7c6682dcc157c4f6ad48e Reviewed-on: https://chromium-review.googlesource.com/1081248 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/7461ecbae5479a9af4693f9942a1a52ff806dd5f/cbuildbot/stages/scheduler_stages.py [modify] https://crrev.com/7461ecbae5479a9af4693f9942a1a52ff806dd5f/cbuildbot/stages/scheduler_stages_unittest.py
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ce24358edc5587abad45c1c6eeca19deee61fc0 commit 8ce24358edc5587abad45c1c6eeca19deee61fc0 Author: chromite-chromium-autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 01 03:01:54 2018 Roll src/third_party/chromite 80ebf9c..ffe9e60 (4 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/80ebf9c..ffe9e60 git log 80ebf9c..ffe9e60 --date=short --no-merges --format='%ad %ae %s' 2018-05-31 dgarrett@google.com chromeos_config: Move some builds to chrome_informational. 2018-05-31 dgarrett@chromium.org Revert "scheduler_stages: Switch to request_build library." 2018-05-15 dgarrett@google.com scheduler_stages: Switch to request_build library. 2018-05-31 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@ffe9e60 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:834076 , chromium:834076 , chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: I4d9cca66e13e99d09c54206c3605efce9189d688 Reviewed-on: https://chromium-review.googlesource.com/1081084 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#563508} [modify] https://crrev.com/8ce24358edc5587abad45c1c6eeca19deee61fc0/DEPS
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/a3b77dde085999e76841f5da0fa603d30696c704 commit a3b77dde085999e76841f5da0fa603d30696c704 Author: Don Garrett <dgarrett@google.com> Date: Fri Jun 01 14:22:02 2018 request_build: Fix logging error. If a buildbucket build is requested with logging enabled (for example, via cros tryjob --debug), we would get a formatting error. This change adds includes the bucket name in ScheduledBuild, and then uses it while logging results. Further, it switches our logging format string to use named attributes. BUG= chromium:834076 TEST=run_tests && new test that reproduced the failure. Change-Id: I68f145d6ee8ae4db52083165b02319ce84c450c2 Reviewed-on: https://chromium-review.googlesource.com/1081334 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Nichols <mikenichols@chromium.org> [modify] https://crrev.com/a3b77dde085999e76841f5da0fa603d30696c704/lib/request_build.py [modify] https://crrev.com/a3b77dde085999e76841f5da0fa603d30696c704/lib/request_build_unittest.py
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ff0d51c297343c4da2d37479b399764a6e7f8094 commit ff0d51c297343c4da2d37479b399764a6e7f8094 Author: Don Garrett <dgarrett@google.com> Date: Fri Jun 01 14:23:07 2018 scheduler_stages: Switch to request_build library. Now that we have a shiny new request_build library for requesting builds, use it when master builders schedule slave builds. After this is in place, existing waterfall builds should be unaffected, but it should be possible to move the scheduling of slave builders from the current waterfalls to swarming by updating the build configs of the slaves in question. I consider this to be an extremely dangerous change. If successful, it will have no immediate impact until matching build config changes are made. BUG= chromium:834076 TEST=run_tests Change-Id: I2ab0b23fd982fcaf31cc2fd54cc969d68d60c497 Reviewed-on: https://chromium-review.googlesource.com/1081292 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Nichols <mikenichols@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/ff0d51c297343c4da2d37479b399764a6e7f8094/cbuildbot/stages/scheduler_stages.py [modify] https://crrev.com/ff0d51c297343c4da2d37479b399764a6e7f8094/cbuildbot/stages/scheduler_stages_unittest.py
,
Jun 1 2018
Careful examination of this build and it's slaves: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8944913142387846064 Shows that the new library is working with two possible issues. 1) --buildbot is not explicitly passed in as a cbb_extra_arg. Should it be? 2) We should log links to slaves on the master after launching them.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c910387f564088687e6269ac21c4313fdf8998a0 commit c910387f564088687e6269ac21c4313fdf8998a0 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 01 17:16:21 2018 Roll src/third_party/chromite a09f2ac..ff0d51c (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/a09f2ac..ff0d51c git log a09f2ac..ff0d51c --date=short --no-merges --format='%ad %ae %s' 2018-06-01 dgarrett@google.com scheduler_stages: Switch to request_build library. 2018-06-01 dgarrett@google.com request_build: Fix logging error. Created with: gclient setdep -r src/third_party/chromite@ff0d51c The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:834076 , chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: I8c6348062027e661738f8b84835b54b262882c6e Reviewed-on: https://chromium-review.googlesource.com/1082606 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#563695} [modify] https://crrev.com/c910387f564088687e6269ac21c4313fdf8998a0/DEPS
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/179611c23b33a64ceb1034e4dd9271f65e464384 commit 179611c23b33a64ceb1034e4dd9271f65e464384 Author: Don Garrett <dgarrett@google.com> Date: Mon Jun 04 19:46:00 2018 chromeos_config: Move zoombini-release to swarming. This tests our ability to move a single slave builder to swarming. Release builders are the simplest case, since the master builder does not pay attention to the success or failure of the slave in question. BUG= chromium:834076 TEST=run_tests Change-Id: I98f75d109301ad5e0aca94f6dde6fa04696e7528 Reviewed-on: https://chromium-review.googlesource.com/1085900 Tested-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/179611c23b33a64ceb1034e4dd9271f65e464384/cbuildbot/config_dump.json [modify] https://crrev.com/179611c23b33a64ceb1034e4dd9271f65e464384/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/179611c23b33a64ceb1034e4dd9271f65e464384/cbuildbot/chromeos_config.py
,
Jun 4 2018
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dd20b98e3e4711c9f9b82a6c09a88563da261ff commit 3dd20b98e3e4711c9f9b82a6c09a88563da261ff Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Jun 04 21:04:19 2018 Roll src/third_party/chromite c4db222..179611c (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/c4db222..179611c git log c4db222..179611c --date=short --no-merges --format='%ad %ae %s' 2018-06-04 dgarrett@google.com chromeos_config: Move zoombini-release to swarming. Created with: gclient setdep -r src/third_party/chromite@179611c The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: I64a844ac6dab754ecf13ea3e5d6aac5fe5056af7 Reviewed-on: https://chromium-review.googlesource.com/1085905 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564235} [modify] https://crrev.com/3dd20b98e3e4711c9f9b82a6c09a88563da261ff/DEPS
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d4196ec7f7b052a6bd0f2ac243299f5ead357eae commit d4196ec7f7b052a6bd0f2ac243299f5ead357eae Author: Don Garrett <dgarrett@google.com> Date: Tue Jun 05 02:24:52 2018 buildbucket_lib: Add swarming bucket to map. Add the swarming bucket to the waterfall -> bucket map (we have a swarming "waterfall"). This is needed to be able to lookup the bucket used to schedule swarming builds. BUG= chromium:834076 TEST=run_tests Change-Id: I8d70b7b3f00b1509de54fb79fd6eb9c01499978a Reviewed-on: https://chromium-review.googlesource.com/1086518 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/d4196ec7f7b052a6bd0f2ac243299f5ead357eae/lib/buildbucket_lib.py
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59011aa9aed6b4ecbf11d02dfa4e280d8bedc2f2 commit 59011aa9aed6b4ecbf11d02dfa4e280d8bedc2f2 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jun 05 07:04:56 2018 Roll src/third_party/chromite 84e4547..d4196ec (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/84e4547..d4196ec git log 84e4547..d4196ec --date=short --no-merges --format='%ad %ae %s' 2018-06-05 dgarrett@google.com buildbucket_lib: Add swarming bucket to map. Created with: gclient setdep -r src/third_party/chromite@d4196ec The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: I0e60229eef11a332656ba2dae33ec8ff8d850915 Reviewed-on: https://chromium-review.googlesource.com/1086567 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564384} [modify] https://crrev.com/59011aa9aed6b4ecbf11d02dfa4e280d8bedc2f2/DEPS
,
Jun 5 2018
The latest attempt failed with this error:
03:07:38: INFO: RunCommand: /b/c/cbuild/repository/.cache/cipd/packages/infra/tools/luci-auth/linux-amd64/luci-auth token '-service-account-json=/creds/service_accounts/service-account-chromeos.json'
[1;31m03:07:38: ERROR: <class 'chromite.lib.request_build.RemoteRequestFailure'>: buildbucket error.
Reason: BUILDER_NOT_FOUND
Message: Builder u'zoombini-release' is not found in bucket u'luci.chromeos.general'
Traceback (most recent call last):
File "/b/c/cbuild/repository/chromite/lib/failures_lib.py", line 230, in wrapped_functor
return functor(*args, **kwargs)
File "/b/c/cbuild/repository/chromite/cbuildbot/stages/scheduler_stages.py", line 194, in PerformStage
dryrun=self._run.options.debug)
File "/b/c/cbuild/repository/chromite/cbuildbot/stages/scheduler_stages.py", line 148, in ScheduleSlaveBuildsViaBuildbucket
dryrun=dryrun)
File "/b/c/cbuild/repository/chromite/cbuildbot/stages/scheduler_stages.py", line 110, in PostSlaveBuildToBuildbucket
result = request.Submit(dryrun=dryrun)
File "/b/c/cbuild/repository/chromite/lib/request_build.py", line 202, in Submit
return self._PutConfigToBuildBucket(buildbucket_client, dryrun)
File "/b/c/cbuild/repository/chromite/lib/request_build.py", line 171, in _PutConfigToBuildBucket
buildbucket_lib.GetErrorMessage(content)))
RemoteRequestFailure: buildbucket error.
Reason: BUILDER_NOT_FOUND
Message: Builder u'zoombini-release' is not found in bucket u'luci.chromeos.general'
[0m
That's an error in my recent code. It means that buildbot specific buildbucket options are still being set for a swarming build. The builder name is the waterfall column, not a LUCI Builder name.
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c53433efeec4fcdebfa969acfd88c3244555a6e2 commit c53433efeec4fcdebfa969acfd88c3244555a6e2 Author: Don Garrett <dgarrett@chromium.org> Date: Tue Jun 05 16:13:00 2018 Revert "chromeos_config: Move zoombini-release to swarming." This reverts commit 179611c23b33a64ceb1034e4dd9271f65e464384. Reason for revert: Still not working. Reverting until additional fixes are ready. Original change's description: > chromeos_config: Move zoombini-release to swarming. > > This tests our ability to move a single slave builder to > swarming. Release builders are the simplest case, since the master > builder does not pay attention to the success or failure of the slave > in question. > > BUG= chromium:834076 > TEST=run_tests > > Change-Id: I98f75d109301ad5e0aca94f6dde6fa04696e7528 > Reviewed-on: https://chromium-review.googlesource.com/1085900 > Tested-by: Don Garrett <dgarrett@chromium.org> > Trybot-Ready: Don Garrett <dgarrett@chromium.org> > Reviewed-by: Jason Clinton <jclinton@chromium.org> Bug: chromium:834076 Change-Id: I4a8c2db4101a264ea43a979ae0e12942a30dd456 Reviewed-on: https://chromium-review.googlesource.com/1087327 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/c53433efeec4fcdebfa969acfd88c3244555a6e2/cbuildbot/config_dump.json [modify] https://crrev.com/c53433efeec4fcdebfa969acfd88c3244555a6e2/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/c53433efeec4fcdebfa969acfd88c3244555a6e2/cbuildbot/chromeos_config.py
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/49203c41983894faa2944e44a8cb20ded225fe53 commit 49203c41983894faa2944e44a8cb20ded225fe53 Author: Don Garrett <dgarrett@google.com> Date: Tue Jun 05 17:51:12 2018 scheduler_stages: Correctly test for swarming slave. The scheduler test was using a bogus test to see if the slave was on swarming, so so setting buildbucket specific values for swarming slaves. BUG= chromium:834076 TEST=run_tests Change-Id: Iddf007dbdce2675f818bed2107a432f74e738a80 Reviewed-on: https://chromium-review.googlesource.com/1087501 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/49203c41983894faa2944e44a8cb20ded225fe53/cbuildbot/stages/scheduler_stages.py
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6f09853fe84e918b24012697e94368e719220da2 commit 6f09853fe84e918b24012697e94368e719220da2 Author: Don Garrett <dgarrett@chromium.org> Date: Tue Jun 05 17:52:43 2018 Reland "chromeos_config: Move zoombini-release to swarming." This reverts commit c53433efeec4fcdebfa969acfd88c3244555a6e2. Reason for revert: CL:1087501 should fix the issue that caused this to fail previously. Original change's description: > Revert "chromeos_config: Move zoombini-release to swarming." > > This reverts commit 179611c23b33a64ceb1034e4dd9271f65e464384. > > Reason for revert: Still not working. Reverting until additional fixes are ready. > > Original change's description: > > chromeos_config: Move zoombini-release to swarming. > > > > This tests our ability to move a single slave builder to > > swarming. Release builders are the simplest case, since the master > > builder does not pay attention to the success or failure of the slave > > in question. > > > > BUG= chromium:834076 > > TEST=run_tests > > > > Change-Id: I98f75d109301ad5e0aca94f6dde6fa04696e7528 > > Reviewed-on: https://chromium-review.googlesource.com/1085900 > > Tested-by: Don Garrett <dgarrett@chromium.org> > > Trybot-Ready: Don Garrett <dgarrett@chromium.org> > > Reviewed-by: Jason Clinton <jclinton@chromium.org> > > Bug: chromium:834076 > Change-Id: I4a8c2db4101a264ea43a979ae0e12942a30dd456 > Reviewed-on: https://chromium-review.googlesource.com/1087327 > Reviewed-by: Don Garrett <dgarrett@chromium.org> > Tested-by: Don Garrett <dgarrett@chromium.org> > Trybot-Ready: Don Garrett <dgarrett@chromium.org> Bug: chromium:834076 Change-Id: I48e9bad4a049a434708169edde55e69759f548ae Reviewed-on: https://chromium-review.googlesource.com/1087328 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/6f09853fe84e918b24012697e94368e719220da2/cbuildbot/config_dump.json [modify] https://crrev.com/6f09853fe84e918b24012697e94368e719220da2/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/6f09853fe84e918b24012697e94368e719220da2/cbuildbot/chromeos_config.py
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61d859289288c68e44b9f80d67cb6f125719e71b commit 61d859289288c68e44b9f80d67cb6f125719e71b Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jun 05 18:47:10 2018 Roll src/third_party/chromite 28b3d7b..c53433e (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/28b3d7b..c53433e git log 28b3d7b..c53433e --date=short --no-merges --format='%ad %ae %s' 2018-06-05 dgarrett@chromium.org Revert "chromeos_config: Move zoombini-release to swarming." Created with: gclient setdep -r src/third_party/chromite@c53433e The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: Ib184c0a5a0401bb82447dbbc5555c888a8e3ef58 Reviewed-on: https://chromium-review.googlesource.com/1087298 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564598} [modify] https://crrev.com/61d859289288c68e44b9f80d67cb6f125719e71b/DEPS
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6025cf46976f48df6185cec11bd4a06f6fd8b035 commit 6025cf46976f48df6185cec11bd4a06f6fd8b035 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jun 05 20:44:36 2018 Roll src/third_party/chromite c53433e..8bc3398 (3 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/c53433e..8bc3398 git log c53433e..8bc3398 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 vapier@chromium.org lint_unittest: refactor assert helper to make checking easier 2018-06-05 dgarrett@chromium.org Reland "chromeos_config: Move zoombini-release to swarming." 2018-06-05 dgarrett@google.com scheduler_stages: Correctly test for swarming slave. Created with: gclient setdep -r src/third_party/chromite@8bc3398 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:834076,chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: Ic83da17e578ec3206a22b73b08d1a81bcd6ae310 Reviewed-on: https://chromium-review.googlesource.com/1087391 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564654} [modify] https://crrev.com/6025cf46976f48df6185cec11bd4a06f6fd8b035/DEPS
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6be71e72b877b38f6d61d0fd00928a197f1b292b commit 6be71e72b877b38f6d61d0fd00928a197f1b292b Author: Don Garrett <dgarrett@google.com> Date: Wed Jun 06 06:01:53 2018 scheduler_stages: Use --buildbot for all slaves. There are currently no masters scheduling non-Prod slaves, and --buildbot must be explicitly given for Prod builders. So... always give it. This needs to be revisited to be inserted based on the LUCI Builder, recipe, or something like that instead, but for now, get the slaves working. BUG= chromium:834076 TEST=run_tests Change-Id: Idec378286f1444c426b05d9f6f6b2000b5908928 Reviewed-on: https://chromium-review.googlesource.com/1088147 Tested-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/6be71e72b877b38f6d61d0fd00928a197f1b292b/cbuildbot/stages/scheduler_stages.py
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5412456cb1b44fef3c9514b38ba2835598825f64 commit 5412456cb1b44fef3c9514b38ba2835598825f64 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Jun 06 09:30:51 2018 Roll src/third_party/chromite ff6ae37..6be71e7 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/ff6ae37..6be71e7 git log ff6ae37..6be71e7 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 dgarrett@google.com scheduler_stages: Use --buildbot for all slaves. Created with: gclient setdep -r src/third_party/chromite@6be71e7 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: I6ab2ebd812e38b388e484d957c1ee595882872f2 Reviewed-on: https://chromium-review.googlesource.com/1088195 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564836} [modify] https://crrev.com/5412456cb1b44fef3c9514b38ba2835598825f64/DEPS
,
Jun 8 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 19 2018