Issue metadata
Sign in to add a comment
|
The app launcher is accessible within kiosk mode
Reported by
vijay.ka...@pearson.com,
Apr 17 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36 Platform: 10539.0.0 (official Build) dev-channel clapper Steps to reproduce the problem: 1. Bring up any app that can run in the kiosk mode, such as Pearson TestNav on non-tablet mode 2. Fold the device into tablet mode 3. Swipe up from the bottom of the screen 4. Tap over the launcher What is the expected behavior? user should not be able to access app launcher and its content What went wrong? app launcher displays along with options like google search Did this work before? N/A Chrome version: 67.0.3383.0 Channel: dev OS Version: 67.0.3383.0 Flash Version: 29.0.0.140
,
Apr 24 2018
This is working as intended, the launcher is always accessible by swiping up from the bottom of the screen. Why do you not want the launcher to show up?
,
Apr 24 2018
We do not want students to access anything when they're in the kiosk mode.
,
Apr 24 2018
Oh, thanks. I mis-read this as tablet mode.
,
Apr 25 2018
Thanks for filing. Raising priority.
,
Apr 25 2018
,
Apr 25 2018
,
Apr 25 2018
After reproducing this, the user will not be able to launch any apps or search from the launcher in kiosk mode. They will be able to see the launcher and the searchbox, but the launcher silently fails to launch apps/search. We will still patch this in M67.
,
Apr 26 2018
After doing a git bisect The error was tracked to this cl: https://chromium-review.googlesource.com/c/chromium/src/+/954355 xiyuan, while hejq@ is OOO could you take a look?
,
Apr 26 2018
The CL maybe the trigger of the bug but it is not the root cause. The problem has two causes: 1. Shelf auto hide behavior is changed in ShelfController [1] when tablet mode starts, regardless of kiosk mode; 2. When tablet mode starts, TabletModeWindowManager kicks in and replaces window state with a TabletModeWindowState which does not reflect full screen state correctly (looks like it thinks the app window is an immersive maximized one). 1 is easy to fix. Not sure how 2 should be addressed, maybe disable tablet mode for kiosk. [1] https://cs.chromium.org/chromium/src/ash/shelf/shelf_controller.cc?rcl=7ceb20aa2d291781ab6b0c9a2b0c3a2f44cf0581&l=336
,
Apr 30 2018
Proposed fix: https://chromium-review.googlesource.com/c/chromium/src/+/1035522 Item 2 in #10 is because app window enables immersive mode when entering tablet mode. It works as expected if app window does not enable immersive mode.
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/645b928b86c3b6ddaf4a9e1f8339cf7c18278b24 commit 645b928b86c3b6ddaf4a9e1f8339cf7c18278b24 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Tue May 01 23:20:32 2018 kiosk: No shelf/launcher in tablet mode - Shelf stays with SHELF_AUTO_HIDE_ALWAYS_HIDDEN in tablet mode when running in a kiosk session; - App window keeps the immersive mode disabled when entering tablet mode in a kiosk session; Bug: 834058 Test: ash_unittests ShelfControllerAppModeTest.AutoHideBehavior and browser_tests ChromeNativeAppWindowViewsAuraAshBrowserTest.NoImmersiveModeWhenForcedFullscreen Change-Id: I57cf9ac08fdc48c433dcb0d5c3f7c561041431c3 Reviewed-on: https://chromium-review.googlesource.com/1035522 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555222} [modify] https://crrev.com/645b928b86c3b6ddaf4a9e1f8339cf7c18278b24/ash/shelf/shelf_controller.cc [modify] https://crrev.com/645b928b86c3b6ddaf4a9e1f8339cf7c18278b24/ash/shelf/shelf_controller_unittest.cc [modify] https://crrev.com/645b928b86c3b6ddaf4a9e1f8339cf7c18278b24/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc [modify] https://crrev.com/645b928b86c3b6ddaf4a9e1f8339cf7c18278b24/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h [modify] https://crrev.com/645b928b86c3b6ddaf4a9e1f8339cf7c18278b24/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_browsertest.cc
,
May 2 2018
,
May 2 2018
This is a relatively large change for a late-cycle merge and it was occurring prior to M67 (reported for M65). Rejecting for M67; please update and retag with scope / impact if disagree. Thanks
,
May 2 2018
+atwilson fyi This has been broken for a while since tablet mode is added (probably as early as M62). Put it to M68.
,
May 3 2018
Naveen: FYI - looks innocuous but wanted to loop you in.
,
May 3 2018
Thanks Drew. Is the issue that this fix can't be made in 67? And that will lead to launcher and search being visible but not usable in 67 until this can be fixed in 68? |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Apr 18 2018