New issue
Advanced search Search tips

Issue 834056 link

Starred by 1 user
Status: Fixed
Owner:
kozy@chromium.org
Closed: May 2018
Cc:
pfeldman@chromium.org
dgozman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Call to "Debugger.Disable" resumes application even when there are other clients.

Project Member Reported by eostroukhov@chromium.org, Apr 17 2018 
1. Run Node.js with "node --inspect"
2. Attach several debug clients (e.g. I am using devtools)
3. Suspend the process.
4. Disconnect one debugger.

Process resumes.

Expected: process should be suspended as long as there's at least one remaining debugger.
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/67bb22e319965267c050ae85e9c464ec2928bfd2

commit 67bb22e319965267c050ae85e9c464ec2928bfd2
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu May 03 06:23:12 2018

[inspector] do not resume on agent disable if there is other agents

If there is more then one agent accepts current pause, we should resume
only when last agent is disabled.

R=dgozman@chromium.org

Bug:  chromium:834056 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2904b3f4ab76117511e16450dd575ebf3e20a068
Reviewed-on: https://chromium-review.googlesource.com/1041207
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52931}
[modify] https://crrev.com/67bb22e319965267c050ae85e9c464ec2928bfd2/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/67bb22e319965267c050ae85e9c464ec2928bfd2/src/inspector/v8-debugger.cc
[modify] https://crrev.com/67bb22e319965267c050ae85e9c464ec2928bfd2/test/inspector/debugger/external-stack-trace.js
[modify] https://crrev.com/67bb22e319965267c050ae85e9c464ec2928bfd2/test/inspector/sessions/debugger-stepping-and-breakpoints-expected.txt
[modify] https://crrev.com/67bb22e319965267c050ae85e9c464ec2928bfd2/test/inspector/sessions/debugger-stepping-and-breakpoints.js

Comment 2 by kozy@chromium.org, May 3 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment