Telemetry should not hard code "Release" or "Debug" output dirs |
|||
Issue descriptionSplitting from issue 831145 @dpranke: (1) mb shouldn't shout at you if you don't use a directory named 'Release' or 'Debug'. Rather, it's a bug in any test harness that such a directory might be required. @thakis: Where "Release" is mentioned in telemetry: https://cs.chromium.org/search/?q=%5CbRelease+case:yes+file:telemetry&sq=package:chromium&type=cs So primarily catapult. There: https://cs.chromium.org/search/?q=%5CbRelease%5Cb+case:yes+file:catapult&sq=package:chromium&type=cs === I'll dig more into issue 831145 to figure out what went wrong. Meanwhile, what would you suggest as a more robust way to figure out the "current" output directory?
,
Apr 17 2018
What we do in several places is to write a trampoline script to the build dir as part of the build. The trampoline knows the build dir and can pass it as arg to the actual script.
,
Apr 17 2018
The tests are always launched on the builders with the build directory as the current working directory as well, so you could look at that to make a determination. However, the trampoline/wrapper script approach is what we're moving to across the board for everything, so that's probably the better fix in this case as well.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by perezju@chromium.org
, Apr 17 2018Status: Available (was: Untriaged)