New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834027 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Set an application id for a NotificationSurface.

Project Member Reported by yhanada@chromium.org, Apr 17 2018

Issue description

Currently NotificationSurface doesn't have an application id. It should be set to kArcAppIdPrefix to distinguish Surfaces for ARC++ apps from Surfaces for other exo windows.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9527bb4d9c79ac8bbc342153e3166d06188bee2

commit d9527bb4d9c79ac8bbc342153e3166d06188bee2
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Wed May 09 00:54:36 2018

Add new request to notification_surface to set an application id.

An application id of notification surfaces is needed to
distinguish notification surfaces from ARC++ apps from surfaces from
other exo clients.
IsArcNotificationWindow() in arc_ime_service.cc will be updated after
client side code is updated.

Bug:  829383 ,  834027 
Test: Build pass & Inline reply on ARC++ notifications works corretly.
Change-Id: I471d8f6be2fdd40e02178cdeb1a27b4e71b03842
Reviewed-on: https://chromium-review.googlesource.com/1039505
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557035}
[modify] https://crrev.com/d9527bb4d9c79ac8bbc342153e3166d06188bee2/components/exo/notification_surface.cc
[modify] https://crrev.com/d9527bb4d9c79ac8bbc342153e3166d06188bee2/components/exo/notification_surface.h
[modify] https://crrev.com/d9527bb4d9c79ac8bbc342153e3166d06188bee2/components/exo/wayland/server.cc
[modify] https://crrev.com/d9527bb4d9c79ac8bbc342153e3166d06188bee2/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h
[modify] https://crrev.com/d9527bb4d9c79ac8bbc342153e3166d06188bee2/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h
[modify] https://crrev.com/d9527bb4d9c79ac8bbc342153e3166d06188bee2/third_party/wayland-protocols/protocol/remote-shell-protocol.c
[modify] https://crrev.com/d9527bb4d9c79ac8bbc342153e3166d06188bee2/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml

Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4ed14123d1f6f2593eb80ca9fed35ac88c98396

commit a4ed14123d1f6f2593eb80ca9fed35ac88c98396
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Tue May 15 22:31:10 2018

Increase zcr_remote_shell_v1 version and zcr_notification_surface_v1 version to 16.

The version of the global interface should be increased when the
protocol is modified, as it is how we detect a version incompatibility
immediately on bootup.
For consistency, the version of zcr_notification_surface_v1 is also
increated in this CL.

Bug:  829383 ,  834027 
Change-Id: I33e8fbdbe0798e70743ad2af83e4ada80e7797dc
Reviewed-on: https://chromium-review.googlesource.com/1055030
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558862}
[modify] https://crrev.com/a4ed14123d1f6f2593eb80ca9fed35ac88c98396/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h
[modify] https://crrev.com/a4ed14123d1f6f2593eb80ca9fed35ac88c98396/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h
[modify] https://crrev.com/a4ed14123d1f6f2593eb80ca9fed35ac88c98396/third_party/wayland-protocols/protocol/remote-shell-protocol.c
[modify] https://crrev.com/a4ed14123d1f6f2593eb80ca9fed35ac88c98396/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml

Project Member

Comment 3 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eba861a06284fbf60bb0e6b6bddcdadf98f900e5

commit eba861a06284fbf60bb0e6b6bddcdadf98f900e5
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Mon May 21 08:49:17 2018

Update actually used zcr_remote_surface_v1 interface version to 16.

Bug:  829383 ,  834027 
Change-Id: I440f2b11b8cfe8499af913b508dcda535c554cf4
Reviewed-on: https://chromium-review.googlesource.com/1060873
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560249}
[modify] https://crrev.com/eba861a06284fbf60bb0e6b6bddcdadf98f900e5/components/exo/wayland/server.cc

Comment 4 by uekawa@chromium.org, May 23 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b8061fef925a967ceede0eb302d3256ab0bc8dd

commit 9b8061fef925a967ceede0eb302d3256ab0bc8dd
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Wed Jun 06 22:51:27 2018

Use application id in NotificationSurface to distinguish surfaces of ARC notifications.

Bug:  829383 ,  834027 
Test: IME works on ARC++ apps and notifications from ARC++ apps.
Change-Id: I98d7cb43845c668ad0afb273c623b49abf08f595
Reviewed-on: https://chromium-review.googlesource.com/1051433
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565075}
[modify] https://crrev.com/9b8061fef925a967ceede0eb302d3256ab0bc8dd/components/arc/arc_util.cc
[modify] https://crrev.com/9b8061fef925a967ceede0eb302d3256ab0bc8dd/components/arc/arc_util.h
[modify] https://crrev.com/9b8061fef925a967ceede0eb302d3256ab0bc8dd/components/arc/ime/arc_ime_service.cc

Status: Fixed (was: Started)

Sign in to add a comment