Set an application id for a NotificationSurface. |
|||
Issue descriptionCurrently NotificationSurface doesn't have an application id. It should be set to kArcAppIdPrefix to distinguish Surfaces for ARC++ apps from Surfaces for other exo windows.
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4ed14123d1f6f2593eb80ca9fed35ac88c98396 commit a4ed14123d1f6f2593eb80ca9fed35ac88c98396 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Tue May 15 22:31:10 2018 Increase zcr_remote_shell_v1 version and zcr_notification_surface_v1 version to 16. The version of the global interface should be increased when the protocol is modified, as it is how we detect a version incompatibility immediately on bootup. For consistency, the version of zcr_notification_surface_v1 is also increated in this CL. Bug: 829383 , 834027 Change-Id: I33e8fbdbe0798e70743ad2af83e4ada80e7797dc Reviewed-on: https://chromium-review.googlesource.com/1055030 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#558862} [modify] https://crrev.com/a4ed14123d1f6f2593eb80ca9fed35ac88c98396/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h [modify] https://crrev.com/a4ed14123d1f6f2593eb80ca9fed35ac88c98396/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h [modify] https://crrev.com/a4ed14123d1f6f2593eb80ca9fed35ac88c98396/third_party/wayland-protocols/protocol/remote-shell-protocol.c [modify] https://crrev.com/a4ed14123d1f6f2593eb80ca9fed35ac88c98396/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eba861a06284fbf60bb0e6b6bddcdadf98f900e5 commit eba861a06284fbf60bb0e6b6bddcdadf98f900e5 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Mon May 21 08:49:17 2018 Update actually used zcr_remote_surface_v1 interface version to 16. Bug: 829383 , 834027 Change-Id: I440f2b11b8cfe8499af913b508dcda535c554cf4 Reviewed-on: https://chromium-review.googlesource.com/1060873 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#560249} [modify] https://crrev.com/eba861a06284fbf60bb0e6b6bddcdadf98f900e5/components/exo/wayland/server.cc
,
May 23 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b8061fef925a967ceede0eb302d3256ab0bc8dd commit 9b8061fef925a967ceede0eb302d3256ab0bc8dd Author: Yuichiro Hanada <yhanada@chromium.org> Date: Wed Jun 06 22:51:27 2018 Use application id in NotificationSurface to distinguish surfaces of ARC notifications. Bug: 829383 , 834027 Test: IME works on ARC++ apps and notifications from ARC++ apps. Change-Id: I98d7cb43845c668ad0afb273c623b49abf08f595 Reviewed-on: https://chromium-review.googlesource.com/1051433 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#565075} [modify] https://crrev.com/9b8061fef925a967ceede0eb302d3256ab0bc8dd/components/arc/arc_util.cc [modify] https://crrev.com/9b8061fef925a967ceede0eb302d3256ab0bc8dd/components/arc/arc_util.h [modify] https://crrev.com/9b8061fef925a967ceede0eb302d3256ab0bc8dd/components/arc/ime/arc_ime_service.cc
,
Jun 6 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 9 2018