New issue
Advanced search Search tips

Issue 834010 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 835217
issue 835245
issue 836293

Blocking:
issue 833951
issue 834474



Sign in to add a comment

Roll Clang again

Project Member Reported by r...@chromium.org, Apr 17 2018

Issue description

Tracking bug for the next Clang roll.

Previous Clang roll:   https://crbug.com/826683 

We need to fix  crbug.com/833951  upstream and then roll clang to switch to LLD.
 

Comment 1 by r...@chromium.org, Apr 18 2018

We want at least r330300 for the checkbins LLD fix.
Blocking: 834474
Cc: vtsyrklevich@chromium.org
r330388 for  crbug.com/834474 

Comment 3 by h...@chromium.org, Apr 20 2018

Blockedon: 835217

Comment 4 by h...@chromium.org, Apr 20 2018

Blockedon: 835245

Comment 5 by h...@chromium.org, Apr 20 2018

I fixed some failing tests in r330441. The bots are still pretty red from breakages this morning, but here's a speculative packaging attempt: https://chromium-review.googlesource.com/#/c/chromium/src/+/1021575

Comment 6 by r...@chromium.org, Apr 20 2018

We probably want r330479 if we're going to switch to LLD again. Otherwise 32-bit .rdata will be read-write, and we definitely don't want to ship that.

Comment 7 by r...@chromium.org, Apr 20 2018

I started making new packages here:
https://chromium-review.googlesource.com/c/chromium/src/+/1022613

That should have what we need for LLD.

Comment 8 by r...@chromium.org, Apr 23 2018

I'm uploading those packages to goma. The ToT waterfall is currently red, but those regressions came in after I made the package.

Comment 9 by r...@chromium.org, Apr 23 2018

Oops, I got confused. I was looking at Hans's package, not mine. Mine failed with some pdb.test errors. We could go forward with Hans's packages, but we won't be able to get LLD on Windows until we roll past 330479.

Comment 10 by h...@chromium.org, Apr 24 2018

Blockedon: 836293
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28f6d78122d4499b85ae5db4dd2962ee24048165

commit 28f6d78122d4499b85ae5db4dd2962ee24048165
Author: Hans Wennborg <hans@chromium.org>
Date: Tue Apr 24 17:07:03 2018

Disable WebDriverSitePerProcessPolicyBrowserTest.Simple in official builds

The test fails in official builds (see bug). Probably this is due to
fieldtrial_testing_config.json not affecting official builds, and so
the feature needs to be explicitly enabled in the test fixture, perhaps
similarly to https://crrev.com/452026

Bug:  834010 
Change-Id: If0909e90d03f05596cc44f3a1022a0f5eca66762
Reviewed-on: https://chromium-review.googlesource.com/1026113
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553173}
[modify] https://crrev.com/28f6d78122d4499b85ae5db4dd2962ee24048165/chrome/browser/policy/site_isolation_policy_browsertest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ad5533b5ea543685391e27dade54922f9ed4bc0

commit 5ad5533b5ea543685391e27dade54922f9ed4bc0
Author: Hans Wennborg <hans@chromium.org>
Date: Wed Apr 25 01:46:05 2018

Roll clang 329921:330570.

Bug:  834010 
Change-Id: I1e5b2097bacf882cbe59f04d1321d4f369340f66
Reviewed-on: https://chromium-review.googlesource.com/1026114
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553415}
[modify] https://crrev.com/5ad5533b5ea543685391e27dade54922f9ed4bc0/tools/clang/scripts/update.py

Comment 14 by h...@chromium.org, Apr 26 2018

Status: Fixed (was: Assigned)
Next roll:  crbug.com/837440 

Sign in to add a comment