Issue metadata
Sign in to add a comment
|
[Kevin/Dru] Magnifying glass tool shows a large black square instead of rendering screen content |
||||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3396.8 (Offical Build) dev OS: Chrome 10575.4.0 dev-channel kevin FW: Goolge_Kevin.8785.264.0 What steps will reproduce the problem? (1) Recover device with R67-10575.4.0 (2) Login with user (3) Convert to tablet mode (4) Try to use Magnifying glass via the Stylus Tools menu What is the expected result? Magnifying glass should render content What happens instead? A large black square with a white circle in the center appears instead (see attached picture)
,
Apr 17 2018
,
Apr 23 2018
Can we get this triaged / escalated since it's tagged as RBB? Need to unblock release workflow. Thanks
,
Apr 24 2018
Issue reproducible on M67 10575.13.0, 67.0.3396.17 kevin.
,
Apr 24 2018
,
Apr 25 2018
We need a merge or shift to RBS from RBS. Still not triaged / assigned. Release blocks need that attention. Thanks
,
Apr 25 2018
,
Apr 25 2018
This looks like a regression. Sammie, are you the right owner?
,
Apr 25 2018
,
Apr 25 2018
Moving to RBS after review with the owner.
,
Apr 25 2018
+hoegsberg, can you take a look? Bisected to https://chromium-review.googlesource.com/c/chromium/src/+/991261 Does not appear on eve or caroline.
,
Apr 30 2018
I see the problem, let me take a look today.
,
May 1 2018
Facing same issue on Scarlet/Dru device.
,
May 1 2018
We have a fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1036467 just need to update a few unittests before it can land.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1fde8494e5740945e9a7e50fb86e296a09ea1ad commit f1fde8494e5740945e9a7e50fb86e296a09ea1ad Author: Kristian H. Kristensen <hoegsberg@chromium.org> Date: Wed May 02 00:56:19 2018 gles2_cmd_decoder: Allow GL_BGRA_EXT in CopyTexImage2D The GL_EXT_texture_format_BGRA8888 only calls out two entry points that accept the new GL_BGRA_EXT internalformat: Accepted by the <format> and <internalformat> parameters of TexImage2D and the <format> parameter of TexSubImage2D: GL_BGRA_EXT 0x80E1 Some drivers seem to silently allow the format in CopyTexImage2D, but others throw GL_INVALID_ENUM. We allow this for clients, by taking the existing TexImage2D+TexCopySubImage path when internalformat is GL_BGRA_EXT. Bug: 834006 Change-Id: I99dafd113a0320a83a171f83455cf9d93a38a2c3 Reviewed-on: https://chromium-review.googlesource.com/1036467 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555264} [modify] https://crrev.com/f1fde8494e5740945e9a7e50fb86e296a09ea1ad/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/f1fde8494e5740945e9a7e50fb86e296a09ea1ad/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc [modify] https://crrev.com/f1fde8494e5740945e9a7e50fb86e296a09ea1ad/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h [modify] https://crrev.com/f1fde8494e5740945e9a7e50fb86e296a09ea1ad/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
,
May 2 2018
,
May 2 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
,
May 2 2018
,
May 2 2018
Has there been testing to confirm the fix with no ill effects?
,
May 3 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 3 2018
No widespread testing - it fixes the issue on my kevin, passes unittests in chrome, and the patch is fairly conservative, but it would be good let it get some exposure in the dev channel.
,
May 4 2018
Has additional testing been completed per #21?
,
May 8 2018
It doesn't look like it's yet made it into a chromeos image: https://crosland.corp.google.com/cl?q=+f1fde8494e5740945e9a7e50fb86e296a09ea1ad
,
May 8 2018
What's the timeline for 67 again? If we're getting too close, I'd recommend merging it into 67 and validating there instead of waiting for ToT to pick it and then merge to 67 last minute.
,
May 10 2018
go/chrome-schedule for milestone timelines. We're past M67 branch point; any M67 inclusion requires a merge. Any merge as to be tested thoroughly to mitigate risk before we'll approve. Thanks
,
May 16 2018
Issue still reproducible on M67 (10575.40.0, 67.0.3396.49) kevin.
,
May 17 2018
Covering for Kevin, per #26 merge request is on hold for successful fix? Thanks!
,
May 17 2018
Fix has landed in Chrome ToT but ChromeOS hasn't yet upreved to a Chrome version that includes this fix (see #23). The fix is fairly minimal and safe and I'd recommend approving the merge to 67 instead of waiting for the ChromeOS builders to catch up...
,
May 18 2018
Merge approved, M67.
,
May 22 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2674b877a66d6a73296b77b41faa5d66705e1f41 commit 2674b877a66d6a73296b77b41faa5d66705e1f41 Author: Kristian H. Kristensen <hoegsberg@chromium.org> Date: Tue May 22 17:29:53 2018 gles2_cmd_decoder: Allow GL_BGRA_EXT in CopyTexImage2D The GL_EXT_texture_format_BGRA8888 only calls out two entry points that accept the new GL_BGRA_EXT internalformat: Accepted by the <format> and <internalformat> parameters of TexImage2D and the <format> parameter of TexSubImage2D: GL_BGRA_EXT 0x80E1 Some drivers seem to silently allow the format in CopyTexImage2D, but others throw GL_INVALID_ENUM. We allow this for clients, by taking the existing TexImage2D+TexCopySubImage path when internalformat is GL_BGRA_EXT. Bug: 834006 Change-Id: I99dafd113a0320a83a171f83455cf9d93a38a2c3 Reviewed-on: https://chromium-review.googlesource.com/1036467 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#555264}(cherry picked from commit f1fde8494e5740945e9a7e50fb86e296a09ea1ad) Reviewed-on: https://chromium-review.googlesource.com/1067716 Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#677} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/2674b877a66d6a73296b77b41faa5d66705e1f41/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/2674b877a66d6a73296b77b41faa5d66705e1f41/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc [modify] https://crrev.com/2674b877a66d6a73296b77b41faa5d66705e1f41/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h [modify] https://crrev.com/2674b877a66d6a73296b77b41faa5d66705e1f41/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
,
May 23 2018
Verified on Chrome OS 10575.47.0, 67.0.3396.57 kevin device. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sontis@chromium.org
, Apr 17 2018