New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834006 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

[Kevin/Dru] Magnifying glass tool shows a large black square instead of rendering screen content

Project Member Reported by matthewjoseph@chromium.org, Apr 17 2018

Issue description

Chrome Version: 67.0.3396.8 (Offical Build) dev
OS: Chrome 10575.4.0 dev-channel kevin
FW: Goolge_Kevin.8785.264.0

What steps will reproduce the problem?
(1) Recover device with R67-10575.4.0
(2) Login with user
(3) Convert to tablet mode
(4) Try to use Magnifying glass via the Stylus Tools menu

What is the expected result?
Magnifying glass should render content

What happens instead?
A large black square with a white circle in the center appears instead (see attached picture)


 
IMG_0311.JPG
485 KB View Download

Comment 1 by sontis@chromium.org, Apr 17 2018

Cc: abod...@chromium.org
Can we get this triaged / escalated since it's tagged as RBB?  Need to unblock release workflow.  Thanks
Cc: pbath...@chromium.org
Issue reproducible on M67  10575.13.0, 67.0.3396.17 kevin.
Cc: kathrelk...@chromium.org
We need a merge or shift to RBS from RBS.  Still not triaged / assigned.  Release blocks need that attention.  Thanks

Comment 7 by ka...@chromium.org, Apr 25 2018

Cc: afakhry@chromium.org wzang@chromium.org
Components: UI>Accessibility
Labels: -Type-Bug Type-Bug-Regression
Owner: sammiequon@chromium.org
Status: Assigned (was: Untriaged)
This looks like a regression. Sammie, are you the right owner?
Cc: jdufault@chromium.org
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Moving to RBS after review with the owner.
Cc: sammiequon@chromium.org
Owner: hoegsberg@chromium.org
+hoegsberg, can you take a look?

Bisected to https://chromium-review.googlesource.com/c/chromium/src/+/991261

Does not appear on eve or caroline.
Status: Started (was: Assigned)
I see the problem, let me take a look today.
Summary: [Kevin/Dru] Magnifying glass tool shows a large black square instead of rendering screen content (was: [Kevin] Magnifying glass tool shows a large black square instead of rendering screen content)
Facing same issue on Scarlet/Dru device.
We have a fix here:

  https://chromium-review.googlesource.com/c/chromium/src/+/1036467

just need to update a few unittests before it can land.


Project Member

Comment 15 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1fde8494e5740945e9a7e50fb86e296a09ea1ad

commit f1fde8494e5740945e9a7e50fb86e296a09ea1ad
Author: Kristian H. Kristensen <hoegsberg@chromium.org>
Date: Wed May 02 00:56:19 2018

gles2_cmd_decoder: Allow GL_BGRA_EXT in CopyTexImage2D

The GL_EXT_texture_format_BGRA8888 only calls out two entry points
that accept the new GL_BGRA_EXT internalformat:

    Accepted by the <format> and <internalformat> parameters of TexImage2D
    and the <format> parameter of TexSubImage2D:

        GL_BGRA_EXT                                     0x80E1

Some drivers seem to silently allow the format in CopyTexImage2D, but
others throw GL_INVALID_ENUM.  We allow this for clients, by taking
the existing TexImage2D+TexCopySubImage path when internalformat is
GL_BGRA_EXT.

Bug:  834006 
Change-Id: I99dafd113a0320a83a171f83455cf9d93a38a2c3
Reviewed-on: https://chromium-review.googlesource.com/1036467
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555264}
[modify] https://crrev.com/f1fde8494e5740945e9a7e50fb86e296a09ea1ad/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/f1fde8494e5740945e9a7e50fb86e296a09ea1ad/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/f1fde8494e5740945e9a7e50fb86e296a09ea1ad/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/f1fde8494e5740945e9a7e50fb86e296a09ea1ad/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD Merge-Request-67
Has there been testing to confirm the fix with no ill effects?

Project Member

Comment 20 by sheriffbot@chromium.org, May 3 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
No widespread testing - it fixes the issue on my kevin, passes unittests in chrome, and the patch is fairly conservative, but it would be good let it get some exposure in the dev channel.
Has additional testing been completed per #21?
It doesn't look like it's yet made it into a chromeos image:

https://crosland.corp.google.com/cl?q=+f1fde8494e5740945e9a7e50fb86e296a09ea1ad
What's the timeline for 67 again? If we're getting too close, I'd recommend merging it into 67 and validating there instead of waiting for ToT to pick it and then merge to 67 last minute. 
go/chrome-schedule for milestone timelines.

We're past M67 branch point; any M67 inclusion requires a merge.

Any merge as to be tested thoroughly to mitigate risk before we'll approve.  Thanks
Cc: sdantul...@chromium.org mkarkada@chromium.org
Issue still reproducible on M67 (10575.40.0, 67.0.3396.49) kevin.
Covering for Kevin, per #26 merge request is on hold for successful fix? Thanks!
Fix has landed in Chrome ToT but ChromeOS hasn't yet upreved to a Chrome version that includes this fix (see #23). The fix is fairly minimal and safe and I'd recommend approving the merge to 67 instead of waiting for the ChromeOS builders to catch up...
Labels: -Merge-Review-67 Merge-Approved-67
Merge approved, M67.
Project Member

Comment 30 by sheriffbot@chromium.org, May 22 2018

Cc: cindyb@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 31 by bugdroid1@chromium.org, May 22 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2674b877a66d6a73296b77b41faa5d66705e1f41

commit 2674b877a66d6a73296b77b41faa5d66705e1f41
Author: Kristian H. Kristensen <hoegsberg@chromium.org>
Date: Tue May 22 17:29:53 2018

gles2_cmd_decoder: Allow GL_BGRA_EXT in CopyTexImage2D

The GL_EXT_texture_format_BGRA8888 only calls out two entry points
that accept the new GL_BGRA_EXT internalformat:

    Accepted by the <format> and <internalformat> parameters of TexImage2D
    and the <format> parameter of TexSubImage2D:

        GL_BGRA_EXT                                     0x80E1

Some drivers seem to silently allow the format in CopyTexImage2D, but
others throw GL_INVALID_ENUM.  We allow this for clients, by taking
the existing TexImage2D+TexCopySubImage path when internalformat is
GL_BGRA_EXT.

Bug:  834006 
Change-Id: I99dafd113a0320a83a171f83455cf9d93a38a2c3
Reviewed-on: https://chromium-review.googlesource.com/1036467
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555264}(cherry picked from commit f1fde8494e5740945e9a7e50fb86e296a09ea1ad)
Reviewed-on: https://chromium-review.googlesource.com/1067716
Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#677}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/2674b877a66d6a73296b77b41faa5d66705e1f41/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/2674b877a66d6a73296b77b41faa5d66705e1f41/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/2674b877a66d6a73296b77b41faa5d66705e1f41/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/2674b877a66d6a73296b77b41faa5d66705e1f41/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

Status: Verified (was: Fixed)
Verified on Chrome OS 10575.47.0, 67.0.3396.57 kevin device.

Sign in to add a comment