Migrate ANGLE compile-only bots to the new standalone configurations |
|||||||||||
Issue descriptionThe standalone configurations are an order of magnitude faster (or more). The compile-only jobs we use for debug/x64 testing can be moved to the new configuration and should reduce the incremental compile time from 30+ minutes to 1 minute or so. This should give almost the same coverage - there are marginal gains and losses. It's unlikely that this would lead to any significant advantages or disadvantages, and the added coverage of the ANGLE samples and misc utils may be more useful than the very tiny loss in coverage for the Chromium integration. We could also at the same time rename the existing configs to make it clear if they're in debug or release mode, and that they're compile-only. We can also add configs to test Mac and ChromeOS standalone compilation, though Android isn't possible at this time.
,
Apr 27 2018
I would like to add compile bots for the the following configs: windows [msvc/clang] [debug/release] mac clang [debug/release] linux [clang/gcc] [debug/release] For each configuration I was thinking of having 4-5 try and one CI builder. Does that sound reasonable? I would need to request ~40-50 new swarming slaves to fulfill this. From the faster compiles we would be using much less computation time. We could release a bunch of machines dedicated to compiling ANGLE with Chromium.
,
Apr 27 2018
,
May 3 2018
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/e037104c14ddd6727b38eda3c41fb0ee5a01be51 commit e037104c14ddd6727b38eda3c41fb0ee5a01be51 Author: Jamie Madill <jmadill@chromium.org> Date: Thu May 03 14:38:42 2018 Add new ANGLE builder configs. These new configs will cover various compile targets on Mac, Windows and Linux, in release/debug, different compilers and x64 vs x86. This will eventually replace the old configs once everything is migrated. Bug: 833999 Change-Id: Id5d7dcf50e163e8911ab98dbe2460adcc5385086 Reviewed-on: https://chromium-review.googlesource.com/1040272 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> [modify] https://crrev.com/e037104c14ddd6727b38eda3c41fb0ee5a01be51/scripts/slave/recipes/angle.expected/win_rel_msvc_x86.json [modify] https://crrev.com/e037104c14ddd6727b38eda3c41fb0ee5a01be51/scripts/slave/recipes/angle.py [modify] https://crrev.com/e037104c14ddd6727b38eda3c41fb0ee5a01be51/scripts/slave/recipes/angle.expected/win.json [modify] https://crrev.com/e037104c14ddd6727b38eda3c41fb0ee5a01be51/scripts/slave/README.recipes.md [add] https://crrev.com/e037104c14ddd6727b38eda3c41fb0ee5a01be51/scripts/slave/recipes/angle.expected/win_clang.json [modify] https://crrev.com/e037104c14ddd6727b38eda3c41fb0ee5a01be51/scripts/slave/recipes/angle.expected/linux.json
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/db529046d0d1041aa5c9d194a1fe1e8634c25f43 commit db529046d0d1041aa5c9d194a1fe1e8634c25f43 Author: Jamie Madill <jmadill@chromium.org> Date: Fri May 04 12:24:34 2018 Add new standalone compile configs. These configs cover Win/Linux/Mac, debug/release, different compilers and x86/x64. We will then remove some of the other testers on the CQ once these are stable. Bug: chromium:833999 Change-Id: Ibcccd13b02a04e856cd7b051fe872593c2bcc047 Reviewed-on: https://chromium-review.googlesource.com/1040543 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/db529046d0d1041aa5c9d194a1fe1e8634c25f43/luci-milo.cfg [modify] https://crrev.com/db529046d0d1041aa5c9d194a1fe1e8634c25f43/cr-buildbucket.cfg [modify] https://crrev.com/db529046d0d1041aa5c9d194a1fe1e8634c25f43/luci-scheduler.cfg
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/a13570a642e23ac49e7af9ee5444502cea5758dc commit a13570a642e23ac49e7af9ee5444502cea5758dc Author: Jamie Madill <jmadill@chromium.org> Date: Fri May 04 13:28:13 2018 Fix missing mixin error with 'win-msvc'. This mixin should have been updated to the new syntax. This hopefully fixes the problem. Bug: chromium:833999 Change-Id: Ic02a71c0f60cb8880df907c80414962bbd673518 Reviewed-on: https://chromium-review.googlesource.com/1044285 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/a13570a642e23ac49e7af9ee5444502cea5758dc/cr-buildbucket.cfg
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/b2658ba0ed777cd2353578d0a220185ea61dd0f5 commit b2658ba0ed777cd2353578d0a220185ea61dd0f5 Author: Jamie Madill <jmadill@chromium.org> Date: Fri May 04 14:27:04 2018 Fix several typos in new configs. Several bots had incorrect parameters, for OS and other fields. Bug: chromium:833999 Change-Id: Id11001f3bfae6a7d52f9d6027afeb645cdeadd83 Reviewed-on: https://chromium-review.googlesource.com/1044288 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/b2658ba0ed777cd2353578d0a220185ea61dd0f5/luci-milo.cfg [modify] https://crrev.com/b2658ba0ed777cd2353578d0a220185ea61dd0f5/cr-buildbucket.cfg
,
May 4 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/958de8e9747692937531b48033eedcadcaa807a5 commit 958de8e9747692937531b48033eedcadcaa807a5 Author: Jamie Madill <jmadill@chromium.org> Date: Fri May 04 15:04:19 2018
,
May 4 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/3a1ee730381eca88ea247ac37b455b65ca491cf4 commit 3a1ee730381eca88ea247ac37b455b65ca491cf4 Author: Jamie Madill <jmadill@chromium.org> Date: Fri May 04 17:39:51 2018
,
May 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/4e5316adc85521cb33ed872380c52e43403f5295 commit 4e5316adc85521cb33ed872380c52e43403f5295 Author: Jamie Madill <jmadill@chromium.org> Date: Sat May 05 00:48:10 2018 Fix ANGLE configs defining is_clang twice. The MSVC property should have been defaulting to "None" instead of "False". Bug: 833999 Change-ID: I61379a5c2ad88d03b747972b746ed2b6377e52e9 Reviewed-on: https://chromium-review.googlesource.com/1045096 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/4e5316adc85521cb33ed872380c52e43403f5295/scripts/slave/recipes/angle.expected/win_clang.json [modify] https://crrev.com/4e5316adc85521cb33ed872380c52e43403f5295/scripts/slave/recipes/angle.expected/linux.json [modify] https://crrev.com/4e5316adc85521cb33ed872380c52e43403f5295/scripts/slave/recipes/angle.py [modify] https://crrev.com/4e5316adc85521cb33ed872380c52e43403f5295/scripts/slave/recipes/angle.expected/win.json
,
May 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/6d2e231917584a2b9c48b5c40ae89411ce625dc4 commit 6d2e231917584a2b9c48b5c40ae89411ce625dc4 Author: Jamie Madill <jmadill@chromium.org> Date: Sat May 05 12:27:58 2018 Fix bucket for new ANGLE scheduler jobs. The bucket was incorrectly 'luci.angle.try' when it should be 'luci.angle.ci'. Bug: chromium:833999 Change-Id: If056b9291d99417b75cefd5a1ff829ea5103c864 Reviewed-on: https://chromium-review.googlesource.com/1045786 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> [modify] https://crrev.com/6d2e231917584a2b9c48b5c40ae89411ce625dc4/luci-scheduler.cfg
,
May 7 2018
CI and Try jobs working now. The version of GCC on these machines is very old - they list as [GCC 4.8.4] which is prehistoric. The Skia GCC testers use [GCC 6.3.0 20170516] and my Linux desktop has a newer version than that. Is it just a matter of filing an infra labs issue and asking for a package install or something like that? Nico any advice?
,
May 7 2018
What gcc do you want to support? I think 4.8.4 is the default version on the bot image, and I'd imagine updating the image (especially one-off for angle) is involved. Updating system gcc while keeping the rest constant is afaik also difficult, so if you want a newer gcc you probably need a hermetic gcc pulled off cloud storage or something like that. The clang tot bots do that for getting a gcc to build clang with, but the src/build gn files don't yet allow a custom gcc path afaik. I'd check what v8 and skia do.
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/c009255c79d2e6594a76cb88aeaa157ce99d4ea5 commit c009255c79d2e6594a76cb88aeaa157ce99d4ea5 Author: Jamie Madill <jmadill@chromium.org> Date: Tue May 08 14:49:09 2018 Update cq.cfg with new builders. These builders are replacing the old standalone builders and the old compile-only builders. They should be much faster. They also can be extended in the future when we support running tests from ANGLE standalone. Bug: chromium:833999 Change-Id: Ice44c0fb8cb32d8be573f81d5df858509b00a107 Reviewed-on: https://chromium-review.googlesource.com/1049959 Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/c009255c79d2e6594a76cb88aeaa157ce99d4ea5/infra/config/cq.cfg
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/de1c1db091aa9e974a9679541701fb12b148b18b commit de1c1db091aa9e974a9679541701fb12b148b18b Author: Jamie Madill <jmadill@chromium.org> Date: Tue May 08 15:08:26 2018 Revert "Update cq.cfg with new builders." This reverts commit c009255c79d2e6594a76cb88aeaa157ce99d4ea5. Reason for revert: Seems to be some kind of infra or goma error with the mac configs that wasn't showing up last night. Original change's description: > Update cq.cfg with new builders. > > These builders are replacing the old standalone builders and the old > compile-only builders. They should be much faster. They also can be > extended in the future when we support running tests from ANGLE > standalone. > > Bug: chromium:833999 > Change-Id: Ice44c0fb8cb32d8be573f81d5df858509b00a107 > Reviewed-on: https://chromium-review.googlesource.com/1049959 > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=fjhenigman@chromium.org,geofflang@chromium.org,jmadill@chromium.org Change-Id: I8bf895d7473da7fe44a3bb866a2026b59a374868 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:833999 Reviewed-on: https://chromium-review.googlesource.com/1050325 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/de1c1db091aa9e974a9679541701fb12b148b18b/infra/config/cq.cfg
,
May 8 2018
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77963fef729019f887a3cdcdd58c2a965fb21c21 commit 77963fef729019f887a3cdcdd58c2a965fb21c21 Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue May 08 18:57:55 2018 Roll src/third_party/angle/ 3b9b027c5..de1c1db09 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/3b9b027c59f3..de1c1db091aa $ git log 3b9b027c5..de1c1db09 --date=short --no-merges --format='%ad %ae %s' 2018-05-08 jmadill Revert "Update cq.cfg with new builders." 2018-05-08 jmadill Update cq.cfg with new builders. Created with: roll-dep src/third_party/angle BUG= chromium:833999 , chromium:833999 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I43662d7c300123f31ed164c0d7acd9f822adb5f9 Reviewed-on: https://chromium-review.googlesource.com/1050382 Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556904} [modify] https://crrev.com/77963fef729019f887a3cdcdd58c2a965fb21c21/DEPS
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/9568037db4461d85e1875ecbc766dc6a4395cbab commit 9568037db4461d85e1875ecbc766dc6a4395cbab Author: Jamie Madill <jmadill@chromium.org> Date: Wed May 09 18:39:05 2018 Reland "Update cq.cfg with new builders." This is a reland of c009255c79d2e6594a76cb88aeaa157ce99d4ea5 Re-landing after crbug.com/840825 was updated. Original change's description: > Update cq.cfg with new builders. > > These builders are replacing the old standalone builders and the old > compile-only builders. They should be much faster. They also can be > extended in the future when we support running tests from ANGLE > standalone. > > Bug: chromium:833999 > Change-Id: Ice44c0fb8cb32d8be573f81d5df858509b00a107 > Reviewed-on: https://chromium-review.googlesource.com/1049959 > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: chromium:833999 Bug: chromium:840825 Change-Id: Ie08ebbef6b5802f0bb57053e082fac2e0f9aae34 Reviewed-on: https://chromium-review.googlesource.com/1052747 Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/9568037db4461d85e1875ecbc766dc6a4395cbab/infra/config/cq.cfg
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6028742d6670a8507aa72f54e11048e6ae9d387e commit 6028742d6670a8507aa72f54e11048e6ae9d387e Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 09 22:56:21 2018 Roll src/third_party/angle/ ce07f967c..a932b6b51 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/ce07f967c21e..a932b6b51505 $ git log ce07f967c..a932b6b51 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 lucferron Vulkan: Fix in DynamicBuffer, allocating too many buffers for no reason 2018-05-08 jmadill Reland "Update cq.cfg with new builders." Created with: roll-dep src/third_party/angle BUG= chromium:833999 , chromium:840825 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I1f2c94a095c31181848a018250723929b189a0e4 Reviewed-on: https://chromium-review.googlesource.com/1053167 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557361} [modify] https://crrev.com/6028742d6670a8507aa72f54e11048e6ae9d387e/DEPS
,
May 10 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/645c325f05d8624461fb833bc9467822c85cbf29 commit 645c325f05d8624461fb833bc9467822c85cbf29 Author: Jamie Madill <jmadill@chromium.org> Date: Thu May 10 01:30:46 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/e1cd21320c7802543bf1424905f9fdab07f2073d commit e1cd21320c7802543bf1424905f9fdab07f2073d Author: Jamie Madill <jmadill@chromium.org> Date: Thu May 10 01:31:22 2018 Remove old builder configs. Move to the new configs only and remove the old ones from the scheduler, milo and buildbucket config files. Bug: 833999 Change-Id: I26c2ef619c220ef08ecc8654e5727c1f89987ca7 Reviewed-on: https://chromium-review.googlesource.com/1053062 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Frank Henigman <fjhenigman@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/e1cd21320c7802543bf1424905f9fdab07f2073d/luci-milo.cfg [modify] https://crrev.com/e1cd21320c7802543bf1424905f9fdab07f2073d/cr-buildbucket.cfg [modify] https://crrev.com/e1cd21320c7802543bf1424905f9fdab07f2073d/luci-scheduler.cfg
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/021a2437343584732bb352f9108fceaca4ff8cc0 commit 021a2437343584732bb352f9108fceaca4ff8cc0 Author: Jamie Madill <jmadill@chromium.org> Date: Thu May 10 20:35:01 2018 Remove angle_compile tester config. These configs are superceded by the standalone ANGLE configs. Bug: 833999 Change-Id: I3b5e2fc869ea4a08b5412682aa60de9b183696f1 Reviewed-on: https://chromium-review.googlesource.com/1054147 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#557656} [modify] https://crrev.com/021a2437343584732bb352f9108fceaca4ff8cc0/infra/config/global/luci-milo-dev.cfg [modify] https://crrev.com/021a2437343584732bb352f9108fceaca4ff8cc0/infra/config/global/luci-milo.cfg [modify] https://crrev.com/021a2437343584732bb352f9108fceaca4ff8cc0/tools/mb/mb_config.pyl
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/bbdecec6895b7b60d1b1afc2dbfe3ab94293ee54 commit bbdecec6895b7b60d1b1afc2dbfe3ab94293ee54 Author: Jamie Madill <jmadill@chromium.org> Date: Thu May 10 21:21:51 2018 Update ANGLE recipe and remove compile configs. This updates the recipe to remove the 'msvc' mixin, which is no longer used. It also removes the old compile-only configs from the chromium tests trybots list. Bug: 833999 Change-Id: I6b46626526cb27c30e873a67bed4f2046707c61a Reviewed-on: https://chromium-review.googlesource.com/1054094 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> [modify] https://crrev.com/bbdecec6895b7b60d1b1afc2dbfe3ab94293ee54/scripts/slave/README.recipes.md [modify] https://crrev.com/bbdecec6895b7b60d1b1afc2dbfe3ab94293ee54/scripts/slave/recipes/angle.expected/win_rel_msvc_x86.json [add] https://crrev.com/bbdecec6895b7b60d1b1afc2dbfe3ab94293ee54/scripts/slave/recipes/angle.expected/linux_gcc.json [modify] https://crrev.com/bbdecec6895b7b60d1b1afc2dbfe3ab94293ee54/scripts/slave/recipe_modules/chromium_tests/trybots.py [modify] https://crrev.com/bbdecec6895b7b60d1b1afc2dbfe3ab94293ee54/scripts/slave/recipes/angle.py
,
May 10 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/e9a2bf9cf788d53ae9459d64dd6d2128eb32639e commit e9a2bf9cf788d53ae9459d64dd6d2128eb32639e Author: Jamie Madill <jmadill@chromium.org> Date: Thu May 10 21:33:49 2018
,
May 10 2018
Thanks for the help with this! Will file a follow-up issue to recycle the old builders.
,
May 10 2018
,
May 11 2018
,
Jul 18
,
Aug 13
,
Aug 21
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 Deleted