New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833996 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Network Error Logging: Fill in protocol field

Project Member Reported by dcreager@google.com, Apr 17 2018

Issue description

NEL beacons contain a `protocol` field, which is the ALPN protocol ID of the application-level protocol used to make the request.  This is currently not being filled in.
 
Status: Assigned (was: Untriaged)
Untriaged -> Assigned.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4467e5809ee40582965e5378d9094b4f70b7dd60

commit 4467e5809ee40582965e5378d9094b4f70b7dd60
Author: Douglas Creager <dcreager@google.com>
Date: Tue Apr 17 22:36:08 2018

Network Error Logging: Fill in protocol field

If ALPN protocol negotiation gives us an answer, use that directly;
otherwise, we assume HTTP/1.1 if any response headers were received.

Bug: 748549, 833996 
Change-Id: I33d6217ede6202358acf1a343296f5019a9b6052
Reviewed-on: https://chromium-review.googlesource.com/998021
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551505}
[modify] https://crrev.com/4467e5809ee40582965e5378d9094b4f70b7dd60/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/4467e5809ee40582965e5378d9094b4f70b7dd60/net/network_error_logging/network_error_logging_service.h
[modify] https://crrev.com/4467e5809ee40582965e5378d9094b4f70b7dd60/net/network_error_logging/network_error_logging_service_unittest.cc
[modify] https://crrev.com/4467e5809ee40582965e5378d9094b4f70b7dd60/net/url_request/url_request.cc

Comment 3 by dcreager@google.com, Apr 24 2018

Status: Fixed (was: Assigned)

Comment 4 by dcreager@google.com, Apr 24 2018

Labels: Merge-Request-67 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Requesting merge into M67.  We have approval to activate the Reporting and NetworkErrorLogging features in M67, and we weren't filling in all of the fields defined by the spec.
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 25 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89ae5599653735228e61d3b4d5ec3b22537893ef

commit 89ae5599653735228e61d3b4d5ec3b22537893ef
Author: Douglas Creager <dcreager@google.com>
Date: Wed Apr 25 16:12:52 2018

Network Error Logging: Fill in protocol field

If ALPN protocol negotiation gives us an answer, use that directly;
otherwise, we assume HTTP/1.1 if any response headers were received.

Bug: 748549, 833996 
Change-Id: I33d6217ede6202358acf1a343296f5019a9b6052
Reviewed-on: https://chromium-review.googlesource.com/998021
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551505}(cherry picked from commit 4467e5809ee40582965e5378d9094b4f70b7dd60)
Reviewed-on: https://chromium-review.googlesource.com/1028091
Cr-Commit-Position: refs/branch-heads/3396@{#293}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/89ae5599653735228e61d3b4d5ec3b22537893ef/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/89ae5599653735228e61d3b4d5ec3b22537893ef/net/network_error_logging/network_error_logging_service.h
[modify] https://crrev.com/89ae5599653735228e61d3b4d5ec3b22537893ef/net/network_error_logging/network_error_logging_service_unittest.cc
[modify] https://crrev.com/89ae5599653735228e61d3b4d5ec3b22537893ef/net/url_request/url_request.cc

Sign in to add a comment