New issue
Advanced search Search tips

Issue 833994 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS][Static Analysis] Missing calls to super init

Project Member Reported by yuweih@chromium.org, Apr 17 2018

Issue description

This may not cause a bug if the class is not a subclass of anything, but it's still better to fix them as the analyzer is complaining:


../../remoting/ios/client_gestures.mm:58:3: warning: Instance variable used while 'self' is not set to the result of '[(super or self) init...]'
  _longPressRecognizer = [[UILongPressGestureRecognizer alloc]
  ^~~~~~~~~~~~~~~~~~~~
../../remoting/ios/client_gestures.mm:58:3: note: Instance variable used while 'self' is not set to the result of '[(super or self) init...]'
  _longPressRecognizer = [[UILongPressGestureRecognizer alloc]
  ^~~~~~~~~~~~~~~~~~~~


../../ios_internal/remoting/app/refresh_control_provider_private.mm:25:3: warning: Instance variable used while 'self' is not set to the result of '[(super or self) init...]'
  _controller = [[QTMPullToRefreshController alloc]
  ^
../../ios_internal/remoting/app/refresh_control_provider_private.mm:50:10: note: Calling 'initWithScrollView:actionBlock:'
  return [[RemotingRefreshControlPrivate alloc] initWithScrollView:scrollView
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ios_internal/remoting/app/refresh_control_provider_private.mm:25:3: note: Instance variable used while 'self' is not set to the result of '[(super or self) init...]'
  _controller = [[QTMPullToRefreshController alloc]
  ^~~~~~~~~~~
1 warning generated.
[1266/1303] OBJCXX obj/ios_internal/remoting/app/common_source_set/remoting_sso_authentication.o
../../ios_internal/remoting/app/remoting_sso_authentication.mm:68:3: warning: Instance variable used while 'self' is not set to the result of '[(super or self) init...]'
  _mdmService = [[MDMService alloc] init];
  ^~~~~~~~~~~
../../ios_internal/remoting/app/remoting_sso_authentication.mm:68:3: note: Instance variable used while 'self' is not set to the result of '[(super or self) init...]'
  _mdmService = [[MDMService alloc] init];
  ^~~~~~~~~~~
 

Sign in to add a comment