"NoBackgroundTasksTest.FirstNonEmptyPaintWithoutBackgroundTasks" is flaky |
|||||
Issue description"NoBackgroundTasksTest.FirstNonEmptyPaintWithoutBackgroundTasks" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 15 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5Ob0JhY2tncm91bmRUYXNrc1Rlc3QuRmlyc3ROb25FbXB0eVBhaW50V2l0aG91dEJhY2tncm91bmRUYXNrcww. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 17 2018
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/12140 [ RUN ] NoBackgroundTasksTest.FirstNonEmptyPaintWithoutBackgroundTasks [3423:8195:0417/122125.485860:WARNING:notification_platform_bridge_mac.mm(509)] AlertNotificationService: XPC connection invalidated. BrowserTestBase received signal: Terminated: 15. Backtrace: 0 browser_tests 0x000000011249c32c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests 0x0000000112ad2085 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229 2 libsystem_platform.dylib 0x00007fffa6281b3a _sigtramp + 26 3 ??? 0x00007fe9ed966fd8 0x0 + 140642690166744 4 CoreFoundation 0x00007fff90481874 __CFRunLoopServiceMachPort + 212 5 CoreFoundation 0x00007fff90480cf1 __CFRunLoopRun + 1361 6 CoreFoundation 0x00007fff90480544 CFRunLoopRunSpecific + 420 7 HIToolbox 0x00007fff8f9dfebc RunCurrentEventLoopInMode + 240 8 HIToolbox 0x00007fff8f9dfcf1 ReceiveNextEventCommon + 432 9 HIToolbox 0x00007fff8f9dfb26 _BlockUntilNextEventMatchingListInModeWithFilter + 71 10 AppKit 0x00007fff8df78a54 _DPSNextEvent + 1120 11 AppKit 0x00007fff8e6f47ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 12 browser_tests 0x00000001125ed950 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64 13 browser_tests 0x00000001124b687a base::mac::CallWithEHFrame(void () block_pointer) + 10 14 browser_tests 0x00000001125ed894 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 164 15 AppKit 0x00007fff8df6d3db -[NSApplication run] + 926 16 browser_tests 0x00000001124c69bc base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 364 17 browser_tests 0x00000001124c54fe base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110 18 browser_tests 0x00000001124ebca5 base::RunLoop::Run() + 53 19 browser_tests 0x000000010f60cb2d NoBackgroundTasksTest_FirstNonEmptyPaintWithoutBackgroundTasks_Test::RunTestOnMainThread() + 77 20 browser_tests 0x0000000112ad1dab content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 523 21 browser_tests 0x00000001125f3979 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4233 22 browser_tests 0x00000001125f27ee ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 23 browser_tests 0x00000001111a2b93 content::BrowserMainLoop::PreMainMessageLoopRun() + 67 24 browser_tests 0x0000000111557ba7 content::StartupTaskRunner::RunAllTasksNow() + 39 25 browser_tests 0x00000001111a17ad content::BrowserMainLoop::CreateStartupTasks() + 813 26 browser_tests 0x00000001111a4fd0 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96 27 browser_tests 0x000000011119f684 content::BrowserMain(content::MainFunctionParams const&) + 180 28 browser_tests 0x00000001124380b9 content::ContentMainRunnerImpl::Run() + 377 29 browser_tests 0x00000001140cab0d service_manager::Main(service_manager::MainParams const&) + 2333 30 browser_tests 0x00000001124375e4 content::ContentMain(content::ContentMainParams const&) + 68 31 browser_tests 0x0000000112ad19be content::BrowserTestBase::SetUp() + 2574 32 browser_tests 0x000000011257a588 InProcessBrowserTest::SetUp() + 536 33 browser_tests 0x00000001107460dd testing::Test::Run() + 109 34 browser_tests 0x0000000110746d20 testing::TestInfo::Run() + 304 35 browser_tests 0x0000000110747297 testing::TestCase::Run() + 279 36 browser_tests 0x00000001107528d7 testing::internal::UnitTestImpl::RunAllTests() + 855 37 browser_tests 0x000000011075255e testing::UnitTest::Run() + 110 38 browser_tests 0x0000000112592a37 base::TestSuite::Run() + 167 39 browser_tests 0x000000011248f6a5 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37 40 browser_tests 0x0000000112af24e5 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 389 41 browser_tests 0x000000011248fb8c LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 348 42 browser_tests 0x000000011248f61e main + 94 43 libdyld.dylib 0x00007fffa6072235 start + 1 44 ??? 0x000000000000000b 0x0 + 11
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0762409042742c8d743dda42c6ba50b96f639de5 commit 0762409042742c8d743dda42c6ba50b96f639de5 Author: Mike Wasserman <msw@chromium.org> Date: Wed Apr 18 00:22:15 2018 Disable FirstNonEmptyPaintWithoutBackgroundTasks on Mac. TBR=fdoray@chromium.org Bug: 833989 Change-Id: I6cf7e67add2310af3b09c9659209f5dc60cd4c73 Reviewed-on: https://chromium-review.googlesource.com/1015846 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#551535} [modify] https://crrev.com/0762409042742c8d743dda42c6ba50b96f639de5/chrome/browser/no_background_tasks_browsertest.cc
,
Apr 19 2018
,
Aug 21
win-asan bot also fails this test but another reason: http://crbug.com/876184
,
Aug 22
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c26f3349731b7b7172efb4d5eda8e3f59017f8d commit 6c26f3349731b7b7172efb4d5eda8e3f59017f8d Author: Francois Doray <fdoray@chromium.org> Date: Fri Aug 24 17:17:22 2018 [TaskScheduler] Handle early first paint in NoBackgroundTasksTest. NoBackgroundTasksTest.FirstNonEmptyPaintWithoutBackgroundTasks is a test that verifies that the first paint in a tab can happen when TaskPriority::BEST_EFFORT tasks don't run. Before this CL, the test's body ran a RunLoop until WebContentsObserver::DidFirstVisuallyNonEmptyPaint() was invoked. A timeout occured if the first paint occured before the test's body was entered. Having the first paint before the test's body is possible, because InProcessBrowserTest::PreRunTestOnMainThread() runs tasks before jumping to the test's body (see https://cs.chromium.org/chromium/src/chrome/test/base/in_process_browser_test.cc?l=486&rcl=8edfdb37ebe40b1ba4dae27a23d8edaeac09a0ee). This CL fixes the issue by skipping running the RunLoop if WebContents::CompletedFirstVisuallyNonEmptyPaint() is already true at the beginning of the test's body. This is one of multiple fixes that will allow us to enable the test on ChromeOS. Bug: 833989 Change-Id: I0ce024bda351059c4e0ba8648e1f0f0459eb19ac Reviewed-on: https://chromium-review.googlesource.com/1187131 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#585884} [modify] https://crrev.com/6c26f3349731b7b7172efb4d5eda8e3f59017f8d/chrome/browser/no_background_tasks_browsertest.cc [modify] https://crrev.com/6c26f3349731b7b7172efb4d5eda8e3f59017f8d/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/6c26f3349731b7b7172efb4d5eda8e3f59017f8d/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/6c26f3349731b7b7172efb4d5eda8e3f59017f8d/content/public/browser/web_contents.h
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f797f8b7f518725051437e660a04bbd4c9396f4c commit f797f8b7f518725051437e660a04bbd4c9396f4c Author: Francois Doray <fdoray@chromium.org> Date: Tue Sep 18 21:52:32 2018 TaskScheduler: Enable NoBackgroundTasksTest.* on ChromeOS. Bug: 833989 Change-Id: If8927d294fc3e28791bdaac07294eace6b21c8ba Reviewed-on: https://chromium-review.googlesource.com/1231298 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592214} [modify] https://crrev.com/f797f8b7f518725051437e660a04bbd4c9396f4c/chrome/browser/no_background_tasks_browsertest.cc [modify] https://crrev.com/f797f8b7f518725051437e660a04bbd4c9396f4c/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter [modify] https://crrev.com/f797f8b7f518725051437e660a04bbd4c9396f4c/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9646f61d9918042b70f859e18a501c026323835e commit 9646f61d9918042b70f859e18a501c026323835e Author: Francois Doray <fdoray@chromium.org> Date: Thu Sep 20 17:09:45 2018 TaskScheduler: Enable NoBackgroundTasksTest.* on Mac. Bug: 833989 Change-Id: Id97ab3cf302067670b5a90e38d2077f1b7b3e89e Reviewed-on: https://chromium-review.googlesource.com/1231299 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#592844} [modify] https://crrev.com/9646f61d9918042b70f859e18a501c026323835e/chrome/browser/no_background_tasks_browsertest.cc [modify] https://crrev.com/9646f61d9918042b70f859e18a501c026323835e/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Oct 19
Test now enabled on all platforms. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by msw@chromium.org
, Apr 17 2018