New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833986 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Missing buffer flushes in wayland server code

Project Member Reported by reve...@chromium.org, Apr 17 2018

Issue description

A few events generated by Chrome will result in wayland events that are not properly flushed to the client. This can result in an undesirable delay before the client receives the event.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ea94ad7b23bdc698f9b4021d4efaee4c3de501f

commit 4ea94ad7b23bdc698f9b4021d4efaee4c3de501f
Author: David Reveman <reveman@chromium.org>
Date: Tue Apr 17 20:05:46 2018

exo: Flush keyboard keymap events properly.

This is only a problem if the keymap changes while the client is
running.

Bug:  833986 
Test: weston-eventdemo
Change-Id: I239870812a9c971132c331b5f3c3f257cda72547
Reviewed-on: https://chromium-review.googlesource.com/1015507
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551446}
[modify] https://crrev.com/4ea94ad7b23bdc698f9b4021d4efaee4c3de501f/components/exo/wayland/server.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eee69f71dd03f43ae5adaa0f0b315f6baa2ccf0

commit 5eee69f71dd03f43ae5adaa0f0b315f6baa2ccf0
Author: David Reveman <reveman@chromium.org>
Date: Tue Apr 17 20:12:52 2018

exo: Flush gamepad added events properly.

Bug:  833986 
Test: No delay in arc++ when adding new gamepad.
Change-Id: If314b5c7af90b7c308a13abf51bff5e5d27e9b77
Reviewed-on: https://chromium-review.googlesource.com/1015550
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551452}
[modify] https://crrev.com/5eee69f71dd03f43ae5adaa0f0b315f6baa2ccf0/components/exo/wayland/server.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84227cbea1c97d471205ea3a079f563bba8343dc

commit 84227cbea1c97d471205ea3a079f563bba8343dc
Author: David Reveman <reveman@chromium.org>
Date: Tue Apr 17 20:28:37 2018

exo: Flush data device related events properly.

Bug:  833986 
Test: No delays when using copy-and-paste in Crostini.
Change-Id: I6722dbd81548b760db8e1ae9a4e3cd1d4c6bf645
Reviewed-on: https://chromium-review.googlesource.com/1015700
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551462}
[modify] https://crrev.com/84227cbea1c97d471205ea3a079f563bba8343dc/components/exo/wayland/server.cc

Labels: Merge-Request-67
These are all safe fixes that only affects arc++ and crostini.
Labels: -Merge-Request-67 Merge-Approved-67
Approving merge to M67 Chrome OS.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 18 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/457f0193c9b7650e4f3215b18847c9b1ff81ea01

commit 457f0193c9b7650e4f3215b18847c9b1ff81ea01
Author: David Reveman <reveman@chromium.org>
Date: Wed Apr 18 18:58:28 2018

exo: Flush keyboard keymap events properly.

This is only a problem if the keymap changes while the client is
running.

TBR=reveman@chromium.org

(cherry picked from commit 4ea94ad7b23bdc698f9b4021d4efaee4c3de501f)

Bug:  833986 
Test: weston-eventdemo
Change-Id: I239870812a9c971132c331b5f3c3f257cda72547
Reviewed-on: https://chromium-review.googlesource.com/1015507
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551446}
Reviewed-on: https://chromium-review.googlesource.com/1017560
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#91}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/457f0193c9b7650e4f3215b18847c9b1ff81ea01/components/exo/wayland/server.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea1732eaf9d11c49ef7bee4bcf806bc8b0f93075

commit ea1732eaf9d11c49ef7bee4bcf806bc8b0f93075
Author: David Reveman <reveman@chromium.org>
Date: Wed Apr 18 19:00:22 2018

exo: Flush gamepad added events properly.

TBR=reveman@chromium.org

(cherry picked from commit 5eee69f71dd03f43ae5adaa0f0b315f6baa2ccf0)

Bug:  833986 
Test: No delay in arc++ when adding new gamepad.
Change-Id: If314b5c7af90b7c308a13abf51bff5e5d27e9b77
Reviewed-on: https://chromium-review.googlesource.com/1015550
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551452}
Reviewed-on: https://chromium-review.googlesource.com/1017600
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#92}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/ea1732eaf9d11c49ef7bee4bcf806bc8b0f93075/components/exo/wayland/server.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3a27d39aa99081a7a658b8541a9def9e9dd2ab3

commit c3a27d39aa99081a7a658b8541a9def9e9dd2ab3
Author: David Reveman <reveman@chromium.org>
Date: Wed Apr 18 19:02:08 2018

exo: Flush data device related events properly.

TBR=reveman@chromium.org

(cherry picked from commit 84227cbea1c97d471205ea3a079f563bba8343dc)

Bug:  833986 
Test: No delays when using copy-and-paste in Crostini.
Change-Id: I6722dbd81548b760db8e1ae9a4e3cd1d4c6bf645
Reviewed-on: https://chromium-review.googlesource.com/1015700
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551462}
Reviewed-on: https://chromium-review.googlesource.com/1017601
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#93}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/c3a27d39aa99081a7a658b8541a9def9e9dd2ab3/components/exo/wayland/server.cc

Status: Fixed (was: Assigned)
Components: OS>Systems>Containers

Sign in to add a comment