We need to figure out if writing into vpd is a cause of mismatch in the number of omaha first active counts. Add a uma metric for it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dad8ffafe25e5dea8e35bab683348d1bfa93f31 commit 9dad8ffafe25e5dea8e35bab683348d1bfa93f31 Author: Amin Hassani <ahassani@chromium.org> Date: Tue May 22 23:40:16 2018 Add enum value kErrorCodeFirstActiveOmahaPingSentPersistenceError Add enum value kErrorCodeFirstActiveOmahaPingSentPersistenceError to enum UpdateEngineErrorCode. Bug: 833980 Change-Id: I092149a7ceb608898587a37e3aaab5c520db95ff Reviewed-on: https://chromium-review.googlesource.com/1062659 Reviewed-by: Xiaochu Liu <xiaochu@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#560835} [modify] https://crrev.com/9dad8ffafe25e5dea8e35bab683348d1bfa93f31/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/80f4d4cefb5270960d17cd347d71594e97c7a954 commit 80f4d4cefb5270960d17cd347d71594e97c7a954 Author: Amin Hassani <ahassani@chromium.org> Date: Wed May 23 19:50:53 2018 update_engine: Report VPD write failure to UMA Currently we see many first actives to come from non-FSI images. But we have not been able to figure out why. This CL, reports a new error kFirstActiveOmahaPingSentPersistenceError when writing the first active omaha flag into VPD fails. This allows us to see if that is the actual cause of the problem. CL:1062659 adds the enum value on the Chrome side. BUG= chromium:833980 TEST=unittests TEST=precq Change-Id: I65e233c5f895489ba905494fb20d7b00d0c4af10 Reviewed-on: https://chromium-review.googlesource.com/1062662 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/common/fake_hardware.h [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/hardware_chromeos.cc [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/payload_state.cc [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/metrics_reporter_omaha.cc [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/metrics_utils.cc [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/update_manager/chromeos_policy.cc [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/common/error_code.h [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/hardware_chromeos.h [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/hardware_android.h [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/hardware_android.cc [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/common/error_code_utils.cc [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/mock_metrics_reporter.h [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/omaha_request_action.cc [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/metrics_reporter_interface.h [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/common/hardware_interface.h [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/metrics_reporter_android.h [modify] https://crrev.com/80f4d4cefb5270960d17cd347d71594e97c7a954/metrics_reporter_omaha.h
Comment 1 by ahass...@chromium.org
, May 16 2018