New issue
Advanced search Search tips

Issue 833977 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

SimpleURLLoader retries don't work with SharedURLLoaderFactory.

Project Member Reported by mmenke@chromium.org, Apr 17 2018

Issue description

SimpleURLLoader needs to use URLLoaderFactory::Clone() to retry requests, but SharedURLLoaderFactory's Clone() method has a NOTREACHED() in it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/401cd27434c99b5e12bfe49e6186dff6cc4a7997

commit 401cd27434c99b5e12bfe49e6186dff6cc4a7997
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Apr 18 22:10:22 2018

Add URLLoaderFactory::Clone() support to SharedURLLoaderFactory.

SimpleURLLoader requires access to Clone() to enable retries, so this
will allow that use case with SharedURLLoaderFactories.  This CL removes
the NOTREACHED() implementation of Clone() from SharedURLLoaderFactory
itself, and implements function versions in many, though not all,
subclasses.

Bug:  833977 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9d9aabc74282d36001d0bd2464c94ed70f9d63c8
Reviewed-on: https://chromium-review.googlesource.com/1015544
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551843}
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/chrome/browser/extensions/test_blacklist_state_fetcher.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/chrome/browser/safe_browsing/download_protection/download_feedback_unittest.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/chrome/browser/safe_browsing/download_protection/two_phase_uploader_unittest.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/components/feed/core/feed_networking_host_unittest.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/components/ntp_snippets/contextual/contextual_suggestions_fetcher_impl_unittest.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/components/safe_browsing/browser/safe_browsing_network_context.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/browser/url_loader_factory_getter.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/browser/web_package/signed_exchange_url_loader_factory_for_non_network_service.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/browser/web_package/signed_exchange_url_loader_factory_for_non_network_service.h
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/common/single_request_url_loader_factory.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/common/single_request_url_loader_factory.h
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/common/url_loader_factory_bundle.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/common/url_loader_factory_bundle.h
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/common/wrapper_shared_url_loader_factory.h
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/public/common/weak_wrapper_shared_url_loader_factory.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/content/public/common/weak_wrapper_shared_url_loader_factory.h
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/services/network/public/cpp/shared_url_loader_factory.cc
[modify] https://crrev.com/401cd27434c99b5e12bfe49e6186dff6cc4a7997/services/network/public/cpp/shared_url_loader_factory.h

Comment 2 by mmenke@chromium.org, Apr 18 2018

Status: Fixed (was: Assigned)

Sign in to add a comment