Call glFlush on nyan boards only |
||
Issue descriptionRelated bug: crbug.com/720045 We need to call glFlush() on nyan since NVIDIA's implementation of EGL_EXT_image_flush_external is broken. However on other platform this isn't needed. Add this to the GPU driver bug list and have the workaround on NVIDIA based platforms.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c753781a0f97dbf9670db7bbfc9c99a2d922a8d commit 3c753781a0f97dbf9670db7bbfc9c99a2d922a8d Author: Daniel Nicoara <dnicoara@chromium.org> Date: Thu Apr 19 19:41:41 2018 Perform glFlush only on NVIDIA platforms EGL_EXT_image_flush_external is broken on NVIDIA and causes image corruption. corruption. Bug: 833975 Test: Ran on nyan_big, samus and veyron_jerry and verified there is no Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I218bb111470e7db18906834f43fd1ad92f28b4bc Reviewed-on: https://chromium-review.googlesource.com/1017236 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#552121} [modify] https://crrev.com/3c753781a0f97dbf9670db7bbfc9c99a2d922a8d/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/3c753781a0f97dbf9670db7bbfc9c99a2d922a8d/gpu/config/gpu_driver_bug_list.json [modify] https://crrev.com/3c753781a0f97dbf9670db7bbfc9c99a2d922a8d/gpu/config/gpu_workaround_list.txt [modify] https://crrev.com/3c753781a0f97dbf9670db7bbfc9c99a2d922a8d/ui/gl/gl_surface.cc [modify] https://crrev.com/3c753781a0f97dbf9670db7bbfc9c99a2d922a8d/ui/gl/gl_surface.h [modify] https://crrev.com/3c753781a0f97dbf9670db7bbfc9c99a2d922a8d/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc [modify] https://crrev.com/3c753781a0f97dbf9670db7bbfc9c99a2d922a8d/ui/ozone/platform/drm/gpu/gbm_surfaceless.h
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd851c271a9dcc8701cc4281dcd3f576480767ae commit fd851c271a9dcc8701cc4281dcd3f576480767ae Author: Miguel Casas <mcasas@chromium.org> Date: Fri Apr 20 18:03:27 2018 Revert "Perform glFlush only on NVIDIA platforms" This reverts commit 3c753781a0f97dbf9670db7bbfc9c99a2d922a8d. Reason for revert: Observed content tearing e.g. on video, see https://crbug.com/835362 Original change's description: > Perform glFlush only on NVIDIA platforms > > EGL_EXT_image_flush_external is broken on NVIDIA and causes image > corruption. > > corruption. > > Bug: 833975 > Test: Ran on nyan_big, samus and veyron_jerry and verified there is no > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I218bb111470e7db18906834f43fd1ad92f28b4bc > Reviewed-on: https://chromium-review.googlesource.com/1017236 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552121} TBR=reveman@chromium.org,kbr@chromium.org,dnicoara@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org Change-Id: Id81eaa6c2ff74e5ab5f7935d5a0fcf470e5317f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 833975 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1021973 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#552389} [modify] https://crrev.com/fd851c271a9dcc8701cc4281dcd3f576480767ae/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/fd851c271a9dcc8701cc4281dcd3f576480767ae/gpu/config/gpu_driver_bug_list.json [modify] https://crrev.com/fd851c271a9dcc8701cc4281dcd3f576480767ae/gpu/config/gpu_workaround_list.txt [modify] https://crrev.com/fd851c271a9dcc8701cc4281dcd3f576480767ae/ui/gl/gl_surface.cc [modify] https://crrev.com/fd851c271a9dcc8701cc4281dcd3f576480767ae/ui/gl/gl_surface.h [modify] https://crrev.com/fd851c271a9dcc8701cc4281dcd3f576480767ae/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc [modify] https://crrev.com/fd851c271a9dcc8701cc4281dcd3f576480767ae/ui/ozone/platform/drm/gpu/gbm_surfaceless.h
,
Apr 20 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by dnicoara@chromium.org
, Apr 17 2018